From patchwork Fri May 13 07:18:47 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 781852 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p4D7JUSS014686 for ; Fri, 13 May 2011 07:19:31 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757331Ab1EMHTR (ORCPT ); Fri, 13 May 2011 03:19:17 -0400 Received: from mail-bw0-f46.google.com ([209.85.214.46]:36076 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757077Ab1EMHSw (ORCPT ); Fri, 13 May 2011 03:18:52 -0400 Received: by bwz15 with SMTP id 15so1903367bwz.19 for ; Fri, 13 May 2011 00:18:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:message-id:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=7PXWuVB7gByg77jaJG0geBcm0tQHpXWwtIgat7RQuSs=; b=vWVi9gPZe202WTujon641Gv/eln6xaMlVSxQ8djAF1aiqfTVgyw6rdYOhNFmussEr3 vXvOoNH7repFbaTaiDPn18jtWi+3j4VPVdC6Z7aeVLLm+f1h6npwV0zvQ/q8ggqb3/hZ ies4ORgynQMIQgbEIWiqonLYyEGFzo7DmY670= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=G1jhGU/KlAU3jUtz9JI6rtpV98nAZVRmL61MTIk0ITy2yUsoNMcBU/aYY3DlRQAuoh rPr1cRLr1dz8Blc2RgIZobopXAF5xpFMNdtZQ+MS+K/z5VaFEv+HJKDS3o09WiBKAZkt PP5ijNdAsPijXuvdcVowhjdkw0bBOE9WyAHac= Received: by 10.204.19.83 with SMTP id z19mr323442bka.191.1305271130579; Fri, 13 May 2011 00:18:50 -0700 (PDT) Received: from [192.168.2.129] ([178.22.113.142]) by mx.google.com with ESMTPS id l1sm1173379bkl.1.2011.05.13.00.18.48 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 13 May 2011 00:18:48 -0700 (PDT) Message-ID: <4DCCDB57.70706@suse.cz> Date: Fri, 13 May 2011 09:18:47 +0200 From: Jiri Slaby User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; cs-CZ; rv:1.9.2.17) Gecko/20110414 SUSE/3.1.10 Thunderbird/3.1.10 MIME-Version: 1.0 To: Matthew Garrett CC: Jesse Barnes , Jiri Slaby , Robert Hancock , lenb@kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 1/1] ACPI: pci_irq, add PRT_ quirk for IBM Bartolo References: <4C87A62E.30108@gmail.com> <1302598086-3622-1-git-send-email-jslaby@suse.cz> <20110412085622.43488ed9@jbarnes-desktop> <20110412155921.GA531@srcf.ucam.org> In-Reply-To: <20110412155921.GA531@srcf.ucam.org> X-Enigmail-Version: 1.1.2 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Fri, 13 May 2011 07:19:31 +0000 (UTC) On 04/12/2011 05:59 PM, Matthew Garrett wrote: > On Tue, Apr 12, 2011 at 08:56:22AM -0700, Jesse Barnes wrote: >> I'll defer to the ACPI experts, Len or Matthew have you checked this >> one out? > > Windows appears to work without this, so it seems likely that we're > doing something wrong in some other sense, but I don't think we have a > good idea as to what we're doing wrong... I changed the irq assignment like (to take the lowest available/non-conflicting IRQ): And with this change it works _without_ acpi=noirq. Does it help somehow? dmesg then shows a difference like: serial8250: ttyS1 at I/O 0x2f8 (irq = 3) is a 16550A 00:07: ttyS0 at I/O 0x3f8 (irq = 4) is a 16550A 00:08: ttyS1 at I/O 0x2f8 (irq = 3) is a 16550A -ACPI: PCI Interrupt Link [LNKB] enabled at IRQ 11 -PCI: setting IRQ 11 as level-triggered -serial 0000:00:09.0: PCI INT A -> Link[LNKB] -> GSI 11 (level, low) -> IRQ 11 -0000:00:09.0: ttyS4 at I/O 0x1898 (irq = 11) is a 16550A -0000:00:09.0: ttyS5 at I/O 0x1890 (irq = 11) is a 16550A +ACPI: PCI Interrupt Link [LNKB] enabled at IRQ 10 +PCI: setting IRQ 10 as level-triggered +serial 0000:00:09.0: PCI INT A -> Link[LNKB] -> GSI 10 (level, low) -> IRQ 10 +0000:00:09.0: ttyS4 at I/O 0x1898 (irq = 10) is a 16550A +0000:00:09.0: ttyS5 at I/O 0x1890 (irq = 10) is a 16550A ACPI: PCI Interrupt Link [LNKA] enabled at IRQ 11 +PCI: setting IRQ 11 as level-triggered serial 0000:00:0b.0: PCI INT A -> Link[LNKA] -> GSI 11 (level, low) -> IRQ 11 0000:00:0b.0: ttyS6 at I/O 0x18c0 (irq = 11) is a 16550A 0000:00:0b.0: ttyS7 at I/O 0x18b8 (irq = 11) is a 16550A thanks, --- a/drivers/acpi/pci_link.c +++ b/drivers/acpi/pci_link.c @@ -557,7 +557,7 @@ static int acpi_pci_link_allocate(struct * the use of IRQs 9, 10, 11, and >15. */ for (i = (link->irq.possible_count - 1); i >= 0; i--) { - if (acpi_irq_penalty[irq] > + if (acpi_irq_penalty[irq] >= acpi_irq_penalty[link->irq.possible[i]]) irq = link->irq.possible[i]; }