From patchwork Fri Sep 7 06:40:31 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 1420031 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id ADA9CDF283 for ; Fri, 7 Sep 2012 06:39:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753913Ab2IGGjh (ORCPT ); Fri, 7 Sep 2012 02:39:37 -0400 Received: from nat28.tlf.novell.com ([130.57.49.28]:55434 "EHLO nat28.tlf.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751343Ab2IGGjh convert rfc822-to-8bit (ORCPT ); Fri, 7 Sep 2012 02:39:37 -0400 Received: from EMEA1-MTA by nat28.tlf.novell.com with Novell_GroupWise; Fri, 07 Sep 2012 07:39:36 +0100 Message-Id: <5049B2FF02000078000998F3@nat28.tlf.novell.com> X-Mailer: Novell GroupWise Internet Agent 12.0.0 Date: Fri, 07 Sep 2012 07:40:31 +0100 From: "Jan Beulich" To: "Len Brown" Cc: , "Konrad Rzeszutek Wilk" , Subject: [PATCH] GHES: correct page protection flags in ghes_ioremap_pfn_...() Mime-Version: 1.0 Content-Disposition: inline Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org At least for Xen Dom0 it is very relevant to set the _PAGE_IO bit when ioremap-ing (non-RAM) areas, as that flag suppresses the PFN -> MFN translation otherwise done in PV guests. (The offending commit was 81e88fdc432a1552401d6e91a984dcccce72b8dc.) Signed-off-by: Jan Beulich Cc: Huang Ying Cc: Konrad Rzeszutek Wilk Reviewed-by: Huang Ying --- drivers/acpi/apei/ghes.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- 3.6-rc4/drivers/acpi/apei/ghes.c +++ 3.6-rc4-ghes-ioremap-prot/drivers/acpi/apei/ghes.c @@ -206,7 +206,7 @@ static void __iomem *ghes_ioremap_pfn_nm vaddr = (unsigned long)GHES_IOREMAP_NMI_PAGE(ghes_ioremap_area->addr); ioremap_page_range(vaddr, vaddr + PAGE_SIZE, - pfn << PAGE_SHIFT, PAGE_KERNEL); + pfn << PAGE_SHIFT, PAGE_KERNEL_IO); return (void __iomem *)vaddr; } @@ -217,7 +217,7 @@ static void __iomem *ghes_ioremap_pfn_ir vaddr = (unsigned long)GHES_IOREMAP_IRQ_PAGE(ghes_ioremap_area->addr); ioremap_page_range(vaddr, vaddr + PAGE_SIZE, - pfn << PAGE_SHIFT, PAGE_KERNEL); + pfn << PAGE_SHIFT, PAGE_KERNEL_IO); return (void __iomem *)vaddr; }