| Message ID | 506CEADA.9060108@jp.fujitsu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Oct 3, 2012 at 6:48 PM, Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> wrote: > From: Wen Congyang <wency@cn.fujitsu.com> > > The memory device has been ejected and powoffed, so we can call > acpi_bus_remove() to remove the memory device from acpi bus. > > CC: Len Brown <len.brown@intel.com> > Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> > Signed-off-by: Wen Congyang <wency@cn.fujitsu.com> > --- > drivers/acpi/acpi_memhotplug.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > Index: linux-3.6/drivers/acpi/acpi_memhotplug.c > =================================================================== > --- linux-3.6.orig/drivers/acpi/acpi_memhotplug.c 2012-10-03 18:17:47.802249170 +0900 > +++ linux-3.6/drivers/acpi/acpi_memhotplug.c 2012-10-03 18:17:52.471250299 +0900 > @@ -424,8 +424,9 @@ static void acpi_memory_device_notify(ac > } > > /* > - * TBD: Invoke acpi_bus_remove to cleanup data structures > + * Invoke acpi_bus_remove() to remove memory device > */ > + acpi_bus_remove(device, 1); why not using acpi_bus_trim instead? Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
At 10/04/2012 10:41 AM, Yinghai Lu Wrote: > On Wed, Oct 3, 2012 at 6:48 PM, Yasuaki Ishimatsu > <isimatu.yasuaki@jp.fujitsu.com> wrote: >> From: Wen Congyang <wency@cn.fujitsu.com> >> >> The memory device has been ejected and powoffed, so we can call >> acpi_bus_remove() to remove the memory device from acpi bus. >> >> CC: Len Brown <len.brown@intel.com> >> Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> >> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com> >> --- >> drivers/acpi/acpi_memhotplug.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> Index: linux-3.6/drivers/acpi/acpi_memhotplug.c >> =================================================================== >> --- linux-3.6.orig/drivers/acpi/acpi_memhotplug.c 2012-10-03 18:17:47.802249170 +0900 >> +++ linux-3.6/drivers/acpi/acpi_memhotplug.c 2012-10-03 18:17:52.471250299 +0900 >> @@ -424,8 +424,9 @@ static void acpi_memory_device_notify(ac >> } >> >> /* >> - * TBD: Invoke acpi_bus_remove to cleanup data structures >> + * Invoke acpi_bus_remove() to remove memory device >> */ >> + acpi_bus_remove(device, 1); > > why not using acpi_bus_trim instead? Sorry for late reply. It's OK to use acpi_bus_trim(), and I will update this patch soon. Thanks Wen Congyang > > Yinghai > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: linux-3.6/drivers/acpi/acpi_memhotplug.c =================================================================== --- linux-3.6.orig/drivers/acpi/acpi_memhotplug.c 2012-10-03 18:17:47.802249170 +0900 +++ linux-3.6/drivers/acpi/acpi_memhotplug.c 2012-10-03 18:17:52.471250299 +0900 @@ -424,8 +424,9 @@ static void acpi_memory_device_notify(ac } /* - * TBD: Invoke acpi_bus_remove to cleanup data structures + * Invoke acpi_bus_remove() to remove memory device */ + acpi_bus_remove(device, 1); /* _EJ0 succeeded; _OST is not necessary */ return;