From patchwork Fri Apr 28 05:43:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sricharan Ramabadhran X-Patchwork-Id: 9703909 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BD451602BE for ; Fri, 28 Apr 2017 05:43:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A32102862A for ; Fri, 28 Apr 2017 05:43:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9796E2863C; Fri, 28 Apr 2017 05:43:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_TVD_MIME_EPI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7CD212862A for ; Fri, 28 Apr 2017 05:43:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756527AbdD1Fnn (ORCPT ); Fri, 28 Apr 2017 01:43:43 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:38344 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756525AbdD1Fnm (ORCPT ); Fri, 28 Apr 2017 01:43:42 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 88B4D614E6; Fri, 28 Apr 2017 05:43:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1493358221; bh=KVVO9Wx6rYxc+61FSOKH5vviz4zP8Y4zVxAxIdR3834=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=LqM457wlu/TTyi1e9Ct2y4IEfkRf/yyGssGv+/7gVevj6iFjWtfjn4IO4iI+K8Scm PlDYIApRBsblhEGCjrmSD2gHSKwX44JCP79ZpxrOD4RljBpHZconSoOfptvGjPTG23 Nz8jwNDAvDXkeLjSTQjUMbvNdOkb5KvN5cbv+MYg= Received: from [10.201.3.39] (unknown [202.46.23.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sricharan@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 17C3261484; Fri, 28 Apr 2017 05:43:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1493358220; bh=KVVO9Wx6rYxc+61FSOKH5vviz4zP8Y4zVxAxIdR3834=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=UNH1kkkJqtJgKmUbbP0swDkakl5i8OTLBWzVEz0dE9NyaB+u3OZ2BpCVp3flNZ73h aTECkYyioGTir3pD9/ebsDuPBNiQIrvhlYwz3SNreY+OxXoxiHp26i85dUaxmB6MBG zJkpLb00nudh8vT62/IIhx0pUYIyXg5NBBzxfAc4= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 17C3261484 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sricharan@codeaurora.org Subject: Re: [REGRESSION next-20170426] Commit 09515ef5ddad ("of/acpi: Configure dma operations at probe time for platform/amba/pci bus devices") causes oops in mvneta To: Ralph Sennhauser Cc: "Rafael J. Wysocki" , Joerg Roedel , Bjorn Helgaas , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Thomas Petazzoni , netdev@vger.kernel.org References: <20170426181508.687b52af@gmail.com> <2fb57b9b-3944-d9cc-1fac-8dcccaa0c37a@codeaurora.org> <20170427164014.422a124c@gmail.com> From: Sricharan R Message-ID: <524b7fc8-1eca-a7d8-7bc7-6743be17c208@codeaurora.org> Date: Fri, 28 Apr 2017 11:13:33 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <20170427164014.422a124c@gmail.com> Content-Language: en-US Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Ralph, On 4/27/2017 8:10 PM, Ralph Sennhauser wrote: > On Thu, 27 Apr 2017 19:05:09 +0530 > Sricharan R wrote: > >> Hi, >> >> On 4/26/2017 9:45 PM, Ralph Sennhauser wrote: >>> Hi Sricharan R, >>> >>> Commit 09515ef5ddad ("of/acpi: Configure dma operations at probe >>> time for platform/amba/pci bus devices") causes a kernel panic as >>> in the log below on an armada-385. Reverting the commit fixes the >>> issue. >>> >>> Regards >>> Ralph >> >> Somehow not getting a obvious clue on whats going wrong with the logs >> below. From the log and looking in to dts, the drivers seems to the >> one for "marvell,armada-370-neta". > > Correct. > >> Issue looks the data from the dma >> has gone bad and subsequently referring the wrong data has resulted >> in the crash. Looks like the dma_masks is the one going wrong. >> Can i get some logs from mvneta_probe, about dev->dma_mask, >> dev->coherent_dma_mask and dev->dma_ops with and without the patch >> to see whats the difference ? > > Not sure I understood what exactly you are after. Might be faster to > just send me a patch with all debug print statements you like to see. > Attached the patch with debug prints. Regards, Sricharan diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index d297011..250f0b2 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -4146,6 +4146,12 @@ static int mvneta_probe(struct platform_device *pdev) int phy_mode; int err; int cpu; + struct device *ddev = &pdev->dev; + + + dev_err(ddev, "dev->dma_mask 0x%llx\n", *(ddev->dma_mask)); + dev_err(ddev, "dev->coherent_dma_mask 0x%llx\n", ddev->coherent_dma_mask); + dev_err(ddev, "dev->dma_ops 0x%llx\n", ddev->dma_ops); dev = alloc_etherdev_mqs(sizeof(struct mvneta_port), txq_number, rxq_number); if (!dev)