From patchwork Thu May 15 14:49:37 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "lan,Tianyu" X-Patchwork-Id: 4182991 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 5B9B99F1C0 for ; Thu, 15 May 2014 14:49:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 99EA620379 for ; Thu, 15 May 2014 14:49:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DB2F20220 for ; Thu, 15 May 2014 14:49:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753002AbaEOOto (ORCPT ); Thu, 15 May 2014 10:49:44 -0400 Received: from mga03.intel.com ([143.182.124.21]:51119 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752170AbaEOOtn (ORCPT ); Thu, 15 May 2014 10:49:43 -0400 Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga101.ch.intel.com with ESMTP; 15 May 2014 07:49:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,1059,1389772800"; d="scan'208";a="432594506" Received: from unknown (HELO tlan1-mobl3.ccr.corp.intel.com) ([10.255.20.122]) by azsmga001.ch.intel.com with ESMTP; 15 May 2014 07:49:38 -0700 Message-ID: <5374D401.2010608@intel.com> Date: Thu, 15 May 2014 22:49:37 +0800 From: Lan Tianyu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Rolf Eike Beer CC: wsa@the-dreams.de, rjw@rjwysocki.net, mika.westerberg@linux.intel.com, awilliam@redhat.com, lenb@kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [Patch V2 0/9] I2C ACPI operation region handler support References: <1398147855-9868-1-git-send-email-tianyu.lan@intel.com> <3275231.ERSr3mUlis@devpool02> <53722700.6010001@intel.com> <2676258.HXv5hGZIFG@devpool02> In-Reply-To: <2676258.HXv5hGZIFG@devpool02> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 05/15/2014 03:50 PM, Rolf Eike Beer wrote: > Lan Tianyu wrote: >> On 05/13/2014 09:09 PM, Rolf Eike Beer wrote: >>> Am Montag, 28. April 2014, 22:27:39 schrieb Lan Tianyu: >>>> ACPI 5.0 spec(5.5.2.4.5) defines GenericSerialBus(i2c, spi, uart) >>>> operation >>>> region. It allows ACPI aml code able to access such kind of devices to >>>> implement some ACPI standard method. >>>> >>>> On the Asus T100TA, Bios use GenericSerialBus operation region to access >>>> i2c device to get battery info. So battery function depends on the I2C >>>> operation region support. Here is the bug link. >>>> https://bugzilla.kernel.org/show_bug.cgi?id=69011 >>> >>> Hi all, >> >>> I have tested this series and got some errors, but no additional > functionality: >> Hi Rolf: >> Thanks for test. Could you attach the output of dmesg and acpidump? >> Which machine you are testing on? > > Hi, > > this is an Aava Inari 8 tablet (pre-release hardware). Please find the DSDT > and the dmesg.log attached. > > In case of any further questions don't hesitate to ask, I'll try to be more > responsible. > Hi Eike: Could you apply the patch in the attachment and attach the output of dmesg? > Regards, > > Eike > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index 4ed8d48..cc8c132 100644 --- a/drivers/acpi/bus.c +++ b/drivers/acpi/bus.c @@ -139,8 +139,7 @@ int acpi_bus_attach_private_data(acpi_handle handle, void *data) status = acpi_attach_data(handle, acpi_bus_private_data_handler, data); if (ACPI_FAILURE(status)) { - ACPI_ERROR((AE_INFO, "Error attaching device[%p] data\n", - handle)); + acpi_handle_err(handle, "Error attaching device data %d\n", status); return -ENODEV; }