| Message ID | 547f8b.93e.18b26e5e031.Coremail.chenguohua@jari.cn (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | ACPI: Clean up errors in acpi.h | expand |
First, the subject is misleading, because the patch doesn't address any errors, but cleans up the usage of white space. On Fri, Oct 13, 2023 at 6:32 AM <chenguohua@jari.cn> wrote: > > Fix the following errors reported by checkpatch: Why does it make sense to run checkpatch on the existing code? > ERROR: "foo * bar" should be "foo *bar" > ERROR: space required after that ';' (ctx:VxV) > > Signed-off-by: GuoHua Cheng <chenguohua@jari.cn> Please fix the changelog to simply state that it cleans up the usage of white space so it is consistent with the kernel coding style. > --- > include/linux/acpi.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/acpi.h b/include/linux/acpi.h > index 9bcf5641a7cf..b55a8ac627e9 100644 > --- a/include/linux/acpi.h > +++ b/include/linux/acpi.h > @@ -1421,7 +1421,7 @@ acpi_graph_get_remote_endpoint(const struct fwnode_handle *fwnode, > } > > #define ACPI_DECLARE_PROBE_ENTRY(table, name, table_id, subtable, valid, data, fn) \ > - static const void * __acpi_table_##name[] \ > + static const void *__acpi_table_##name[] \ > __attribute__((unused)) \ > = { (void *) table_id, \ > (void *) subtable, \ > @@ -1429,7 +1429,7 @@ acpi_graph_get_remote_endpoint(const struct fwnode_handle *fwnode, > (void *) fn, \ > (void *) data } > > -#define acpi_probe_device_table(t) ({ int __r = 0; __r;}) > +#define acpi_probe_device_table(t) ({ int __r = 0; __r; }) > #endif > > #ifdef CONFIG_ACPI_TABLE_UPGRADE > --
diff --git a/include/linux/acpi.h b/include/linux/acpi.h index 9bcf5641a7cf..b55a8ac627e9 100644 --- a/include/linux/acpi.h +++ b/include/linux/acpi.h @@ -1421,7 +1421,7 @@ acpi_graph_get_remote_endpoint(const struct fwnode_handle *fwnode, } #define ACPI_DECLARE_PROBE_ENTRY(table, name, table_id, subtable, valid, data, fn) \ - static const void * __acpi_table_##name[] \ + static const void *__acpi_table_##name[] \ __attribute__((unused)) \ = { (void *) table_id, \ (void *) subtable, \ @@ -1429,7 +1429,7 @@ acpi_graph_get_remote_endpoint(const struct fwnode_handle *fwnode, (void *) fn, \ (void *) data } -#define acpi_probe_device_table(t) ({ int __r = 0; __r;}) +#define acpi_probe_device_table(t) ({ int __r = 0; __r; }) #endif #ifdef CONFIG_ACPI_TABLE_UPGRADE
Fix the following errors reported by checkpatch: ERROR: "foo * bar" should be "foo *bar" ERROR: space required after that ';' (ctx:VxV) Signed-off-by: GuoHua Cheng <chenguohua@jari.cn> --- include/linux/acpi.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)