diff mbox

[v5,1/2] ACPI / APEI / BERT: Don't clear "block_status" in header

Message ID 7a8220935e24693a45137f3fea20b48c6ea47b46.1498065055.git.tony.luck@intel.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Tony Luck June 21, 2017, 5:20 p.m. UTC 
From: Tony Luck <tony.luck@intel.com>

Although the ACPI specification says this is a "one time polled" error
source, it makes no mention that the OS should stomp on fields in the
error status block to enforce this.

There are user mode BERT harvesting tools that dig into
/sys/firmware/acpi/tables/BERT which might like to see this summary value.

Drop the:
	estatus->block_status = 0;

Cc: Len Brown <lenb@kernel.org>
Cc: Huang Ying <ying.huang@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: Tomasz Nowicki <tomasz.nowicki@linaro.org>
Cc: Jonathan (Zhixiong) Zhang <zjzhang@codeaurora.org>
Cc: Tyler Baicar <tbaicar@codeaurora.org>
Cc: linux-acpi@vger.kernel.org
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
 drivers/acpi/apei/bert.c | 7 -------
 1 file changed, 7 deletions(-)
diff mbox

Patch

diff --git a/drivers/acpi/apei/bert.c b/drivers/acpi/apei/bert.c
index 12771fcf0417..9197555dc3c7 100644
--- a/drivers/acpi/apei/bert.c
+++ b/drivers/acpi/apei/bert.c
@@ -62,13 +62,6 @@  static void __init bert_print_all(struct acpi_bert_region *region,
 
 		cper_estatus_print(KERN_INFO HW_ERR, estatus);
 
-		/*
-		 * Because the boot error source is "one-time polled" type,
-		 * clear Block Status of current Generic Error Status Block,
-		 * once it's printed.
-		 */
-		estatus->block_status = 0;
-
 		estatus = (void *)estatus + estatus_len;
 		/* No more error records. */
 		if (!estatus->block_status)