From patchwork Wed Jun 21 17:20:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Luck X-Patchwork-Id: 9802373 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 15BEE60329 for ; Wed, 21 Jun 2017 17:21:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5ADB0285E3 for ; Wed, 21 Jun 2017 17:21:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4F8EE28636; Wed, 21 Jun 2017 17:21:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E61A8285E3 for ; Wed, 21 Jun 2017 17:21:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753072AbdFURVP (ORCPT ); Wed, 21 Jun 2017 13:21:15 -0400 Received: from mga06.intel.com ([134.134.136.31]:34723 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752948AbdFURVO (ORCPT ); Wed, 21 Jun 2017 13:21:14 -0400 Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP; 21 Jun 2017 10:21:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,369,1493708400"; d="scan'208";a="117650502" Received: from agluck-desk.sc.intel.com ([10.3.52.160]) by fmsmga006.fm.intel.com with ESMTP; 21 Jun 2017 10:21:06 -0700 From: "Luck, Tony" To: "Rafael J . Wysocki" Cc: Tony Luck , Len Brown , Huang Ying , Borislav Petkov , Tomasz Nowicki , Jonathan Zhang , Tyler Baicar , linux-acpi@vger.kernel.org Subject: [PATCH v5 1/2] ACPI / APEI / BERT: Don't clear "block_status" in header Date: Wed, 21 Jun 2017 10:20:41 -0700 Message-Id: <7a8220935e24693a45137f3fea20b48c6ea47b46.1498065055.git.tony.luck@intel.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: <20170619155854.gtcowx3cityb3gqt@pd.tnic> In-Reply-To: References: Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Tony Luck Although the ACPI specification says this is a "one time polled" error source, it makes no mention that the OS should stomp on fields in the error status block to enforce this. There are user mode BERT harvesting tools that dig into /sys/firmware/acpi/tables/BERT which might like to see this summary value. Drop the: estatus->block_status = 0; Cc: Len Brown Cc: Huang Ying Cc: Borislav Petkov Cc: Tomasz Nowicki Cc: Jonathan (Zhixiong) Zhang Cc: Tyler Baicar Cc: linux-acpi@vger.kernel.org Signed-off-by: Tony Luck --- drivers/acpi/apei/bert.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/acpi/apei/bert.c b/drivers/acpi/apei/bert.c index 12771fcf0417..9197555dc3c7 100644 --- a/drivers/acpi/apei/bert.c +++ b/drivers/acpi/apei/bert.c @@ -62,13 +62,6 @@ static void __init bert_print_all(struct acpi_bert_region *region, cper_estatus_print(KERN_INFO HW_ERR, estatus); - /* - * Because the boot error source is "one-time polled" type, - * clear Block Status of current Generic Error Status Block, - * once it's printed. - */ - estatus->block_status = 0; - estatus = (void *)estatus + estatus_len; /* No more error records. */ if (!estatus->block_status)