From patchwork Thu Jul 20 17:50:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Punit Agrawal X-Patchwork-Id: 9855529 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E0502600F5 for ; Thu, 20 Jul 2017 17:50:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D273228831 for ; Thu, 20 Jul 2017 17:50:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C412928836; Thu, 20 Jul 2017 17:50:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 24CB028847 for ; Thu, 20 Jul 2017 17:50:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754098AbdGTRux (ORCPT ); Thu, 20 Jul 2017 13:50:53 -0400 Received: from foss.arm.com ([217.140.101.70]:57064 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753881AbdGTRux (ORCPT ); Thu, 20 Jul 2017 13:50:53 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AB21F2B; Thu, 20 Jul 2017 10:50:52 -0700 (PDT) Received: from localhost (e105922-lin.cambridge.arm.com [10.1.207.56]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 769283F577; Thu, 20 Jul 2017 10:50:52 -0700 (PDT) From: Punit Agrawal To: Borislav Petkov Cc: , , , , "Rafael J. Wysocki" Subject: Re: [PATCH 3/4] ACPI / APEI: Drop uninformative messages during boot References: <20170720110402.15313-1-punit.agrawal@arm.com> <20170720110402.15313-4-punit.agrawal@arm.com> <20170720111732.GC18515@nazgul.tnic> <87d18vmgv6.fsf@e105922-lin.cambridge.arm.com> <20170720135446.GA20641@nazgul.tnic> Date: Thu, 20 Jul 2017 18:50:51 +0100 In-Reply-To: <20170720135446.GA20641@nazgul.tnic> (Borislav Petkov's message of "Thu, 20 Jul 2017 15:54:46 +0200") Message-ID: <87shhrknes.fsf@e105922-lin.cambridge.arm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Borislav Petkov writes: > On Thu, Jul 20, 2017 at 01:29:17PM +0100, Punit Agrawal wrote: >> I agree that where there is a genuine problem, relevant messages can >> help to diagnose the problem. But what's printed now doesn't fit the >> criteria. > > So make it fit the criteria. Change the code to not issue that message > when the platform doesn't have those tables. But keep it in the > remaining cases, when the tables are there. > > You can't be removing useful error messages just because your platform > doesn't have the tables. Fair point! I'll focus on quiescing the messages when the tables are not present. Inspired by your suggestion, I tried the following diff instead of $SUBJECT. This landed me a new message not seen before - [ 3.232940] GHES: Failed to enable APEI firmware first mode. On further digging, this message is printed on platforms not supporting the legacy WHEA stuff, when the APEI Support bit is not set in the platform wide _OSC capabilities. To make this message a bit less alarming, I can modify it to something like - "Firmware does not support APEI firmware first mode" Thoughts? --- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c index 456b488eb1df..f7784d9514e1 100644 --- a/drivers/acpi/apei/hest.c +++ b/drivers/acpi/apei/hest.c @@ -233,8 +233,9 @@ void __init acpi_hest_init(void) status = acpi_get_table(ACPI_SIG_HEST, 0, (struct acpi_table_header **)&hest_tab); if (status == AE_NOT_FOUND) - goto err; - else if (ACPI_FAILURE(status)) { + return; + + if (ACPI_FAILURE(status)) { const char *msg = acpi_format_exception(status); pr_err(HEST_PFX "Failed to get table, %s\n", msg); rc = -EINVAL;