| Message ID | 94F2FBAB4432B54E8AACC7DFDE6C92E37E4F34E9@ORSMSX110.amr.corp.intel.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Fri, Sep 09, 2016 at 06:45:23PM +0000, Moore, Robert wrote: > Well, I never thought I would write a couple lines of code like this, but here is a solution that should make everyone happy. > > diff --git a/source/components/tables/tbxfload.c b/source/components/tables/tbxfload.c > index 6a937b1..73ee1a2 100644 > --- a/source/components/tables/tbxfload.c > +++ b/source/components/tables/tbxfload.c > @@ -334,7 +334,7 @@ AcpiTbLoadNamespace ( > if (!TablesFailed) > { > ACPI_INFO (( > - "%u ACPI AML tables successfully acquired and loaded\n", > + "%u ACPI AML tables successfully acquired and loaded", > TablesLoaded)); > } > else > @@ -348,6 +348,11 @@ AcpiTbLoadNamespace ( > Status = AE_CTRL_TERMINATE; > } > > +#ifdef ACPI_APPLICATION > + ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n")); > +#endif > + > + > UnlockAndExit: > (void) AcpiUtReleaseMutex (ACPI_MTX_TABLES); > return_ACPI_STATUS (Status); Works for me. A lot of kernel code does stuff like that already: $ git grep -E "\(\"\\\n\"\)" | wc -l 1550
On Fri, 2016-09-09 at 21:06 +0200, Borislav Petkov wrote: > Works for me. A lot of kernel code does stuff like that already: > $ git grep -E "\(\"\\\n\"\)" | wc -l > 1550 <shrug> If you want. and fyi: Most of those are pr_cont uses for multiple printks to a single output line terminations. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Sep 09, 2016 at 12:15:56PM -0700, Joe Perches wrote: > Most of those are pr_cont uses for multiple printks to a single > output line terminations. Not really: $ git grep -E "\(\"\\\n\"\)" | grep -i cont | wc -l 185 Regardless, it doesn't really matter what those are.
Hi, > From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-owner@vger.kernel.org] On Behalf Of Moore, > Robert > David E <david.e.box@intel.com> > Subject: RE: [PATCH] ACPICA / Interpreter: Remove redundant newline > > Well, I never thought I would write a couple lines of code like this, but here is a solution that > should make everyone happy. > > diff --git a/source/components/tables/tbxfload.c b/source/components/tables/tbxfload.c > index 6a937b1..73ee1a2 100644 > --- a/source/components/tables/tbxfload.c > +++ b/source/components/tables/tbxfload.c > @@ -334,7 +334,7 @@ AcpiTbLoadNamespace ( > if (!TablesFailed) > { > ACPI_INFO (( > - "%u ACPI AML tables successfully acquired and loaded\n", > + "%u ACPI AML tables successfully acquired and loaded", > TablesLoaded)); > } > else > @@ -348,6 +348,11 @@ AcpiTbLoadNamespace ( > Status = AE_CTRL_TERMINATE; > } > > +#ifdef ACPI_APPLICATION > + ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n")); > +#endif > + > + IMO, these lines should be in ACPICA upstream, in a file under tools/acpiexec. Thanks Lv > UnlockAndExit: > (void) AcpiUtReleaseMutex (ACPI_MTX_TABLES); > return_ACPI_STATUS (Status); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: Zheng, Lv > Sent: Tuesday, September 13, 2016 8:11 PM > To: Moore, Robert <robert.moore@intel.com>; Moore, Robert > <robert.moore@intel.com>; Borislav Petkov <bp@alien8.de>; LKML <linux- > kernel@vger.kernel.org> > Cc: linux-acpi@vger.kernel.org; devel@acpica.org; Wysocki, Rafael J > <rafael.j.wysocki@intel.com>; Box, David E <david.e.box@intel.com> > Subject: RE: [PATCH] ACPICA / Interpreter: Remove redundant newline > > Hi, > > > From: linux-acpi-owner@vger.kernel.org > > [mailto:linux-acpi-owner@vger.kernel.org] On Behalf Of Moore, Robert > > David E <david.e.box@intel.com> > > Subject: RE: [PATCH] ACPICA / Interpreter: Remove redundant newline > > > > Well, I never thought I would write a couple lines of code like this, > > but here is a solution that should make everyone happy. > > > > diff --git a/source/components/tables/tbxfload.c > > b/source/components/tables/tbxfload.c > > index 6a937b1..73ee1a2 100644 > > --- a/source/components/tables/tbxfload.c > > +++ b/source/components/tables/tbxfload.c > > @@ -334,7 +334,7 @@ AcpiTbLoadNamespace ( > > if (!TablesFailed) > > { > > ACPI_INFO (( > > - "%u ACPI AML tables successfully acquired and loaded\n", > > + "%u ACPI AML tables successfully acquired and loaded", > > TablesLoaded)); > > } > > else > > @@ -348,6 +348,11 @@ AcpiTbLoadNamespace ( > > Status = AE_CTRL_TERMINATE; > > } > > > > +#ifdef ACPI_APPLICATION > > + ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n")); #endif > > + > > + > [Moore, Robert] I have no problem with this, I just want to get it over with. It is not a big deal, let's leave it at that and not make it a big issue. > IMO, these lines should be in ACPICA upstream, in a file under > tools/acpiexec. > > Thanks > Lv > > > UnlockAndExit: > > (void) AcpiUtReleaseMutex (ACPI_MTX_TABLES); > > return_ACPI_STATUS (Status); > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-acpi" > > in the body of a message to majordomo@vger.kernel.org More majordomo > > info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/source/components/tables/tbxfload.c b/source/components/tables/tbxfload.c index 6a937b1..73ee1a2 100644 --- a/source/components/tables/tbxfload.c +++ b/source/components/tables/tbxfload.c @@ -334,7 +334,7 @@ AcpiTbLoadNamespace ( if (!TablesFailed) { ACPI_INFO (( - "%u ACPI AML tables successfully acquired and loaded\n", + "%u ACPI AML tables successfully acquired and loaded", TablesLoaded)); } else @@ -348,6 +348,11 @@ AcpiTbLoadNamespace ( Status = AE_CTRL_TERMINATE; } +#ifdef ACPI_APPLICATION + ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n")); +#endif + + UnlockAndExit: (void) AcpiUtReleaseMutex (ACPI_MTX_TABLES); return_ACPI_STATUS (Status);