From patchwork Tue Dec 8 12:45:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: fu.wei@linaro.org X-Patchwork-Id: 7796771 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 7D46D9F39B for ; Tue, 8 Dec 2015 12:46:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 81A1220497 for ; Tue, 8 Dec 2015 12:46:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A03D2045A for ; Tue, 8 Dec 2015 12:46:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933376AbbLHMpv (ORCPT ); Tue, 8 Dec 2015 07:45:51 -0500 Received: from mail-oi0-f54.google.com ([209.85.218.54]:34978 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933375AbbLHMpu (ORCPT ); Tue, 8 Dec 2015 07:45:50 -0500 Received: by oige206 with SMTP id e206so8800641oig.2 for ; Tue, 08 Dec 2015 04:45:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=5x4PfffO5xZwkqQxQcUeILxyaCYZzQGXXUUup3ZS1U8=; b=Dy3sR55rbr7iz6xgY6oWUXWoJIIic+scm3q++PcBSgVmjY1NF7pDLxmY/nLk1Vzuo0 NxknIBlGQdYabCCm4ba/UsI0t8dwORZqK/Qn/Xej56Zn3j6zedfXXjipCMeONNi+3xdY xGjtJJYXXs3Je7jpDFiQTCvmfgOQniRbFOWJui6zQOtTk4zH+8yvpi7cvO8qo94e3pZr OOGXaxEEm1gSOFAj8SBCU20LLFkiQRMMnmjE7iPW+M8G/UXo8tphGGdUMbXCSp9sPoQS C9lB7v9RJ/06v3x94nTAB09SEPziS2aByvbLp0y0lD8mjAlF9CD5f18FXU1yE5P5sGXa p0jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=5x4PfffO5xZwkqQxQcUeILxyaCYZzQGXXUUup3ZS1U8=; b=QWNtkTSd+nNBFCD/Ya+Eb3c6eAJApYkdVbDe4yw0pAAU8WrMf30f1upm01YimWNRaT uX2cg9nZbKnEfj3NXOj4Gi2WqC9vTFn7W7BZlQN3BbTm8wP3udFIC8HSDvmbNfJ1W0Fo mfaQcimMyATBCzpc0srHAYq2QXBGkI+ya/r29Cf78GtYGE4P65aOgVgOyveN70t/JDRQ ziHnW299FesuwzK4K2dECaOgbyoBGl6T26Zn9OuvJVwe8xkKo0oDYMGzaputHSEHpX6e hNxesYHQM18Mzbd94tWV095acrhInj7oCjMWUsZz7cj7upv3ttT47btgSnFSU7OVm/hn XfYw== X-Gm-Message-State: ALoCoQmq5hZ1lHZLJlHxLGZYFWTfXnQJmHJs0Ja/DkeuGmR0jx5a9ZWNpqmy9dM4Ff2eSQVLSKY95xfHKbyVbazY49Zz7umNtXe3lWTpMaEzvbvb1cv2YD8= MIME-Version: 1.0 X-Received: by 10.202.1.199 with SMTP id 190mr2060128oib.69.1449578749197; Tue, 08 Dec 2015 04:45:49 -0800 (PST) Received: by 10.202.195.73 with HTTP; Tue, 8 Dec 2015 04:45:48 -0800 (PST) In-Reply-To: <5666BE62.7090409@linaro.org> References: <1449558183-12259-1-git-send-email-fu.wei@linaro.org> <5666BE62.7090409@linaro.org> Date: Tue, 8 Dec 2015 20:45:48 +0800 Message-ID: Subject: Re: [PATCH v4] acpi, apei, arm64: APEI initial support for aarch64. From: Fu Wei To: Hanjun Guo Cc: Tomasz Nowicki , Tomasz Nowicki , Rafael Wysocki , Len Brown , Catalin Marinas , Will Deacon , LKML , linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, Linaro ACPI Mailman List , G Gregory , Al Stone , Mark Rutland , Marc Zyngier , Lorenzo Pieralisi , rruigrok@codeaurora.org, "Abdulhamid, Harb" , Jon Masters , Mark Salter , Grant Likely , rrichter@cavium.com, jarkko.nikula@linux.intel.com, Jonathan Zhang Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Hanjun, On 8 December 2015 at 19:26, Hanjun Guo wrote: > Hi Fu Wei, > > > On 12/08/2015 03:03 PM, fu.wei@linaro.org wrote: >> >> From: Tomasz Nowicki >> >> This commit provides APEI arch-specific bits for aarch64 >> >> Meanwhile, add a new subfunction "hest_ia_init" for >> "acpi_disable_cmcff" which is used by IA-32 Architecture >> Corrected Machine Check (CMC). >> >> Signed-off-by: Tomasz Nowicki >> Tested-by: Jonathan (Zhixiong) Zhang >> Signed-off-by: Fu Wei >> --- >> Changelog: >> v4: Rebase to latest kernel version(4.4-rc4). >> Move arch_apei_flush_tlb_one into header file as a inline function >> Add a new subfunction "hest_ia_init" for "acpi_disable_cmcff". >> >> v3: https://lkml.org/lkml/2015/12/3/521 >> Remove "acpi_disable_cmcff" from arm64 code, >> and wrap it in hest.c by "#if defined(__i386__) || >> defined(__x86_64__)" >> >> v2: https://lkml.org/lkml/2015/12/2/432 >> Rebase to latest kernel version(4.4-rc3). >> Move arch_apei_flush_tlb_one() to arch/arm64/kernel/acpi.c >> >> v1: https://lkml.org/lkml/2015/8/14/199 >> Move arch_apei_flush_tlb_one() to arch/arm64/include/asm/apci.h. >> Delete arch/arm64/kernel/apei.c. >> Add "#ifdef CONFIG_ACPI_APEI" for "acpi_disable_cmcff". >> >> arch/arm64/Kconfig | 1 + >> arch/arm64/include/asm/acpi.h | 5 +++++ >> drivers/acpi/apei/hest.c | 19 ++++++++++++++++--- >> 3 files changed, 22 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >> index 871f217..58c8992 100644 >> --- a/arch/arm64/Kconfig >> +++ b/arch/arm64/Kconfig >> @@ -3,6 +3,7 @@ config ARM64 >> select ACPI_CCA_REQUIRED if ACPI >> select ACPI_GENERIC_GSI if ACPI >> select ACPI_REDUCED_HARDWARE_ONLY if ACPI >> + select HAVE_ACPI_APEI if ACPI >> select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE >> select ARCH_HAS_ELF_RANDOMIZE >> select ARCH_HAS_GCOV_PROFILE_ALL >> diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h >> index caafd63..31d3d9a 100644 >> --- a/arch/arm64/include/asm/acpi.h >> +++ b/arch/arm64/include/asm/acpi.h >> @@ -17,6 +17,7 @@ >> >> #include >> #include >> +#include >> >> /* Macros for consistency checks of the GICC subtable of MADT */ >> #define ACPI_MADT_GICC_LENGTH \ >> @@ -94,6 +95,10 @@ static inline const char *acpi_get_enable_method(int >> cpu) >> >> #ifdef CONFIG_ACPI_APEI >> pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr); > > > How bout adding a empty line here? np, done > > Except that, > > Acked-by: Hanjun Guo Great thanks for your review :-) > > Thanks > Hanjun diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h index 31d3d9a..da657a9 100644 --- a/arch/arm64/include/asm/acpi.h +++ b/arch/arm64/include/asm/acpi.h @@ -95,10 +95,10 @@ static inline const char *acpi_get_enable_method(int cpu) #ifdef CONFIG_ACPI_APEI pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr); + static inline void arch_apei_flush_tlb_one(unsigned long addr) { flush_tlb_kernel_range(addr, addr + PAGE_SIZE); } -#endif - +#endif /* CONFIG_ACPI_APEI */ #endif /*_ASM_ACPI_H*/