From patchwork Tue Nov 15 15:01:10 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 9429943 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C294760471 for ; Tue, 15 Nov 2016 15:01:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B2A5928697 for ; Tue, 15 Nov 2016 15:01:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A776C28951; Tue, 15 Nov 2016 15:01:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4007528697 for ; Tue, 15 Nov 2016 15:01:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752643AbcKOPBN (ORCPT ); Tue, 15 Nov 2016 10:01:13 -0500 Received: from mail-yw0-f178.google.com ([209.85.161.178]:33959 "EHLO mail-yw0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752601AbcKOPBN (ORCPT ); Tue, 15 Nov 2016 10:01:13 -0500 Received: by mail-yw0-f178.google.com with SMTP id t125so97416216ywc.1 for ; Tue, 15 Nov 2016 07:01:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=H/Ra7mpFGZRj0vOdG64Hz0Kbk3Tuu8N8zilQoLO/wdQ=; b=fm0wQaWjMtrfLZmoxh5eaG7qfBS7RSQhlnSjnlorij4BOFnE0VseVePHnVEqdzMGym kSbK3AIZ6mg+56WeHYeLLQbv+H0JjEEe7zQPmd7ZTIQdoKv0CEUUyJCF53SF+95W2XvR CB/Ivte8btYKhVhP6BHkcSJuHAOwtqrHg80rVSjfo2W7B2qjc9vzUTOJUXgwwczzGaDv S9jVlSRUP2Tvv1bZVwMxEqDGu8Sm8wgCJ5sVCRmdhIjX+T5/+t6W/csE/9B1vKHe2rol P5023LmsVRJnmnxca5XSPuOa0bTiNMGKwfbcLN0YsiVuMC1wGGsLvrFSrB2EMEfHhiQa RgCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=H/Ra7mpFGZRj0vOdG64Hz0Kbk3Tuu8N8zilQoLO/wdQ=; b=mlieP2TjDNwlF6/xnINB3OvWaLlrstQO2nq+yfvzlR31nnJesitftSAFsgUkO+psTu Wt5/UtGJRTp6ulfVNc+yXozxp4inOub78Q25txw/lcnlfe9Ns3RzuwljKvqPPQevQIr4 xK/euhKPOjy3f8LlvNp0Hvy1RmC5Sz822McQ9+Oc+cc8pbuR4/VtPcR9ChPQhSTQq5Sn Qt8mgX+GXNdjxe8xI0m+ey5Rq7QUU7/1gA4aRZLzVVaZ6e67pFofLB0jeCzEhXRLlcai gllmvYNgHo9vMG8s3i8/I+/eSdbxabQ3fSi1OYxxvvuAfGu4k4G6JefAUI8XMbsUcJuc UrJw== X-Gm-Message-State: ABUngvfmyInLPC9SGwrFJAfG59802BIY43d9vOY64S1hBcQ39HpYB/5gg6WhioooIjY0NLNAWZNef1cBd5UM7A== X-Received: by 10.157.2.72 with SMTP id 66mr8095400otb.118.1479222071033; Tue, 15 Nov 2016 07:01:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.50.69 with HTTP; Tue, 15 Nov 2016 07:01:10 -0800 (PST) In-Reply-To: References: <1AE640813FDE7649BE1B193DEA596E886A25E72C@SHSMSX101.ccr.corp.intel.com> <1AE640813FDE7649BE1B193DEA596E886A25EA6F@SHSMSX101.ccr.corp.intel.com> <1AE640813FDE7649BE1B193DEA596E886A25EBA3@SHSMSX101.ccr.corp.intel.com> <1AE640813FDE7649BE1B193DEA596E886A2618E2@SHSMSX101.ccr.corp.intel.com> From: Andy Shevchenko Date: Tue, 15 Nov 2016 17:01:10 +0200 Message-ID: Subject: Re: Fix in ACPICA tools broke cross compilation of tools/power/acpi To: "Zheng, Lv" Cc: "Rafael J. Wysocki" , "linux-acpi@vger.kernel.org" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Nov 15, 2016 at 4:23 PM, Andy Shevchenko wrote: > On Tue, Nov 15, 2016 at 12:27 PM, Andy Shevchenko > wrote: >> On Thu, Nov 3, 2016 at 5:04 PM, Zheng, Lv wrote: >>>> On Sun, Oct 30, 2016 at 9:04 AM, Zheng, Lv wrote: >> But reveals another, the output path is broken: >> >> output/host/usr/bin/i586-buildroot-linux-uclibc-gcc -c -D_LINUX -I >> $OUT/include -I $SRC/tools/power/acpi/../../../drivers/acpi/acpica >> -Wall -Wst >> rict-prototypes -Wdeclaration-after-statement -O1 -g -DDEBUG >> -DACPI_APPLICATION -DACPI_SINGLE_THREAD -DACPI_DEBUGG >> ER -I. -o $OUT/tools/acpidbg/acpidbg.o acpidbg.c >> Assembler messages: >> Fatal error: can't create $OUT/tools/acpidbg/acpidbg.o: No such file >> or directory >> ../../Makefile.rules:26: recipe for target '$OUT/tools/acpidbg/acpidbg.o' failed >> >> $OUT — path to O= >> $SRC — path to kernel sources > > From latest run > > output/host/usr/bin/i586-buildroot-linux-uclibc-gcc -c -D_LINUX -I > $OUT/include -I $SRC/tools/power/acpi/../../../drivers/acpi/acpica > -Wall -Wst > rict-prototypes -Wdeclaration-after-statement -O1 -g -DDEBUG > -DACPI_APPLICATION -DACPI_SINGLE_THREAD -DACPI_DEBUGG > ER -I. -o $OUT/tools/acpidbg/acpidbg.o acpidbg.c > > Of course it fails since proper folder name should be > 'tools/power/acpi/tools' instead of 'tools'. The below + several runs (need to serialize makefile, by default it races install vs. build) helped eventually. --- a/tools/power/acpi/Makefile.rules +++ b/tools/power/acpi/Makefile.rules @@ -8,9 +8,9 @@ # as published by the Free Software Foundation; version 2 # of the License. -objdir := $(OUTPUT)tools/$(TOOL)/ +objdir := $(OUTPUT)tools/power/acpi/tools/$(TOOL)/ toolobjs := $(addprefix $(objdir),$(TOOL_OBJS)) -$(OUTPUT)$(TOOL): $(KERNEL_INCLUDE) $(toolobjs) FORCE +$(objdir)$(TOOL): $(KERNEL_INCLUDE) $(toolobjs) FORCE $(ECHO) " LD " $(subst $(OUTPUT),,$@) $(QUIET) $(LD) $(CFLAGS) $(LDFLAGS) $(toolobjs) -L$(OUTPUT) -o $@ $(ECHO) " STRIP " $(subst $(OUTPUT),,$@) @@ -26,21 +26,21 @@ $(objdir)%.o: %.c $(ECHO) " CC " $(subst $(OUTPUT),,$@) $(QUIET) $(CC) -c $(CFLAGS) -o $@ $< -all: $(OUTPUT)$(TOOL) +all: $(objdir)$(TOOL) clean: $(ECHO) " RMOBJ " $(subst $(OUTPUT),,$(objdir)) $(QUIET) find $(objdir) \( -not -type d \)\ -and \( -name '*~' -o -name '*.[oas]' \)\ -type f -print | xargs rm -f $(ECHO) " RM " $(TOOL) - $(QUIET) rm -f $(OUTPUT)$(TOOL) + $(QUIET) rm -f $(objdir)$(TOOL) $(ECHO) " RMINC " $(subst $(OUTPUT),,$(KERNEL_INCLUDE)) $(QUIET) rm -rf $(KERNEL_INCLUDE) install-tools: $(ECHO) " INST " $(TOOL) $(QUIET) $(INSTALL) -d $(DESTDIR)$(sbindir) - $(QUIET) $(INSTALL_PROGRAM) $(OUTPUT)$(TOOL) $(DESTDIR)$(sbindir) + $(QUIET) $(INSTALL_PROGRAM) $(objdir)$(TOOL) $(DESTDIR)$(sbindir) uninstall-tools: $(ECHO) " UNINST " $(TOOL) $(QUIET) rm -f $(DESTDIR)$(sbindir)/$(TOOL)