From patchwork Fri Sep 25 16:01:43 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roland Dreier X-Patchwork-Id: 50133 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n8PG1qlE009589 for ; Fri, 25 Sep 2009 16:01:52 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753066AbZIYQBr (ORCPT ); Fri, 25 Sep 2009 12:01:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753385AbZIYQBr (ORCPT ); Fri, 25 Sep 2009 12:01:47 -0400 Received: from sj-iport-6.cisco.com ([171.71.176.117]:55375 "EHLO sj-iport-6.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752962AbZIYQBq (ORCPT ); Fri, 25 Sep 2009 12:01:46 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEAKeFvEqrR7PE/2dsb2JhbAC+R4hTAZAABYQegV0 X-IronPort-AV: E=Sophos;i="4.44,452,1249257600"; d="scan'208";a="396136828" Received: from sj-dkim-4.cisco.com ([171.71.179.196]) by sj-iport-6.cisco.com with ESMTP; 25 Sep 2009 16:01:44 +0000 Received: from sj-core-1.cisco.com (sj-core-1.cisco.com [171.71.177.237]) by sj-dkim-4.cisco.com (8.12.11/8.12.11) with ESMTP id n8PG1i0p017612; Fri, 25 Sep 2009 09:01:44 -0700 Received: from xbh-sjc-221.amer.cisco.com (xbh-sjc-221.cisco.com [128.107.191.63]) by sj-core-1.cisco.com (8.13.8/8.14.3) with ESMTP id n8PG1d7g006893; Fri, 25 Sep 2009 16:01:44 GMT Received: from xfe-sjc-211.amer.cisco.com ([171.70.151.174]) by xbh-sjc-221.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 25 Sep 2009 09:01:44 -0700 Received: from roland-conroe ([10.33.42.9]) by xfe-sjc-211.amer.cisco.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 25 Sep 2009 09:01:44 -0700 Received: by roland-conroe (Postfix, from userid 33217) id EBDF5E71D8; Fri, 25 Sep 2009 09:01:43 -0700 (PDT) From: Roland Dreier To: ykzhao Cc: Len Brown , "linux-kernel\@vger.kernel.org" , "linux-acpi\@vger.kernel.org" Subject: Re: [PATCH] ACPI: Kill overly verbose "power state" log messages References: <1253839597.3609.459.camel@localhost.localdomain> X-Message-Flag: Warning: May contain useful information Date: Fri, 25 Sep 2009 09:01:43 -0700 In-Reply-To: <1253839597.3609.459.camel@localhost.localdomain> (ykzhao's message of "Fri, 25 Sep 2009 08:46:37 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) MIME-Version: 1.0 X-OriginalArrivalTime: 25 Sep 2009 16:01:44.0319 (UTC) FILETIME=[7A66D0F0:01CA3DF9] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; l=2468; t=1253894504; x=1254758504; c=relaxed/simple; s=sjdkim4002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; i=rdreier@cisco.com; z=From:=20Roland=20Dreier=20 |Subject:=20Re=3A=20[PATCH]=20ACPI=3A=20Kill=20overly=20ver bose=20=22power=20state=22=20log=20messages |Sender:=20; bh=8d/fzTLvzoC0U3ewSV8e/Xkdf64+0zd9hTx0oQDcGBg=; b=ashlFprpc3/ZqbsnRoTDwjX/vu1S9Y4PRdiHlu+OB7zCxa9EZCCUkYVjag T3UGDovQCG8aAd/FHRZmmZ2Ti4oF4DrIFUwp83A1IWjP95c/jQjb3kzQ6Yp6 2h+px2WcbW; Authentication-Results: sj-dkim-4; header.From=rdreier@cisco.com; dkim=pass ( sig from cisco.com/sjdkim4002 verified; ); Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Len, I see I messed up editing my changelog message, see below... > > I was recently lucky enough to get a 64-CPU system. The processors > > actually have T-states, so my kernel log ends up with 64 lines like: > > > > ACPI: CPU0 (power states: C1[C1] C2[C3]) > > > > This is pretty useless clutter because this info is already available > > after boot from both /sys/devices/system/cpu/cpu*/cpuidle/state?/ as > > well as /proc/acpi/processor/CPU*/power. > > > > So just delete the code that prints the throttling states in > > processor_idle.c. > It seems that it is unnecessary to delete the C-state info. Sorry, this is a little too terse for me to know what you mean. Certainly it's not useful to have 64 copies of ACPI: CPU0 (power states: C1[C1] C2[C3]) in the kernel log on a big box, when all 64 processors are going to support the same C-states. However, I don't see what the use of having even one copy in the boot log is, when I can easily get that info at runtime from /proc/acpi/processor/CPU*/power. Anyway, Len, I see I copy-and-pasted too quickly from my T-state patch submission... if you want to apply, a version with better changelog would be: <--- snip ---> I was recently lucky enough to get a 64-CPU system, so my kernel log ends up with 64 lines like: ACPI: CPU0 (power states: C1[C1] C2[C3]) This is pretty useless clutter because this info is already available after boot from both /sys/devices/system/cpu/cpu*/cpuidle/state?/ as well as /proc/acpi/processor/CPU*/power. So just delete the code that prints the C-states in processor_idle.c. Signed-off-by: Roland Dreier --- drivers/acpi/processor_idle.c | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c index cc61a62..706eacf 100644 --- a/drivers/acpi/processor_idle.c +++ b/drivers/acpi/processor_idle.c @@ -1214,13 +1214,6 @@ int __cpuinit acpi_processor_power_init(struct acpi_processor *pr, acpi_processor_setup_cpuidle(pr); if (cpuidle_register_device(&pr->power.dev)) return -EIO; - - printk(KERN_INFO PREFIX "CPU%d (power states:", pr->id); - for (i = 1; i <= pr->power.count; i++) - if (pr->power.states[i].valid) - printk(" C%d[C%d]", i, - pr->power.states[i].type); - printk(")\n"); } #ifdef CONFIG_ACPI_PROCFS /* 'power' [R] */