| Message ID | adapr9gypqz.fsf@cisco.com (mailing list archive) |
|---|---|
| State | RFC, archived |
| Headers | show |
On Fri, 2009-09-25 at 05:52 +0800, Roland Dreier wrote: > I was recently lucky enough to get a 64-CPU system. The processors > actually have T-states, so my kernel log ends up with 64 lines like: > > ACPI: CPU0 (power states: C1[C1] C2[C3]) > > This is pretty useless clutter because this info is already available > after boot from both /sys/devices/system/cpu/cpu*/cpuidle/state?/ as > well as /proc/acpi/processor/CPU*/power. > > So just delete the code that prints the throttling states in > processor_idle.c. It seems that it is unnecessary to delete the C-state info. Thanks. > > Signed-off-by: Roland Dreier <rolandd@cisco.com> > --- > drivers/acpi/processor_idle.c | 7 ------- > 1 files changed, 0 insertions(+), 7 deletions(-) > > diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c > index cc61a62..706eacf 100644 > --- a/drivers/acpi/processor_idle.c > +++ b/drivers/acpi/processor_idle.c > @@ -1214,13 +1214,6 @@ int __cpuinit acpi_processor_power_init(struct acpi_processor *pr, > acpi_processor_setup_cpuidle(pr); > if (cpuidle_register_device(&pr->power.dev)) > return -EIO; > - > - printk(KERN_INFO PREFIX "CPU%d (power states:", pr->id); > - for (i = 1; i <= pr->power.count; i++) > - if (pr->power.states[i].valid) > - printk(" C%d[C%d]", i, > - pr->power.states[i].type); > - printk(")\n"); > } > #ifdef CONFIG_ACPI_PROCFS > /* 'power' [R] */ > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c index cc61a62..706eacf 100644 --- a/drivers/acpi/processor_idle.c +++ b/drivers/acpi/processor_idle.c @@ -1214,13 +1214,6 @@ int __cpuinit acpi_processor_power_init(struct acpi_processor *pr, acpi_processor_setup_cpuidle(pr); if (cpuidle_register_device(&pr->power.dev)) return -EIO; - - printk(KERN_INFO PREFIX "CPU%d (power states:", pr->id); - for (i = 1; i <= pr->power.count; i++) - if (pr->power.states[i].valid) - printk(" C%d[C%d]", i, - pr->power.states[i].type); - printk(")\n"); } #ifdef CONFIG_ACPI_PROCFS /* 'power' [R] */
I was recently lucky enough to get a 64-CPU system. The processors actually have T-states, so my kernel log ends up with 64 lines like: ACPI: CPU0 (power states: C1[C1] C2[C3]) This is pretty useless clutter because this info is already available after boot from both /sys/devices/system/cpu/cpu*/cpuidle/state?/ as well as /proc/acpi/processor/CPU*/power. So just delete the code that prints the throttling states in processor_idle.c. Signed-off-by: Roland Dreier <rolandd@cisco.com> --- drivers/acpi/processor_idle.c | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html