From patchwork Fri Feb 6 18:57:47 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Len Brown X-Patchwork-Id: 5931 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n16IvuON003058 for ; Fri, 6 Feb 2009 18:57:57 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753620AbZBFS5z (ORCPT ); Fri, 6 Feb 2009 13:57:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752664AbZBFS5z (ORCPT ); Fri, 6 Feb 2009 13:57:55 -0500 Received: from vms173009pub.verizon.net ([206.46.173.9]:57672 "EHLO vms173009pub.verizon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751641AbZBFS5y (ORCPT ); Fri, 6 Feb 2009 13:57:54 -0500 Received: from localhost.localdomain ([96.237.168.40]) by vms173009.mailsrvcs.net (Sun Java(tm) System Messaging Server 6.3-7.04 (built Sep 26 2008; 32bit)) with ESMTPA id <0KEN0009OR476OG0@vms173009.mailsrvcs.net>; Fri, 06 Feb 2009 12:52:56 -0600 (CST) Received: from localhost.localdomain (d975xbx2 [127.0.0.1]) by localhost.localdomain (8.14.2/8.14.2) with ESMTP id n16Ivn2H012596; Fri, 06 Feb 2009 13:57:50 -0500 Received: from localhost (lenb@localhost) by localhost.localdomain (8.14.2/8.14.2/Submit) with ESMTP id n16IvlQG012591; Fri, 06 Feb 2009 13:57:48 -0500 X-Authentication-warning: localhost.localdomain: lenb owned process doing -bs Date: Fri, 06 Feb 2009 13:57:47 -0500 (EST) From: Len Brown X-X-Sender: lenb@localhost.localdomain To: Ben Greear Cc: linux-kernel , NetDev , linux-acpi@vger.kernel.org Subject: Re: Regression on VIA C3 motherboard, commit: 66f2173e2 In-reply-to: <498A93E5.2080509@candelatech.com> Message-id: References: <498A93E5.2080509@candelatech.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-version: 1.0 Content-type: TEXT/PLAIN; charset=US-ASCII Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Thanks for the bisect, Ben. Please test the patch below. I assume even without the patch, booting with "acpi=off" on your BIOS-ACPI-disabled box works? (if no, this patch will not solve all your problems, for you have additional trouble elsewhere) I am curious why you're running a CONFIG_ACPI=y kernel for a box with ACPI disabled. (though yes, it is supposed to work) I'm even more curious what bad things happen when you enable ACPI in the BIOS -- can you let me know and we can try to fix them so the machine can run as shipped? thanks, -Len Brown Intel Open Source Technology Center --- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c index 775c97a..a885295 100644 --- a/drivers/acpi/tables.c +++ b/drivers/acpi/tables.c @@ -293,7 +293,12 @@ static void __init check_multiple_madt(void) int __init acpi_table_init(void) { - acpi_initialize_tables(initial_tables, ACPI_MAX_TABLES, 0); + acpi_status status; + + status = acpi_initialize_tables(initial_tables, ACPI_MAX_TABLES, 0); + if (ACPI_FAILURE(status)) + return 1; + check_multiple_madt(); return 0; }