From patchwork Wed Apr 22 23:53:11 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Len Brown X-Patchwork-Id: 19458 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n3MNrMSv005528 for ; Wed, 22 Apr 2009 23:53:22 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751174AbZDVXxU (ORCPT ); Wed, 22 Apr 2009 19:53:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751276AbZDVXxU (ORCPT ); Wed, 22 Apr 2009 19:53:20 -0400 Received: from vms173007pub.verizon.net ([206.46.173.7]:20912 "EHLO vms173007pub.verizon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751043AbZDVXxT (ORCPT ); Wed, 22 Apr 2009 19:53:19 -0400 Received: from localhost.localdomain ([96.237.168.40]) by vms173007.mailsrvcs.net (Sun Java(tm) System Messaging Server 6.3-7.04 (built Sep 26 2008; 32bit)) with ESMTPA id <0KIJ006EG10QNVOQ@vms173007.mailsrvcs.net>; Wed, 22 Apr 2009 18:53:16 -0500 (CDT) Received: from localhost.localdomain (d975xbx2 [127.0.0.1]) by localhost.localdomain (8.14.2/8.14.2) with ESMTP id n3MNrDoc029609; Wed, 22 Apr 2009 19:53:13 -0400 Received: from localhost (lenb@localhost) by localhost.localdomain (8.14.2/8.14.2/Submit) with ESMTP id n3MNrB0h029605; Wed, 22 Apr 2009 19:53:12 -0400 X-Authentication-warning: localhost.localdomain: lenb owned process doing -bs Date: Wed, 22 Apr 2009 19:53:11 -0400 (EDT) From: Len Brown X-X-Sender: lenb@localhost.localdomain To: Oliver Neukum Cc: Alan Stern , Andrew Morton , Arjan van de Ven , rui.zhang@intel.com, shaohua.li@intel.com, yakui.zhao@intel.com, bugzilla-daemon@bugzilla.kernel.org, bugme-daemon@bugzilla.kernel.org, linux-usb@vger.kernel.org, linux-acpi@vger.kernel.org, daniel.smoczyk@gmail.com, imrehg@gmail.com Subject: [RFC PATCH] ACPI: delete obsolete "bus master activity" proc field In-reply-to: Message-id: References: <200904221936.38942.oliver@neukum.org> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-version: 1.0 Content-type: TEXT/PLAIN; charset=US-ASCII Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org From: Len Brown The legacy ACPI idle handler was deleted from 2.6.29 leaving the CPU_IDLE idle handler, which never sets bm_activity. So delete this unused field -- it is mis-leading to have it print all zeros when, in fact, there may bus master activity occurring -- just that we don't track its history any more. This patch could break something that parses /proc/acpi/processor/*/power, since it deletes this line from that file: bus master activity: 00000000 Signed-off-by: Len Brown --- drivers/acpi/processor_idle.c | 4 +--- include/acpi/processor.h | 1 - 2 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c index 9d1f01e..eed3b45 100644 --- a/drivers/acpi/processor_idle.c +++ b/drivers/acpi/processor_idle.c @@ -662,11 +662,9 @@ static int acpi_processor_power_seq_show(struct seq_file *seq, void *offset) seq_printf(seq, "active state: C%zd\n" "max_cstate: C%d\n" - "bus master activity: %08x\n" "maximum allowed latency: %d usec\n", pr->power.state ? pr->power.state - pr->power.states : 0, - max_cstate, (unsigned)pr->power.bm_activity, - pm_qos_requirement(PM_QOS_CPU_DMA_LATENCY)); + max_cstate, pm_qos_requirement(PM_QOS_CPU_DMA_LATENCY)); seq_puts(seq, "states:\n"); diff --git a/include/acpi/processor.h b/include/acpi/processor.h index b09c4fd..4927c06 100644 --- a/include/acpi/processor.h +++ b/include/acpi/processor.h @@ -84,7 +84,6 @@ struct acpi_processor_power { struct acpi_processor_cx *state; unsigned long bm_check_timestamp; u32 default_state; - u32 bm_activity; int count; struct acpi_processor_cx states[ACPI_PROCESSOR_MAX_POWER]; int timer_broadcast_on_state;