From patchwork Fri Apr 24 15:49:27 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Len Brown X-Patchwork-Id: 19821 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n3OFngtZ014014 for ; Fri, 24 Apr 2009 15:49:42 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751722AbZDXPtl (ORCPT ); Fri, 24 Apr 2009 11:49:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752787AbZDXPtk (ORCPT ); Fri, 24 Apr 2009 11:49:40 -0400 Received: from vms173001pub.verizon.net ([206.46.173.1]:65139 "EHLO vms173001pub.verizon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751722AbZDXPtk (ORCPT ); Fri, 24 Apr 2009 11:49:40 -0400 Received: from localhost.localdomain ([96.237.168.40]) by vms173001.mailsrvcs.net (Sun Java(tm) System Messaging Server 6.3-7.04 (built Sep 26 2008; 32bit)) with ESMTPA id <0KIM009LM3YI7KUH@vms173001.mailsrvcs.net> for linux-acpi@vger.kernel.org; Fri, 24 Apr 2009 10:49:31 -0500 (CDT) Received: from localhost.localdomain (d975xbx2 [127.0.0.1]) by localhost.localdomain (8.14.2/8.14.2) with ESMTP id n3OFnTkB017984; Fri, 24 Apr 2009 11:49:29 -0400 Received: from localhost (lenb@localhost) by localhost.localdomain (8.14.2/8.14.2/Submit) with ESMTP id n3OFnREq017657; Fri, 24 Apr 2009 11:49:28 -0400 X-Authentication-warning: localhost.localdomain: lenb owned process doing -bs Date: Fri, 24 Apr 2009 11:49:27 -0400 (EDT) From: Len Brown X-X-Sender: lenb@localhost.localdomain To: yakui_zhao Cc: Norbert Preining , Jesse Barnes , Eric Anholt , "Zhang, Rui" , Keith Packard , "linux-acpi@vger.kernel.org" Subject: Re: 2.6.30-rc3 video/i915 build error In-reply-to: <1240544791.3651.82.camel@localhost.localdomain> Message-id: References: <20090423164642.GF495@gamma.logic.tuwien.ac.at> <1240535458.3651.63.camel@localhost.localdomain> <1240544791.3651.82.camel@localhost.localdomain> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-version: 1.0 Content-type: TEXT/PLAIN; charset=US-ASCII Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org From: Len Brown Subject: [PATCH] ACPI, i915: build fix drivers/built-in.o: In function `intel_opregion_init': (.text+0x9d540): undefined reference to `acpi_video_register' Signed-off-by: Len Brown --- drivers/gpu/drm/Kconfig | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 3a22eb9..f33d252 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -83,6 +83,12 @@ config DRM_I915 config DRM_I915_KMS bool "Enable modesetting on intel by default" depends on DRM_I915 + # i915 KMS depends on ACPI_VIDEO when ACPI is enabled + # but for select to work, need to select ACPI_VIDEO's dependencies, ick + select VIDEO_OUTPUT_CONTROL if ACPI + select BACKLIGHT_CLASS_DEVICE if ACPI + select INPUT if ACPI + select ACPI_VIDEO if ACPI help Choose this option if you want kernel modesetting enabled by default, and you have a new enough userspace to support this. Running old