From patchwork Thu Jul 24 23:20:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugh Dickins X-Patchwork-Id: 4620541 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 853C9C0514 for ; Thu, 24 Jul 2014 23:22:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EECF0201CD for ; Thu, 24 Jul 2014 23:22:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C58920179 for ; Thu, 24 Jul 2014 23:22:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935021AbaGXXWP (ORCPT ); Thu, 24 Jul 2014 19:22:15 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:64021 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934839AbaGXXWO (ORCPT ); Thu, 24 Jul 2014 19:22:14 -0400 Received: by mail-pd0-f182.google.com with SMTP id fp1so4573180pdb.27 for ; Thu, 24 Jul 2014 16:22:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version:content-type; bh=z5kTkAT8rJITKF4BKea+8mZZQSpjbkOmiXMJ+0h9SGk=; b=NWNSciiLsZ46F54pbC4OWH47O6B6+K0qm0rQ9NOrpezDKafMwegXLUaaCVDRmIstJc cMHT2ZLpmEXnLZ3uYXwheTR8HrtH1Tf0CXxEyWj3PvBBr6UxWUl8yI6WaYi98ReoQz3E Ttp2iux64Qm52gDwrKfqNHmEknkyBdkl5alXazA5Wq0KBWJCTnSyE/tTBCRoYTww2Pkx 6G97yS9PJG8nU40sdEnGK91wMYTiZRdC7ARSIuFlFk0WhPY9ux1QR3/rNR1b4eZtb+nK LqRuTXFb1VvrrO/V28ZrHi+Rjqmwp1MQ/urPAVP59zwXV9wARk5AYX8obarbW7yjaIDh O12Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; bh=z5kTkAT8rJITKF4BKea+8mZZQSpjbkOmiXMJ+0h9SGk=; b=PBAjeiYSdzVLBvmcV2ptW3d/LDBdLvDUCRfCuF5kNPLYu3SqbA3XUsVrNcKpj/BIRp 8mRsiJhR7hJwh+vdwhhjwEdTPCGH128eh2CFvhCl5mzYN3lYOgdg9JDtPDyFTTItuPwF 1y115P815hxVmvkx5w7GuTIDQv9Z8iPBwr2tE5iC5HDy7TMNu2rRIy+4CNuMZLNEdTQf Pz2Nq2DWCx/9aDljcO2d+Mgvg1qpoj93MCssYdTvPPMM6qPAMerf2h7YghT0l0yuWzk2 nc+H33kC54NDRPNV9MA98+5i/ndvJXePFRRt2vNRnjxlExtk715xiiwFBYl24yHVpT3s lShg== X-Gm-Message-State: ALoCoQmaLu+Owzt2v596SjJPQ2App7l+M+LI7eNhsb+GbBW2qBgSdOs7q1kUkydsFJDHzJiXMJUr X-Received: by 10.69.17.230 with SMTP id gh6mr14707423pbd.0.1406244134048; Thu, 24 Jul 2014 16:22:14 -0700 (PDT) Received: from [100.110.60.10] ([216.239.55.194]) by mx.google.com with ESMTPSA id fm12sm9005588pdb.46.2014.07.24.16.22.12 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 24 Jul 2014 16:22:13 -0700 (PDT) Date: Thu, 24 Jul 2014 16:20:25 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Martin Kepplinger cc: Daniel Vetter , Zhang Rui , "rjw@rjwysocki.net" , "lenb@kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-media@vger.kernel.org Subject: Re: [BUG] rc1 rc2 rc3 not bootable - black screen after kernel loading In-Reply-To: <53D131E7.2090304@posteo.de> Message-ID: References: <53A6E72A.9090000@posteo.de> <744357E9AAD1214791ACBA4B0B90926301379B97@SHSMSX101.ccr.corp.intel.com> <53A81BF7.3030207@posteo.de> <1403529246.4686.6.camel@rzhang1-toshiba> <53A83DC7.1010606@posteo.de> <1403882067.16305.124.camel@rzhang1-toshiba> <53ADB359.4010401@posteo.de> <53ADCB24.9030206@posteo.de> <53ADECDA.60600@posteo.de> <53B11749.3020902@posteo.de> <1404116299.8366.0.camel@rzhang1-toshiba> <1404116444.8366.1.camel@rzhang1-toshiba> <53B12723.4080902@posteo.de> <53B13E4B.2080603@posteo.de> <53D131E7.2090304@posteo.de> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, 24 Jul 2014, Martin Kepplinger wrote: > Am 2014-06-30 12:39, schrieb Martin Kepplinger: > > back to aaeb2554337217dfa4eac2fcc90da7be540b9a73 as the first bad > > commit. why is this not revertable exactly? how can I show a complete > > list of commits this merge introduces? > > > > It seems that _nobody_ is running a simple 32 bit i915 (acer) laptop. > rc6 is still unusable. Black screen directly after kernel-loading. no > change since rc1. > > Seems like I won't be able to use 3.16. I'm happy to test patches and am > happy for any advice what to do, when time permits. Martin, I know nothing about aaeb25543372 and why it should be relevant, but if you're having rc1..rc6 32-bit i915 black screens, please try this patch that Daniel Vetter put in his fixes queue on Monday, which I'm hoping will reach Linus for -rc7. Hugh [PATCH] drm/i915: fix freeze with blank screen booting highmem x86_64 boots and displays fine, but booting x86_32 with CONFIG_HIGHMEM has frozen with a blank screen throughout 3.16-rc on this ThinkPad T420s, with i915 generation 6 graphics. Fix 9d0a6fa6c5e6 ("drm/i915: add render state initialization"): kunmap() takes struct page * argument, not virtual address. Which the compiler kindly points out, if you use the appropriate u32 *batch, instead of silencing it with a void *. Why did bisection lead decisively to nearby 229b0489aa75 ("drm/i915: add null render states for gen6, gen7 and gen8")? Because the u32 deposited at that virtual address by the previous stub failed the PageHighMem test, and so caused no harm. Signed-off-by: Hugh Dickins --- drivers/gpu/drm/i915/i915_gem_render_state.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- 3.16-rc/drivers/gpu/drm/i915/i915_gem_render_state.c 2014-06-16 00:28:52.384076465 -0700 +++ linux/drivers/gpu/drm/i915/i915_gem_render_state.c 2014-07-21 20:10:03.824481521 -0700 @@ -31,7 +31,7 @@ struct i915_render_state { struct drm_i915_gem_object *obj; unsigned long ggtt_offset; - void *batch; + u32 *batch; u32 size; u32 len; }; @@ -80,7 +80,7 @@ free: static void render_state_free(struct i915_render_state *so) { - kunmap(so->batch); + kunmap(kmap_to_page(so->batch)); i915_gem_object_ggtt_unpin(so->obj); drm_gem_object_unreference(&so->obj->base); kfree(so);