From patchwork Fri May 12 21:42:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Luck X-Patchwork-Id: 9724885 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 78FD1601E7 for ; Fri, 12 May 2017 21:43:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 699C228892 for ; Fri, 12 May 2017 21:43:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5D36628896; Fri, 12 May 2017 21:43:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 44FF328892 for ; Fri, 12 May 2017 21:43:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756913AbdELVnV (ORCPT ); Fri, 12 May 2017 17:43:21 -0400 Received: from mga09.intel.com ([134.134.136.24]:65355 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758767AbdELVnU (ORCPT ); Fri, 12 May 2017 17:43:20 -0400 Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 May 2017 14:43:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,332,1491289200"; d="scan'208";a="86919756" Received: from agluck-desk.sc.intel.com ([10.3.52.160]) by orsmga004.jf.intel.com with ESMTP; 12 May 2017 14:43:19 -0700 From: "Luck, Tony" To: "Rafael J. Wysocki" Cc: Tony Luck , Len Brown , Huang Ying , Borislav Petkov , Tomasz Nowicki , Jonathan Zhang , Tyler Baicar , linux-acpi@vger.kernel.org Subject: [PATCH v2 2/2] ACPI / APEI: No remaining users of struct acpi_bert_region Date: Fri, 12 May 2017 14:42:12 -0700 Message-Id: X-Mailer: git-send-email 2.11.0 In-Reply-To: References: <20170512120118.zwhgtcbf4u4zshbn@pd.tnic> In-Reply-To: References: Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Tony Luck Version 6.1 of the ACPI specification. Section 18.3.1 "Boot Error Source" clarified that the format of the Boot Error Region is a "Generic Error Status Block". So we don't need separate (but identical) "struct acpi_bert_region" and "struct acpi_hest_generic_status". Code using acpi_bert_region has been changed to use acpi_hest_generic_status instead. So we can delete the definition now. Cc: Len Brown Cc: Huang Ying Cc: Borislav Petkov Cc: Tomasz Nowicki Cc: Jonathan (Zhixiong) Zhang Cc: Tyler Baicar Cc: linux-acpi@vger.kernel.org Reviewed-by: Borislav Petkov Signed-off-by: Tony Luck --- include/acpi/actbl1.h | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h index b4ce55c008b0..b44663a87bd1 100644 --- a/include/acpi/actbl1.h +++ b/include/acpi/actbl1.h @@ -126,17 +126,11 @@ struct acpi_whea_header { struct acpi_table_bert { struct acpi_table_header header; /* Common ACPI table header */ u32 region_length; /* Length of the boot error region */ - u64 address; /* Physical address of the error region */ -}; - -/* Boot Error Region (not a subtable, pointed to by Address field above) */ - -struct acpi_bert_region { - u32 block_status; /* Type of error information */ - u32 raw_data_offset; /* Offset to raw error data */ - u32 raw_data_length; /* Length of raw error data */ - u32 data_length; /* Length of generic error data */ - u32 error_severity; /* Severity code */ + u64 address; /* + * Physical address of the error region + * which is a Generic Error Status Block + * (struct acpi_hest_generic_status) + */ }; /* Values for block_status flags above */