From patchwork Mon Mar 24 07:13:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 14026871 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E74F7282F0; Mon, 24 Mar 2025 07:13:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742800393; cv=none; b=YKMOlvdtKvvH6k3KkSZhBqCY9jijaCP5GL9UiC9v4YJqzVfftbuPgk70mMRcfn58t7+RPb87Ad1u3939gWL0XEdPYNlbJ4L9ZqIennIB3R9u4SMjS7uvSKBwbHzOhFyfjd106qCQ60p+6IgTeLlrEL9+CoRq8prCC7APUmx5Vu4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742800393; c=relaxed/simple; bh=D6nk1nH5I6XlGeSiHhyIRhoTfx2sFbu0BOWX0NE/a6U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PQC196Aw6uajsLzERMygC8ggrw7KbC6ebCwzS7A0mZ8k9nO0lSAbH4iMXbwyCcejo95xu69PENVX0gxzvg4jHqzYIVa64HeMEaDVEUl5aRv8c/7mPwFMETBn8ykH4ofri8JYE6m/RPoBjTBEYZHN3GNXtsze7laN3mKhNh9IILk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mp2jDWiO; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mp2jDWiO" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-548430564d9so4188312e87.2; Mon, 24 Mar 2025 00:13:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742800390; x=1743405190; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2ozanmv/QqYBgGPCgM2crebgxBT9NUAtaVOJ4kP5Qos=; b=mp2jDWiO5Tc/aNG3TTgc5aGWPTC+TS2rOeJDwhCbdKMe+MUlZqh9oYpdwHmTeafTOT 4XQGEVRzSG7L/NplehSj59cGwzuF8Lzt3MmHB9boAGG4FQT53maHJO2WGIj4cajv31ML zKPOdWQ2WUIDOXB1S5CovXOWGaX0VKiCo+1N2/N+W013x/wkdPA/S446RldSsnkyqR6m augLll/2e+JJ4G+9vFQLbnkuuv2Y+IyjlOEenFLc5SI3A0XzTj49g2WOV7CNSXmfN9sK kCAakNoTGU7j16uRrDLvoFydMfABMx9VLYSoTHMjWUThVFol1IHY0gaQzPdxFlODq7Dg M5pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742800390; x=1743405190; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2ozanmv/QqYBgGPCgM2crebgxBT9NUAtaVOJ4kP5Qos=; b=SWvujfLJIEpZkBMiL2TdIz9oyLv11cyVTJSXfyAQz2LstR9AnDf/8MxkFYYS6qhsiE XjGppRzC/Ui/Atel2D8OQXooDZ4+T878mueI2N1zOp5mkd3dl9Yo3fHImB7SERp1gNCa hZXhtMuZs4o173TgBRnxQ6vbJDGHDcn5GzRKQizcGtscGBr+ZkyjG238nnsYTRiadAyD v+e3MwoahP0CvsQ8h//WWNVB+Eb4Cd0vCQHEloCmBQ7dDis9I7nbExyankkqXKR4sLE/ HkOMroxWUkQQt+nBW6HTj8qWxGiRFeWSSrEhZj01NFB5MRmmHBL76dkaFlkvZI9sRBB0 0rDA== X-Forwarded-Encrypted: i=1; AJvYcCUpXp6oASveQyoptbotoTDi+fZi/r0AP7GiZpIfFT3NHfj13ZryXlr38+ljnB2MBnROKNJO7lfhoEOh@vger.kernel.org, AJvYcCVPvxg5PcmqF0jKRJHpyE2DtE4v1cGbV9uzV6rcp8Rmb+pMlIhECkRCaVnzJ68NnE0/eg5JA/vd1tg+tpIzyaEF2Rc=@vger.kernel.org, AJvYcCWOavLwwdbTFggtX40NTvVPNKUmSu47O5jOp2iO5nDaccJ/IzS74zqlr8hAMs8qatXvsbrUkbhjnGHv@vger.kernel.org, AJvYcCWzVnQ4anNteuBhwuexRdGFQ/M16zEAtSi4UWohSMZjtTsuJJpNyz4hW9B4C8pV9pc6KOtLGGVqvNmhJc25@vger.kernel.org, AJvYcCX/yospZmbDHFYOueav8p58ljiMQ9fBrCcfzP6D2IgOtSVqkMcVTZA5ZKBnsnlWSp3cbT8vq6VD/m8ztQ==@vger.kernel.org X-Gm-Message-State: AOJu0Yzu/XJ6fUzZIU/BUsfOlMoUcZWZ1jsBWQDYFHuDIc+2CVfbGda1 tZxMR+L/75k2YOe0yCTrxFNB6H/MwI7MWwjSKaCBAFu5Df9ge6wS X-Gm-Gg: ASbGncvDc/VpaPAoR78t+PgkvJ7nng63ogx/bD6QGBiKL1LZSO3etV2tEJFPWS8JEYP FpireSddUaVmguoJHMmARMN52qh5MVVXacELxj0JlxFPInMrcjvtmlfMgkTjqbV6oJibbmvBDSW BU/CissEKlYBYdbUNpBp6pPHERP52i0smIEHY9HUGaFeu0eIBoj83jCQK1asyJ3z74ESm01cLi8 1iFnfmx8Qi5Nq6nHSbAst0eA2UNGuxjiaxJ/+Ukuzm2MzJrOe6kNN7udA4y0nGlBlD+e96buGIa yYJrJ7mUvm/Q0Ca9ZrckrEZfHmqB1va2r+fK8gJnhTyIJqsY3tk= X-Google-Smtp-Source: AGHT+IEyGZx7uvcqc+LiYB4BDlalqv4N/7ztabAEMx6CrAGNkPjAjUIgTEKN8x5EkF3GXgji3nzWBA== X-Received: by 2002:a05:6512:6c4:b0:549:8e5e:9d8e with SMTP id 2adb3069b0e04-54ad63fc0e6mr4283316e87.0.1742800389666; Mon, 24 Mar 2025 00:13:09 -0700 (PDT) Received: from mva-rohm ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54ad6508252sm1046478e87.179.2025.03.24.00.13.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Mar 2025 00:13:08 -0700 (PDT) Date: Mon, 24 Mar 2025 09:13:03 +0200 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Jonathan Cameron , Lars-Peter Clausen , Andy Shevchenko , Matti Vaittinen , Lad Prabhakar , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Nuno Sa , David Lechner , Javier Carrasco , Guillaume Stols , Dumitru Ceclan , Trevor Gamblin , Matteo Martelli , Alisa-Dariana Roman , Ramona Alexandra Nechita , AngeloGioacchino Del Regno , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH v10 3/8] iio: adc: add helpers for parsing ADC nodes Message-ID: References: Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: There are ADC ICs which may have some of the AIN pins usable for other functions. These ICs may have some of the AIN pins wired so that they should not be used for ADC. (Preferred?) way for marking pins which can be used as ADC inputs is to add corresponding channels@N nodes in the device tree as described in the ADC binding yaml. Add couple of helper functions which can be used to retrieve the channel information from the device node. Signed-off-by: Matti Vaittinen Reviewed-by: Andy Shevchenko Reviewed-by: Marcelo Schmitt --- Revision history: v8 => - No changes v7 => v8: devm_iio_adc_device_alloc_chaninfo_se(): - Treat all negative values for the max ID as 'don't care' - Return -ENOENT instead of '0' if no channels were found. v5 => v6: - Adapt to changed fwnode helper names - Fix spelling v4 => v5: - Inline iio_adc_device_num_channels() - Fix Indenting function parameters - Combine the max channel ID checks. v3 => v4: - Drop diff-channel support - Drop iio_adc_device_channels_by_property() - Add IIO_DEVICE namespace - Move industrialio-adc.o to top of the Makefile - Some styling as suggested by Andy - Re-consider included headers v2 => v3: Mostly based on review comments by Jonathan - Support differential and single-ended channels - Rename iio_adc_device_get_channels() as iio_adc_device_channels_by_property() - Improve spelling - Drop support for cases where DT comes from parent device's node - Decrease loop indent by reverting node name check conditions - Don't set 'chan->indexed' by number of channels to keep the interface consistent no matter how many channels are connected. - Fix ID range check and related comment RFC v1 => v2: - New patch --- drivers/iio/adc/Kconfig | 3 ++ drivers/iio/adc/Makefile | 2 + drivers/iio/adc/industrialio-adc.c | 82 ++++++++++++++++++++++++++++++ include/linux/iio/adc-helpers.h | 27 ++++++++++ 4 files changed, 114 insertions(+) create mode 100644 drivers/iio/adc/industrialio-adc.c create mode 100644 include/linux/iio/adc-helpers.h diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index 849c90203071..37b70a65da6f 100644 --- a/drivers/iio/adc/Kconfig +++ b/drivers/iio/adc/Kconfig @@ -6,6 +6,9 @@ menu "Analog to digital converters" +config IIO_ADC_HELPER + tristate + config AB8500_GPADC bool "ST-Ericsson AB8500 GPADC driver" depends on AB8500_CORE && REGULATOR_AB8500 diff --git a/drivers/iio/adc/Makefile b/drivers/iio/adc/Makefile index ee19afba62b7..1c410f483029 100644 --- a/drivers/iio/adc/Makefile +++ b/drivers/iio/adc/Makefile @@ -3,6 +3,8 @@ # Makefile for IIO ADC drivers # +obj-$(CONFIG_IIO_ADC_HELPER) += industrialio-adc.o + # When adding new entries keep the list in alphabetical order obj-$(CONFIG_AB8500_GPADC) += ab8500-gpadc.o obj-$(CONFIG_AD_SIGMA_DELTA) += ad_sigma_delta.o diff --git a/drivers/iio/adc/industrialio-adc.c b/drivers/iio/adc/industrialio-adc.c new file mode 100644 index 000000000000..b4057230e749 --- /dev/null +++ b/drivers/iio/adc/industrialio-adc.c @@ -0,0 +1,82 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Helpers for parsing common ADC information from a firmware node. + * + * Copyright (c) 2025 Matti Vaittinen + */ + +#include +#include +#include +#include +#include +#include + +#include +#include + +/** + * devm_iio_adc_device_alloc_chaninfo_se - allocate and fill iio_chan_spec for ADC + * + * Scan the device node for single-ended ADC channel information. Channel ID is + * expected to be found from the "reg" property. Allocate and populate the + * iio_chan_spec structure corresponding to channels that are found. The memory + * for iio_chan_spec structure will be freed upon device detach. + * + * @dev: Pointer to the ADC device. + * @template: Template iio_chan_spec from which the fields of all + * found and allocated channels are initialized. + * @max_chan_id: Maximum value of a channel ID. Use negative value if no + * checking is required. + * @cs: Location where pointer to allocated iio_chan_spec + * should be stored. + * + * Return: Number of found channels on success. Negative value to indicate + * failure. Specifically, -ENOENT if no channel nodes were found. + */ +int devm_iio_adc_device_alloc_chaninfo_se(struct device *dev, + const struct iio_chan_spec *template, + int max_chan_id, + struct iio_chan_spec **cs) +{ + struct iio_chan_spec *chan_array, *chan; + int num_chan, ret; + + num_chan = iio_adc_device_num_channels(dev); + if (num_chan < 0) + return num_chan; + + if (!num_chan) + return -ENOENT; + + chan_array = devm_kcalloc(dev, num_chan, sizeof(*chan_array), + GFP_KERNEL); + if (!chan_array) + return -ENOMEM; + + chan = &chan_array[0]; + + device_for_each_named_child_node_scoped(dev, child, "channel") { + u32 ch; + + ret = fwnode_property_read_u32(child, "reg", &ch); + if (ret) + return ret; + + if (max_chan_id >= 0 && ch > max_chan_id) + return -ERANGE; + + *chan = *template; + chan->channel = ch; + chan++; + } + + *cs = chan_array; + + return num_chan; +} +EXPORT_SYMBOL_NS_GPL(devm_iio_adc_device_alloc_chaninfo_se, "IIO_DRIVER"); + +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("Matti Vaittinen "); +MODULE_DESCRIPTION("IIO ADC fwnode parsing helpers"); diff --git a/include/linux/iio/adc-helpers.h b/include/linux/iio/adc-helpers.h new file mode 100644 index 000000000000..56b092a2a4c4 --- /dev/null +++ b/include/linux/iio/adc-helpers.h @@ -0,0 +1,27 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +/* + * The industrial I/O ADC firmware property parsing helpers + * + * Copyright (c) 2025 Matti Vaittinen + */ + +#ifndef _INDUSTRIAL_IO_ADC_HELPERS_H_ +#define _INDUSTRIAL_IO_ADC_HELPERS_H_ + +#include + +struct device; +struct iio_chan_spec; + +static inline int iio_adc_device_num_channels(struct device *dev) +{ + return device_get_named_child_node_count(dev, "channel"); +} + +int devm_iio_adc_device_alloc_chaninfo_se(struct device *dev, + const struct iio_chan_spec *template, + int max_chan_id, + struct iio_chan_spec **cs); + +#endif /* _INDUSTRIAL_IO_ADC_HELPERS_H_ */