diff mbox

acpi: pci_slot: Use more common logging style

Message ID fdc546e7c5bb8b3d7e37a1721e5158fc2217d6ee.1464364797.git.joe@perches.com (mailing list archive)
State Accepted, archived
Delegated to: Rafael Wysocki
Headers show

Commit Message

Joe Perches May 27, 2016, 4 p.m. UTC 
Use generic pr_<level> functions with pr_fmt for info and err.

This also reduces object size a trivial bit:

$ size drivers/acpi/pci_slot.o*
   text	   data	    bss	    dec	    hex	filename
    935	    752	      5	   1692	    69c	drivers/acpi/pci_slot.o.new
   1027	    752	      5	   1784	    6f8	drivers/acpi/pci_slot.o.old

Miscellanea:

o Remove unnecessary OOM message as k.alloc functions get a generic
  stack dump on OOM
o Remove unnecessary embedded prefix from a dbg() message

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/acpi/pci_slot.c | 28 +++++++++++++---------------
 1 file changed, 13 insertions(+), 15 deletions(-)

Comments

Rafael J. Wysocki June 23, 2016, 12:32 a.m. UTC | #1 
On Friday, May 27, 2016 09:00:28 AM Joe Perches wrote:
> Use generic pr_<level> functions with pr_fmt for info and err.
> 
> This also reduces object size a trivial bit:
> 
> $ size drivers/acpi/pci_slot.o*
>    text	   data	    bss	    dec	    hex	filename
>     935	    752	      5	   1692	    69c	drivers/acpi/pci_slot.o.new
>    1027	    752	      5	   1784	    6f8	drivers/acpi/pci_slot.o.old
> 
> Miscellanea:
> 
> o Remove unnecessary OOM message as k.alloc functions get a generic
>   stack dump on OOM
> o Remove unnecessary embedded prefix from a dbg() message
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Applied, thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/acpi/pci_slot.c b/drivers/acpi/pci_slot.c
index 7188e53..aa8f4c7 100644
--- a/drivers/acpi/pci_slot.c
+++ b/drivers/acpi/pci_slot.c
@@ -22,6 +22,8 @@ 
  *  General Public License for more details.
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/init.h>
@@ -48,14 +50,11 @@  module_param(debug, bool, 0644);
 #define _COMPONENT		ACPI_PCI_COMPONENT
 ACPI_MODULE_NAME("pci_slot");
 
-#define MY_NAME "pci_slot"
-#define err(format, arg...) pr_err("%s: " format , MY_NAME , ## arg)
-#define info(format, arg...) pr_info("%s: " format , MY_NAME , ## arg)
-#define dbg(format, arg...)					\
-	do {							\
-		if (debug)					\
-			pr_debug("%s: " format,	MY_NAME , ## arg); \
-	} while (0)
+#define dbg(fmt, ...)						\
+do {								\
+	if (debug)						\
+		pr_debug(fmt, ##__VA_ARGS__);			\
+} while (0)
 
 #define SLOT_NAME_SIZE 21		/* Inspired by #define in acpiphp.h */
 
@@ -132,15 +131,13 @@  register_slot(acpi_handle handle, u32 lvl, void *context, void **rv)
 	}
 
 	slot = kmalloc(sizeof(*slot), GFP_KERNEL);
-	if (!slot) {
-		err("%s: cannot allocate memory\n", __func__);
+	if (!slot)
 		return AE_OK;
-	}
 
 	snprintf(name, sizeof(name), "%llu", sun);
 	pci_slot = pci_create_slot(pci_bus, device, name, NULL);
 	if (IS_ERR(pci_slot)) {
-		err("pci_create_slot returned %ld\n", PTR_ERR(pci_slot));
+		pr_err("pci_create_slot returned %ld\n", PTR_ERR(pci_slot));
 		kfree(slot);
 		return AE_OK;
 	}
@@ -150,8 +147,8 @@  register_slot(acpi_handle handle, u32 lvl, void *context, void **rv)
 
 	get_device(&pci_bus->dev);
 
-	dbg("pci_slot: %p, pci_bus: %x, device: %d, name: %s\n",
-		pci_slot, pci_bus->number, device, name);
+	dbg("%p, pci_bus: %x, device: %d, name: %s\n",
+	    pci_slot, pci_bus->number, device, name);
 
 	return AE_OK;
 }
@@ -186,7 +183,8 @@  void acpi_pci_slot_remove(struct pci_bus *bus)
 
 static int do_sta_before_sun(const struct dmi_system_id *d)
 {
-	info("%s detected: will evaluate _STA before calling _SUN\n", d->ident);
+	pr_info("%s detected: will evaluate _STA before calling _SUN\n",
+		d->ident);
 	check_sta_before_sun = 1;
 	return 0;
 }