mbox series

[u-boot,v3,0/3] Add Amlogic Meson SPI Flash Controller driver

Message ID 20181114102520.25346-1-narmstrong@baylibre.com (mailing list archive)
Headers show
Series Add Amlogic Meson SPI Flash Controller driver | expand

Message

Neil Armstrong Nov. 14, 2018, 10:25 a.m. UTC 
The Amlogic Meson SoCs embeds a Flash oriented SPI Controller name SPIFC.

This patchset add the driver ported from linux, but also import the regmap
regmap_read_poll_timeout() to implify the register polling in the driver.

Neil Armstrong (3):
  regmap: add regmap_read_poll_timeout() helper
  test: regmap: add regmap_read_poll_timeout test
  spi: Add Amlogic Meson SPI Flash Controller driver

 drivers/spi/Kconfig       |   8 +
 drivers/spi/Makefile      |   1 +
 drivers/spi/meson_spifc.c | 330 ++++++++++++++++++++++++++++++++++++++
 include/regmap.h          |  38 +++++
 test/dm/regmap.c          |  26 +++
 5 files changed, 403 insertions(+)
 create mode 100644 drivers/spi/meson_spifc.c

Comments

Jerome Brunet Nov. 15, 2018, 3:41 p.m. UTC | #1 
On Wed, 2018-11-14 at 11:25 +0100, Neil Armstrong wrote:
> The Amlogic Meson SoCs embeds a Flash oriented SPI Controller name SPIFC.
> 
> This patchset add the driver ported from linux, but also import the regmap
> regmap_read_poll_timeout() to implify the register polling in the driver.
> 
> Neil Armstrong (3):
>   regmap: add regmap_read_poll_timeout() helper
>   test: regmap: add regmap_read_poll_timeout test
>   spi: Add Amlogic Meson SPI Flash Controller driver
> 
>  drivers/spi/Kconfig       |   8 +
>  drivers/spi/Makefile      |   1 +
>  drivers/spi/meson_spifc.c | 330 ++++++++++++++++++++++++++++++++++++++
>  include/regmap.h          |  38 +++++
>  test/dm/regmap.c          |  26 +++
>  5 files changed, 403 insertions(+)
>  create mode 100644 drivers/spi/meson_spifc.c
> 

Tested-by: Jerome Brunet <jbrunet@baylibre.com>

... on the libretech aml-s805x-ac which should be submitted soon.
Jagan Teki Nov. 22, 2018, 6:40 a.m. UTC | #2 
On Wed, Nov 14, 2018 at 3:55 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> The Amlogic Meson SoCs embeds a Flash oriented SPI Controller name SPIFC.
>
> This patchset add the driver ported from linux, but also import the regmap
> regmap_read_poll_timeout() to implify the register polling in the driver.
>
> Neil Armstrong (3):
>   regmap: add regmap_read_poll_timeout() helper
>   test: regmap: add regmap_read_poll_timeout test
>   spi: Add Amlogic Meson SPI Flash Controller driver

There are few regmap patches upstreamed recently, can you rebase and
the send the series again. take care of direct poll_timeout w/o any
function on driver.
Neil Armstrong Nov. 22, 2018, 8:21 a.m. UTC | #3 
On 22/11/2018 07:40, Jagan Teki wrote:
> On Wed, Nov 14, 2018 at 3:55 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> The Amlogic Meson SoCs embeds a Flash oriented SPI Controller name SPIFC.
>>
>> This patchset add the driver ported from linux, but also import the regmap
>> regmap_read_poll_timeout() to implify the register polling in the driver.
>>
>> Neil Armstrong (3):
>>   regmap: add regmap_read_poll_timeout() helper
>>   test: regmap: add regmap_read_poll_timeout test
>>   spi: Add Amlogic Meson SPI Flash Controller driver
> 
> There are few regmap patches upstreamed recently, can you rebase and
> the send the series again. take care of direct poll_timeout w/o any
> function on driver.
> 

Sure,

Neil