| Message ID | 20190729132622.7566-1-narmstrong@baylibre.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | arm64: g12a: add support for DVFS | expand |
Neil Armstrong <narmstrong@baylibre.com> writes: > The G12A & G12B SoCs has kernel controllable CPU clocks and PWMs for > voltage regulators. > > This patchsets moves the meson-g12a.dtsi to meson-g12-common.dtsi to simplify > handling the G12A & G12B differences in the meson-g12a.dtsi & meson-g12b.dtsi > files, like the OPPs and CPU nodes. > > Then G12A & G12B OPP tables are added, followed by the CPU voltages regulators > in each boards DT. > > It was voluntary chosen to enabled DVFS (CPU regulator and CPU clocks) only > in boards, to make sure only tested boards has DVFS enabled. > > This patchset : > - moves the G12A DT to a common g12a-common dtsi > - adds the G12A and G12B OPPs > - enables DVFS on all supported boards > > Dependencies: > - None Not quite. The last patch to enable DVFS on odroid-n2 has a build-time dependency on the clock series that adds the CPUB clock. I'll apply the rest of the series to v5.4/dt64 until there's a stable clock tag I can use for the clocks. Kevin
Kevin Hilman <khilman@baylibre.com> writes: > Neil Armstrong <narmstrong@baylibre.com> writes: > >> The G12A & G12B SoCs has kernel controllable CPU clocks and PWMs for >> voltage regulators. >> >> This patchsets moves the meson-g12a.dtsi to meson-g12-common.dtsi to simplify >> handling the G12A & G12B differences in the meson-g12a.dtsi & meson-g12b.dtsi >> files, like the OPPs and CPU nodes. >> >> Then G12A & G12B OPP tables are added, followed by the CPU voltages regulators >> in each boards DT. >> >> It was voluntary chosen to enabled DVFS (CPU regulator and CPU clocks) only >> in boards, to make sure only tested boards has DVFS enabled. >> >> This patchset : >> - moves the G12A DT to a common g12a-common dtsi >> - adds the G12A and G12B OPPs >> - enables DVFS on all supported boards >> >> Dependencies: >> - None > > Not quite. The last patch to enable DVFS on odroid-n2 has a build-time > dependency on the clock series that adds the CPUB clock. > > I'll apply the rest of the series to v5.4/dt64 until there's a stable > clock tag I can use for the clocks. In order to test this, I noticed another dependency needed for the PWM regulators to work: https://lore.kernel.org/linux-amlogic/20190729125838.6498-1-narmstrong@baylibre.com/ With that and the clock deps, it's working well on my odroid-n2. Tested-by: Kevin Hilman <khilman@baylibre.com> Thanks, Kevin
Kevin Hilman <khilman@baylibre.com> writes: > Kevin Hilman <khilman@baylibre.com> writes: > >> Neil Armstrong <narmstrong@baylibre.com> writes: >> >>> The G12A & G12B SoCs has kernel controllable CPU clocks and PWMs for >>> voltage regulators. >>> >>> This patchsets moves the meson-g12a.dtsi to meson-g12-common.dtsi to simplify >>> handling the G12A & G12B differences in the meson-g12a.dtsi & meson-g12b.dtsi >>> files, like the OPPs and CPU nodes. >>> >>> Then G12A & G12B OPP tables are added, followed by the CPU voltages regulators >>> in each boards DT. >>> >>> It was voluntary chosen to enabled DVFS (CPU regulator and CPU clocks) only >>> in boards, to make sure only tested boards has DVFS enabled. >>> >>> This patchset : >>> - moves the G12A DT to a common g12a-common dtsi >>> - adds the G12A and G12B OPPs >>> - enables DVFS on all supported boards >>> >>> Dependencies: >>> - None >> >> Not quite. The last patch to enable DVFS on odroid-n2 has a build-time >> dependency on the clock series that adds the CPUB clock. >> >> I'll apply the rest of the series to v5.4/dt64 until there's a stable >> clock tag I can use for the clocks. > > In order to test this, I noticed another dependency needed for the PWM > regulators to work: > > https://lore.kernel.org/linux-amlogic/20190729125838.6498-1-narmstrong@baylibre.com/ > > With that and the clock deps, it's working well on my odroid-n2. > > Tested-by: Kevin Hilman <khilman@baylibre.com> Also now tested on g12a: u200, x96-max and sei510 boards. Kevin
Kevin Hilman <khilman@baylibre.com> writes: > Kevin Hilman <khilman@baylibre.com> writes: > >> Neil Armstrong <narmstrong@baylibre.com> writes: >> >>> The G12A & G12B SoCs has kernel controllable CPU clocks and PWMs for >>> voltage regulators. >>> >>> This patchsets moves the meson-g12a.dtsi to meson-g12-common.dtsi to simplify >>> handling the G12A & G12B differences in the meson-g12a.dtsi & meson-g12b.dtsi >>> files, like the OPPs and CPU nodes. >>> >>> Then G12A & G12B OPP tables are added, followed by the CPU voltages regulators >>> in each boards DT. >>> >>> It was voluntary chosen to enabled DVFS (CPU regulator and CPU clocks) only >>> in boards, to make sure only tested boards has DVFS enabled. >>> >>> This patchset : >>> - moves the G12A DT to a common g12a-common dtsi >>> - adds the G12A and G12B OPPs >>> - enables DVFS on all supported boards >>> >>> Dependencies: >>> - None >> >> Not quite. The last patch to enable DVFS on odroid-n2 has a build-time >> dependency on the clock series that adds the CPUB clock. >> >> I'll apply the rest of the series to v5.4/dt64 until there's a stable >> clock tag I can use for the clocks. > > In order to test this, I noticed another dependency needed for the PWM > regulators to work: > > https://lore.kernel.org/linux-amlogic/20190729125838.6498-1-narmstrong@baylibre.com/ > > With that and the clock deps, it's working well on my odroid-n2. > > Tested-by: Kevin Hilman <khilman@baylibre.com> After merging Jerome's tag for clk DT, I've queued this for v5.4, Thanks, Kevin