[0/2] drm: panel: add support for TDO tl070wsh30 panel

Message

Neil Armstrong Sept. 4, 2020, 4:15 p.m. UTC

This adds support bindings and support for the TDO TL070WSH30 TFT-LCD panel
module shipped with the Amlogic S400 Development Kit.
The panel has a 1024×600 resolution and uses 24 bit RGB per pixel.
It provides a MIPI DSI interface to the host, a built-in LED backlight
and touch controller.

Neil Armstrong (2):
  dt-bindings: display: panel: add TDO tl070wsh30 DSI panel bindings
  drm: panel: add TDO tl070wsh30 panel driver

 .../display/panel/tdo,tl070wsh30.yaml         |  58 ++++
 drivers/gpu/drm/panel/Kconfig                 |  11 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c  | 263 ++++++++++++++++++
 4 files changed, 333 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml
 create mode 100644 drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c

Comments

Neil Armstrong Sept. 7, 2020, 10:33 a.m. UTC | #1

Hi,

Please ignore this serie, the vendors patch is missing and the panel driver
still has the vrefresh...

Will repost.

Neil

On 04/09/2020 18:15, Neil Armstrong wrote:
> This adds support bindings and support for the TDO TL070WSH30 TFT-LCD panel
> module shipped with the Amlogic S400 Development Kit.
> The panel has a 1024×600 resolution and uses 24 bit RGB per pixel.
> It provides a MIPI DSI interface to the host, a built-in LED backlight
> and touch controller.
> 
> Neil Armstrong (2):
>   dt-bindings: display: panel: add TDO tl070wsh30 DSI panel bindings
>   drm: panel: add TDO tl070wsh30 panel driver
> 
>  .../display/panel/tdo,tl070wsh30.yaml         |  58 ++++
>  drivers/gpu/drm/panel/Kconfig                 |  11 +
>  drivers/gpu/drm/panel/Makefile                |   1 +
>  drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c  | 263 ++++++++++++++++++
>  4 files changed, 333 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/tdo,tl070wsh30.yaml
>  create mode 100644 drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c
>

Sam Ravnborg Sept. 7, 2020, 10:54 a.m. UTC | #2

On Mon, Sep 07, 2020 at 12:33:41PM +0200, Neil Armstrong wrote:
> Hi,
> 
> Please ignore this serie, the vendors patch is missing and the panel driver
> still has the vrefresh...
> 
> Will repost.

Please fix so DRM_DEV_* is replaced by dev_* logging.
We no longer use the DRM_ based logging for panels.

Drop drm_print.h from includes and fix build.

I did not read the code just noticed this detail.

	Sam

Neil Armstrong Sept. 7, 2020, 11:03 a.m. UTC | #3

Hi Sam,

On 07/09/2020 12:54, Sam Ravnborg wrote:
> On Mon, Sep 07, 2020 at 12:33:41PM +0200, Neil Armstrong wrote:
>> Hi,
>>
>> Please ignore this serie, the vendors patch is missing and the panel driver
>> still has the vrefresh...
>>
>> Will repost.
> 
> Please fix so DRM_DEV_* is replaced by dev_* logging.
> We no longer use the DRM_ based logging for panels.
> 
> Drop drm_print.h from includes and fix build.

Done, thanks for noticing.

Neil

> 
> I did not read the code just noticed this detail.
> 
> 	Sam
>