| Message ID | 20201104135631.1550125-1-narmstrong@baylibre.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | phy: amlogic: add MIPI DSI function to analog MIPI+PCIe PHY | expand |
Hi Vinod, Kishon, On 04/11/2020 14:56, Neil Armstrong wrote: > The AXG Analog MIPI-DSI PHY also provides functions to the PCIe PHY, > thus we need to have inclusive support for both interfaces at runtime. > > This fixes the regmap get from parent node, removes cell param > to select a mode and implement runtime configuration & power on/off > for both functions since they are not exclusive. > > Changes since v2 at [2]: > - Add DT review tags > - Rebase on 5.10-rc1 > > Changes since v1 at [1]: > - added description to binding as requested parent > - updated commit log of patch 1 > - also update example of patch 1 > > [1] https://lkml.kernel.org/r/20200907073402.26674-1-narmstrong@baylibre.com > [2] https://lkml.kernel.org/r/20200915130339.11079-1-narmstrong@baylibre.com > > Neil Armstrong (3): > dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: remove reg > attribute > dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: remove phy cell > parameter > phy: amlogic: phy-meson-axg-mipi-pcie-analog: add support for MIPI DSI > analog > > .../amlogic,meson-axg-mipi-pcie-analog.yaml | 21 +- > drivers/phy/amlogic/Kconfig | 1 + > .../amlogic/phy-meson-axg-mipi-pcie-analog.c | 204 ++++++++++++------ > 3 files changed, 149 insertions(+), 77 deletions(-) > Could you review this serie ? Neil
The AXG Analog MIPI-DSI PHY also provides functions to the PCIe PHY, thus we need to have inclusive support for both interfaces at runtime. This fixes the regmap get from parent node, removes cell param to select a mode and implement runtime configuration & power on/off for both functions since they are not exclusive. Changes since v2 at [2]: - Add DT review tags - Rebase on 5.10-rc1 Changes since v1 at [1]: - added description to binding as requested parent - updated commit log of patch 1 - also update example of patch 1 [1] https://lkml.kernel.org/r/20200907073402.26674-1-narmstrong@baylibre.com [2] https://lkml.kernel.org/r/20200915130339.11079-1-narmstrong@baylibre.com Neil Armstrong (3): dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: remove reg attribute dt-bindings: phy: amlogic,meson-axg-mipi-pcie-analog: remove phy cell parameter phy: amlogic: phy-meson-axg-mipi-pcie-analog: add support for MIPI DSI analog .../amlogic,meson-axg-mipi-pcie-analog.yaml | 21 +- drivers/phy/amlogic/Kconfig | 1 + .../amlogic/phy-meson-axg-mipi-pcie-analog.c | 204 ++++++++++++------ 3 files changed, 149 insertions(+), 77 deletions(-)