| Message ID | 20220408080045.6497-1-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | mmc: improve API to make clear {h|s}w_reset is for cards | expand |
On Fri, 8 Apr 2022 at 10:01, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > As discussed in 2020 [1], Ulf and I agreed that it would be easier to > understand the {h|s}w_reset mechanisms if it was clear that they are for > cards. This series implements that by changing the parameter to mmc_card > where apropriate. Also, the callback into host drivers has been renamed > to 'card_hw_reset' to make it obvious what exactly the driver is > expected to reset. > > I tested it with my Renesas boards, so far no regressions. Buildbots are > currently checking the series. > > This series is based on mmc/next as of yesterday. A branch is here: > > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/mmc/reset-api-v2 > > Looking forward to comments. Happy hacking, > > Wolfram > > [1] https://lore.kernel.org/all/20200916090121.2350-1-wsa+renesas@sang-engineering.com/ > > Wolfram Sang (3): > mmc: core: improve API to make clear mmc_hw_reset is for cards > mmc: core: improve API to make clear that mmc_sw_reset is for cards > mmc: improve API to make clear hw_reset callback is for cards > > drivers/mmc/core/block.c | 2 +- > drivers/mmc/core/core.c | 12 +++++++----- > drivers/mmc/core/mmc.c | 4 ++-- > drivers/mmc/core/mmc_test.c | 3 +-- > drivers/mmc/host/bcm2835.c | 2 +- > drivers/mmc/host/dw_mmc.c | 2 +- > drivers/mmc/host/meson-mx-sdhc-mmc.c | 2 +- > drivers/mmc/host/mtk-sd.c | 2 +- > drivers/mmc/host/sdhci.c | 2 +- > drivers/mmc/host/sunxi-mmc.c | 2 +- > drivers/mmc/host/uniphier-sd.c | 2 +- > drivers/net/wireless/ath/ath10k/sdio.c | 2 +- > .../net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 +- > drivers/net/wireless/marvell/mwifiex/sdio.c | 2 +- > drivers/net/wireless/ti/wlcore/sdio.c | 2 +- > include/linux/mmc/core.h | 4 ++-- > include/linux/mmc/host.h | 2 +- > 17 files changed, 25 insertions(+), 24 deletions(-) > Patch 1 applied for fixes and the two others for next, thanks! Kind regards Uffe
As discussed in 2020 [1], Ulf and I agreed that it would be easier to understand the {h|s}w_reset mechanisms if it was clear that they are for cards. This series implements that by changing the parameter to mmc_card where apropriate. Also, the callback into host drivers has been renamed to 'card_hw_reset' to make it obvious what exactly the driver is expected to reset. I tested it with my Renesas boards, so far no regressions. Buildbots are currently checking the series. This series is based on mmc/next as of yesterday. A branch is here: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/mmc/reset-api-v2 Looking forward to comments. Happy hacking, Wolfram [1] https://lore.kernel.org/all/20200916090121.2350-1-wsa+renesas@sang-engineering.com/ Wolfram Sang (3): mmc: core: improve API to make clear mmc_hw_reset is for cards mmc: core: improve API to make clear that mmc_sw_reset is for cards mmc: improve API to make clear hw_reset callback is for cards drivers/mmc/core/block.c | 2 +- drivers/mmc/core/core.c | 12 +++++++----- drivers/mmc/core/mmc.c | 4 ++-- drivers/mmc/core/mmc_test.c | 3 +-- drivers/mmc/host/bcm2835.c | 2 +- drivers/mmc/host/dw_mmc.c | 2 +- drivers/mmc/host/meson-mx-sdhc-mmc.c | 2 +- drivers/mmc/host/mtk-sd.c | 2 +- drivers/mmc/host/sdhci.c | 2 +- drivers/mmc/host/sunxi-mmc.c | 2 +- drivers/mmc/host/uniphier-sd.c | 2 +- drivers/net/wireless/ath/ath10k/sdio.c | 2 +- .../net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 +- drivers/net/wireless/marvell/mwifiex/sdio.c | 2 +- drivers/net/wireless/ti/wlcore/sdio.c | 2 +- include/linux/mmc/core.h | 4 ++-- include/linux/mmc/host.h | 2 +- 17 files changed, 25 insertions(+), 24 deletions(-)