| Message ID | 20230516064736.10270-1-yu.tu@amlogic.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add S4 SoC PLL and Peripheral clock | expand |
On 16/05/2023 08:47, Yu Tu wrote: > 1. Add S4 SoC PLL and Peripheral clock controller dt-bindings. > 2. Add PLL and Peripheral clock controller driver for S4 SOC. > > Yu Tu (4): > dt-bindings: clock: document Amlogic S4 SoC PLL clock controller > dt-bindings: clock: document Amlogic S4 SoC peripherals clock > controller > clk: meson: S4: add support for Amlogic S4 SoC PLL clock driver > clk: meson: s4: add support for Amlogic S4 SoC peripheral clock > controller > > V7 -> V8: > 1. Change patch 0001/0002 dt-bindings title description, remove "meson". > Suggested by Dmitry, Neil. So you only removed one word from title and description? This does not justify dropping review tag. You already got a comment for this - add the tag. Best regards, Krzysztof
On 2023/5/16 17:20, Krzysztof Kozlowski wrote: > [ EXTERNAL EMAIL ] > > On 16/05/2023 08:47, Yu Tu wrote: >> 1. Add S4 SoC PLL and Peripheral clock controller dt-bindings. >> 2. Add PLL and Peripheral clock controller driver for S4 SOC. >> >> Yu Tu (4): >> dt-bindings: clock: document Amlogic S4 SoC PLL clock controller >> dt-bindings: clock: document Amlogic S4 SoC peripherals clock >> controller >> clk: meson: S4: add support for Amlogic S4 SoC PLL clock driver >> clk: meson: s4: add support for Amlogic S4 SoC peripheral clock >> controller >> >> V7 -> V8: >> 1. Change patch 0001/0002 dt-bindings title description, remove "meson". >> Suggested by Dmitry, Neil. > > So you only removed one word from title and description? This does not > justify dropping review tag. Yes. I just remove one work. > > You already got a comment for this - add the tag. I wonder what I should do next? Add the tag and RESEND it again? > > Best regards, > Krzysztof >
On 16/05/2023 11:25, Yu Tu wrote: > > > On 2023/5/16 17:20, Krzysztof Kozlowski wrote: >> [ EXTERNAL EMAIL ] >> >> On 16/05/2023 08:47, Yu Tu wrote: >>> 1. Add S4 SoC PLL and Peripheral clock controller dt-bindings. >>> 2. Add PLL and Peripheral clock controller driver for S4 SOC. >>> >>> Yu Tu (4): >>> dt-bindings: clock: document Amlogic S4 SoC PLL clock controller >>> dt-bindings: clock: document Amlogic S4 SoC peripherals clock >>> controller >>> clk: meson: S4: add support for Amlogic S4 SoC PLL clock driver >>> clk: meson: s4: add support for Amlogic S4 SoC peripheral clock >>> controller >>> >>> V7 -> V8: >>> 1. Change patch 0001/0002 dt-bindings title description, remove "meson". >>> Suggested by Dmitry, Neil. >> >> So you only removed one word from title and description? This does not >> justify dropping review tag. > > Yes. I just remove one work. > >> >> You already got a comment for this - add the tag. > > I wonder what I should do next? > Add the tag and RESEND it again? I cannot add other people tags, e.g. b4 ignores them. Best regards, Krzysztof
1. Add S4 SoC PLL and Peripheral clock controller dt-bindings. 2. Add PLL and Peripheral clock controller driver for S4 SOC. Yu Tu (4): dt-bindings: clock: document Amlogic S4 SoC PLL clock controller dt-bindings: clock: document Amlogic S4 SoC peripherals clock controller clk: meson: S4: add support for Amlogic S4 SoC PLL clock driver clk: meson: s4: add support for Amlogic S4 SoC peripheral clock controller V7 -> V8: 1. Change patch 0001/0002 dt-bindings title description, remove "meson". Suggested by Dmitry, Neil. 2. Change patch 0003/0004 clocks comment, format and clock flags suggested by Dmitry, Neil, Jerome. V6 -> V7: Change send patch series as well change format and clock flags suggested by Jerome. Change dt-bindings suggested by Krzysztof. V5 -> V6: Change send patch series, as well change format and clock flags. V4 -> V5: change format and clock flags and adjust the patch series as suggested by Jerome. V3 -> V4: change format and clock flags. V2 -> V3: Use two clock controller. V1 -> V2: Change format as discussed in the email. Link:https://lore.kernel.org/all/20230417065005.24967-1-yu.tu@amlogic.com/ .../clock/amlogic,s4-peripherals-clkc.yaml | 97 + .../bindings/clock/amlogic,s4-pll-clkc.yaml | 50 + MAINTAINERS | 1 + drivers/clk/meson/Kconfig | 25 + drivers/clk/meson/Makefile | 2 + drivers/clk/meson/s4-peripherals.c | 3830 +++++++++++++++++ drivers/clk/meson/s4-peripherals.h | 217 + drivers/clk/meson/s4-pll.c | 907 ++++ drivers/clk/meson/s4-pll.h | 87 + .../clock/amlogic,s4-peripherals-clkc.h | 131 + .../dt-bindings/clock/amlogic,s4-pll-clkc.h | 30 + 11 files changed, 5377 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/amlogic,s4-peripherals-clkc.yaml create mode 100644 Documentation/devicetree/bindings/clock/amlogic,s4-pll-clkc.yaml create mode 100644 drivers/clk/meson/s4-peripherals.c create mode 100644 drivers/clk/meson/s4-peripherals.h create mode 100644 drivers/clk/meson/s4-pll.c create mode 100644 drivers/clk/meson/s4-pll.h create mode 100644 include/dt-bindings/clock/amlogic,s4-peripherals-clkc.h create mode 100644 include/dt-bindings/clock/amlogic,s4-pll-clkc.h base-commit: ac9a78681b921877518763ba0e89202254349d1b