| Message ID | 20230724060108.1403662-1-huqiang.qin@amlogic.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add binding header file for GPIO interrupt of Amlogic Meson-G12A | expand |
Hi Linus, On 24/07/2023 08:01, Huqiang Qin wrote: > After adding this binding header file, you can intuitively find > the interrupt number corresponding to each GPIO, and apply it > in the format of IRQID_XXX where it needs to be used. > > Associated platforms: > - Amlogic Meson-G12A > - Amlogic Meson-G12B > - Amlogic Meson-SM1 > > [PATCH 1/3]: > V1 -> V2: Rename irq-meson-g12a-gpio.h to amlogic,meson-g12a-gpio-intc.h > > [PATCH 2/3]: > V1 -> V2: Include header file changed to amlogic,meson-g12a-gpio-intc.h > > [PATCH 3/3]: > V1 -> V2: Include header file changed to amlogic,meson-g12a-gpio-intc.h > > Huqiang Qin (3): > dt-bindings: interrupt-controller: Add header file for Amlogic > Meson-G12A SoCs > pinctrl: Replace the IRQ number in the driver with the IRQID macro > definition > arm64: dts: Replace the IRQ number with the IRQID macro definition What's the best way to apply this patchset ? Thanks, Neil > > .../boot/dts/amlogic/meson-g12-common.dtsi | 1 + > .../boot/dts/amlogic/meson-g12a-x96-max.dts | 2 +- > .../dts/amlogic/meson-g12b-bananapi-cm4.dtsi | 2 +- > .../boot/dts/amlogic/meson-g12b-bananapi.dtsi | 2 +- > .../amlogic/meson-g12b-odroid-go-ultra.dts | 4 +- > .../dts/amlogic/meson-g12b-odroid-n2.dtsi | 2 +- > .../boot/dts/amlogic/meson-g12b-w400.dtsi | 2 +- > .../dts/amlogic/meson-sm1-a95xf3-air-gbit.dts | 2 +- > .../boot/dts/amlogic/meson-sm1-bananapi.dtsi | 4 +- > .../boot/dts/amlogic/meson-sm1-h96-max.dts | 2 +- > .../boot/dts/amlogic/meson-sm1-odroid.dtsi | 2 +- > .../boot/dts/amlogic/meson-sm1-sei610.dts | 12 +- > .../dts/amlogic/meson-sm1-x96-air-gbit.dts | 2 +- > drivers/pinctrl/meson/pinctrl-meson-g12a.c | 35 ++--- > .../amlogic,meson-g12a-gpio-intc.h | 126 ++++++++++++++++++ > 15 files changed, 164 insertions(+), 36 deletions(-) > create mode 100644 include/dt-bindings/interrupt-controller/amlogic,meson-g12a-gpio-intc.h > > > base-commit: c58c49dd89324b18a812762a2bfa5a0458e4f252
On Mon, Jul 24, 2023 at 8:02 AM Huqiang Qin <huqiang.qin@amlogic.com> wrote: > After adding this binding header file, you can intuitively find > the interrupt number corresponding to each GPIO, and apply it > in the format of IRQID_XXX where it needs to be used. (...) > Huqiang Qin (3): > dt-bindings: interrupt-controller: Add header file for Amlogic > Meson-G12A SoCs > pinctrl: Replace the IRQ number in the driver with the IRQID macro > definition > arm64: dts: Replace the IRQ number with the IRQID macro definition Neil wrote: > What's the best way to apply this patchset ? I just applied all three to the pin control tree. I could have applied just the two first and then offered an immutable branch. But eh... too much work for too low risk. Better to just apply it and hope all works out. If it explodes I just back out and figure something like the above. Yours, Linus Walleij
On 07/08/2023 15:37, Linus Walleij wrote: > On Mon, Jul 24, 2023 at 8:02 AM Huqiang Qin <huqiang.qin@amlogic.com> wrote: > >> After adding this binding header file, you can intuitively find >> the interrupt number corresponding to each GPIO, and apply it >> in the format of IRQID_XXX where it needs to be used. > (...) > >> Huqiang Qin (3): >> dt-bindings: interrupt-controller: Add header file for Amlogic >> Meson-G12A SoCs >> pinctrl: Replace the IRQ number in the driver with the IRQID macro >> definition >> arm64: dts: Replace the IRQ number with the IRQID macro definition > > Neil wrote: >> What's the best way to apply this patchset ? > > I just applied all three to the pin control tree. > > I could have applied just the two first and then offered an > immutable branch. But eh... too much work for too low risk. > Better to just apply it and hope all works out. If it explodes > I just back out and figure something like the above. Perfect, thx :-) Neil > > Yours, > Linus Walleij
After adding this binding header file, you can intuitively find the interrupt number corresponding to each GPIO, and apply it in the format of IRQID_XXX where it needs to be used. Associated platforms: - Amlogic Meson-G12A - Amlogic Meson-G12B - Amlogic Meson-SM1 [PATCH 1/3]: V1 -> V2: Rename irq-meson-g12a-gpio.h to amlogic,meson-g12a-gpio-intc.h [PATCH 2/3]: V1 -> V2: Include header file changed to amlogic,meson-g12a-gpio-intc.h [PATCH 3/3]: V1 -> V2: Include header file changed to amlogic,meson-g12a-gpio-intc.h Huqiang Qin (3): dt-bindings: interrupt-controller: Add header file for Amlogic Meson-G12A SoCs pinctrl: Replace the IRQ number in the driver with the IRQID macro definition arm64: dts: Replace the IRQ number with the IRQID macro definition .../boot/dts/amlogic/meson-g12-common.dtsi | 1 + .../boot/dts/amlogic/meson-g12a-x96-max.dts | 2 +- .../dts/amlogic/meson-g12b-bananapi-cm4.dtsi | 2 +- .../boot/dts/amlogic/meson-g12b-bananapi.dtsi | 2 +- .../amlogic/meson-g12b-odroid-go-ultra.dts | 4 +- .../dts/amlogic/meson-g12b-odroid-n2.dtsi | 2 +- .../boot/dts/amlogic/meson-g12b-w400.dtsi | 2 +- .../dts/amlogic/meson-sm1-a95xf3-air-gbit.dts | 2 +- .../boot/dts/amlogic/meson-sm1-bananapi.dtsi | 4 +- .../boot/dts/amlogic/meson-sm1-h96-max.dts | 2 +- .../boot/dts/amlogic/meson-sm1-odroid.dtsi | 2 +- .../boot/dts/amlogic/meson-sm1-sei610.dts | 12 +- .../dts/amlogic/meson-sm1-x96-air-gbit.dts | 2 +- drivers/pinctrl/meson/pinctrl-meson-g12a.c | 35 ++--- .../amlogic,meson-g12a-gpio-intc.h | 126 ++++++++++++++++++ 15 files changed, 164 insertions(+), 36 deletions(-) create mode 100644 include/dt-bindings/interrupt-controller/amlogic,meson-g12a-gpio-intc.h base-commit: c58c49dd89324b18a812762a2bfa5a0458e4f252