From patchwork Tue Mar 4 17:05:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 14001374 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3587EC021B8 for ; Tue, 4 Mar 2025 20:44:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:MIME-Version:Message-Id:Date: Subject:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=6NH3s0bMi+VW7OPmeFb6QrUEAr0QrSiHcu5EZVsfw6k=; b=klNA8DR04V03s8 2AlelzMXnZfoRt6O/dmUBu/JK+beExghRLKvEb8xJKGTEQe17ukXVD9tnf4P5Gej57RPE64K9Jrkk QLPIwVJGJ8vw7dhLO2S+QgF6k+LCgmtQMbthMBeXLAAVsUBd078UbU9F5ABbVrtw0gc49IvJDO62J /gAcAJRnzSuuldbxdS01rMFqAuSi4bgHUX6LjhIg9B4x5Q75kZUIID1X3TWcdfgCOyN9phnBr5tn8 pu2oU+8Mp9caRucRlMASrR8yLG9KY2o/cSzKRImmDmDEzHC2lgkFSzeGhNes21X1b+gG5ct9RJz8X ip/1pWbj0m2nHZwDEWBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpZ8B-00000006DQp-416w; Tue, 04 Mar 2025 20:44:47 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpVi1-00000005Y8W-3Huv for linux-amlogic@lists.infradead.org; Tue, 04 Mar 2025 17:05:35 +0000 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5e4ce6e3b8cso2554583a12.1 for ; Tue, 04 Mar 2025 09:05:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741107931; x=1741712731; darn=lists.infradead.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=VwGP1hOkgqyt7cuslt+mBb5Pi8swKaj/YmncchBevCs=; b=vHcbuQ1/KUWTMUj21D6/VxZhrO+gmlL4Gt2cqNXsHkE54CQ+eh1aDqmpKgonYvYQwQ 1RDPsS44XVvMpP4KjstNJVn/SYJyYuCZ+xa7XDJn1YcJWWnfeXDjOGWVa+zzzhJYv5Py GOiwvMc3wRtlppzE8HU+Hl3JdhfBfTKL6UdifQPimyh1bS3yfOFkIwnc47KNcI05vfoe qRx52PPhJ9CdFUPrEn82QHvf3j5iSKnopz1ZKVh8cbdvYdT7as5DkmqXTVNhtN9/SzLC 04uqKxztNPg4hfXIfTt74/7qkCt0vPoYc8dZmlTzrbZqlZ+gJuxh8aXwUls7V0i/GhGQ laIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741107931; x=1741712731; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VwGP1hOkgqyt7cuslt+mBb5Pi8swKaj/YmncchBevCs=; b=ZtdV80JYcrwTiQGw+yIwAL7vtnkbWZu/LW7LhhC1+1B6LX1j02EYoKiJ64tMXeXvds 57Lw9mujf6VAi02V/E7zJcU2NBXTs9t7boyWcfLkCLNwIecN0atkX+C8fgWeafSTeO/g 2XbQpxS1mqBXAbLE5LgOd0JTkkFZPkVrEmoezzcfOZGQIudQMIl7Rm2w7qB8vALAyYSY X8Unt0S9vqEL48d/eYoY2L0nGqcZRZvjMpIbGR1xgeyTxf3o9tJUark9ordqLKHIdcrC HsIHFeVP1TvZCzfwpGK+q63OkP8zDefjER+72tmuUL0KusngfYN47eyWRfLO2jNhkWjV wfmA== X-Forwarded-Encrypted: i=1; AJvYcCX3/lOICjNH6v1mb2p0XZa5gQZhf/yVw6N3KTaDUuUnEHU3IpnDe/9kVkG2OFGV1OWN+vG0glLVQ6sAJq8D@lists.infradead.org X-Gm-Message-State: AOJu0Yx2KdM+O8WMmp0Wcdstl1S0UDENoqjPsQCt79PZtacC0Qfe+Tg4 SQZfUmtS8NTLlTqZvAGGwVC/CkXOrurDtf4ltpZJ4U/7yNMRO79PhRaAgiWxLxk= X-Gm-Gg: ASbGnct7rrBgQB8eUBFpxE/6x6+Lp0q+K8zdTv0pAS/rpcrls+GNPSm0n2L/1DGqcG3 kD0b5Cwr8B5xqv4UoV+cCzTBPPg9KvHC9QuRscdaTZL1L7FngJjKG3koUivtEjjdNgMAzoLyoLz 4sH6bJvHaXCgB305K5+9QeQM+oZ7LTvrIjMfvPD2Dr4O3U8HJjvfR3Xg5imqyX5JBDJIuBMI26D IZp2WkR+D2PVGSVEAwuvXmYmGHT01a5ahD7gG1A+eT2Ecw8Clg4yU77306VYhi8wlHmq+L8334l 4dzTyah9b1xWsd44Lvd5SdoOytHB0efzwSG+9Vee3sA0gK9OtRB6cX+ivXKwBKeC2/wvMabvPlY xza6O6T48XyIHa/pSt0g2fEmEy2eH X-Google-Smtp-Source: AGHT+IG1qDKc0hst2zevKKhfPXC0MrEb14O70/5mMsp5hFfaUprLxoI4xNFXRR1d5hlR/z34qhDcpw== X-Received: by 2002:a17:907:da0:b0:abf:23a7:fc6 with SMTP id a640c23a62f3a-ac1f1185263mr365511466b.16.1741107931351; Tue, 04 Mar 2025 09:05:31 -0800 (PST) Received: from puffmais.c.googlers.com (30.171.91.34.bc.googleusercontent.com. [34.91.171.30]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf795ba15esm367589066b.131.2025.03.04.09.05.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Mar 2025 09:05:30 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Subject: [PATCH v2 00/16] a few rtc driver cleanups Date: Tue, 04 Mar 2025 17:05:28 +0000 Message-Id: <20250304-rtc-cleanups-v2-0-d4689a71668c@linaro.org> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIANgyx2cC/3XMQQrCMBCF4auUWRtJxhSDK+9Rukjj2A6UpExqU Urubuze5f/gfTtkEqYMt2YHoY0zp1gDTw2EyceRFD9qA2psNaJTsgYVZvLxtWRlMOihNXghb6F eFqEnvw+u62tPnNckn0PfzG/9A21GaTVYGyjoq7PO3GeOXtI5yQh9KeULAj75TakAAAA= X-Change-ID: 20250228-rtc-cleanups-12c0b5123ea4 To: Chanwoo Choi , Krzysztof Kozlowski , Alexandre Belloni , Joel Stanley , Andrew Jeffery , Hans Ulli Kroll , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , =?utf-8?b?VMOz?= =?utf-8?b?dGggSsOhbm9z?= , Dianlong Li , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-amlogic@lists.infradead.org, llvm@lists.linux.dev, =?utf-8?q?Andr=C3=A9_Draszik?= , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250304_090533_834090_384FEF75 X-CRM114-Status: UNSURE ( 8.57 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi, While looking at RTC, I noticed that various drivers are keeping pointers to data that they're not using themselves throughout their lifetime. So I took the liberty to drop these pointers and this series is the result. The last two patches also convert two drivers to using dev_err_probe(), as I looked slightly closer into those two. They don't exactly fit the general subject of removal of unneeded pointers, but I wanted to share them anyway, since they're ready. Drivers other than s5m were compile-tested only. Cheers, Andre' Signed-off-by: André Draszik --- Changes in v2: - s5m: fix arguments to devm_i2c_new_dummy_device() - merge two rx8581 & sd3078 patches into one each (Alexandre) - Link to v1: https://lore.kernel.org/r/20250228-rtc-cleanups-v1-0-b44cec078481@linaro.org --- André Draszik (16): rtc: max77686: drop needless struct max77686_rtc_info::rtc member rtc: s5m: drop needless struct s5m_rtc_info::i2c member rtc: aspeed: drop needless struct aspeed_rtc::rtc_dev member rtc: ds2404: drop needless struct ds2404::rtc member rtc: ep93xx: drop needless struct ep93xx_rtc::rtc member rtc: ftrtc010: drop needless struct ftrtc010_rtc::rtc_dev member rtc: m48t86: drop needless struct m48t86_rtc_info::rtc member rtc: meson: drop needless struct meson_rtc::rtc member rtc: meson-vrtc: drop needless struct meson_vrtc_data::rtc member rtc: pl030: drop needless struct pl030_rtc::rtc member rtc: rx8581: drop needless struct rx8581 rtc: s35390a: drop needless struct s35390a::rtc member rtc: sd2405al: drop needless struct sd2405al::rtc member rtc: sd3078: drop needless struct sd3078 rtc: max77686: use dev_err_probe() where appropriate rtc: s5m: convert to dev_err_probe() where appropriate drivers/rtc/rtc-aspeed.c | 16 ++++----- drivers/rtc/rtc-ds2404.c | 14 ++++---- drivers/rtc/rtc-ep93xx.c | 16 ++++----- drivers/rtc/rtc-ftrtc010.c | 17 +++++---- drivers/rtc/rtc-m48t86.c | 14 ++++---- drivers/rtc/rtc-max77686.c | 37 +++++++++---------- drivers/rtc/rtc-meson-vrtc.c | 12 +++---- drivers/rtc/rtc-meson.c | 16 ++++----- drivers/rtc/rtc-pl030.c | 14 ++++---- drivers/rtc/rtc-rx8581.c | 85 +++++++++++++++++++------------------------- drivers/rtc/rtc-s35390a.c | 22 ++++++------ drivers/rtc/rtc-s5m.c | 58 +++++++++++++----------------- drivers/rtc/rtc-sd2405al.c | 16 ++++----- drivers/rtc/rtc-sd3078.c | 71 +++++++++++++++--------------------- 14 files changed, 183 insertions(+), 225 deletions(-) --- base-commit: 0226d0ce98a477937ed295fb7df4cc30b46fc304 change-id: 20250228-rtc-cleanups-12c0b5123ea4 Best regards,