| Message ID | 04781c15-b543-337c-d6d4-8378bd558cf7@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Heiner Kallweit <hkallweit1@gmail.com> writes: > MMC core does a deep copy of init.name, therefore it's fully ok to I assume you mean the clock framework, not the MMC core, right? > provide a local variable. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> With the changelog fixed, Acked-by: Kevin Hilman <khilman@baylibre.com> > --- > drivers/mmc/host/meson-gx-mmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c > index 39904fb5..806554b1 100644 > --- a/drivers/mmc/host/meson-gx-mmc.c > +++ b/drivers/mmc/host/meson-gx-mmc.c > @@ -276,7 +276,7 @@ static int meson_mmc_clk_init(struct meson_host *host) > > /* create the divider */ > snprintf(clk_name, sizeof(clk_name), "%s#div", dev_name(host->dev)); > - init.name = devm_kstrdup(host->dev, clk_name, GFP_KERNEL); > + init.name = clk_name; > init.ops = &clk_divider_ops; > init.flags = CLK_SET_RATE_PARENT; > clk_div_parents[0] = __clk_get_name(host->mux_clk);
Am 15.02.2017 um 20:30 schrieb Kevin Hilman: > Heiner Kallweit <hkallweit1@gmail.com> writes: > >> MMC core does a deep copy of init.name, therefore it's fully ok to > > I assume you mean the clock framework, not the MMC core, right? > Uups, of course. >> provide a local variable. >> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > > With the changelog fixed, > > Acked-by: Kevin Hilman <khilman@baylibre.com> > >> --- >> drivers/mmc/host/meson-gx-mmc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c >> index 39904fb5..806554b1 100644 >> --- a/drivers/mmc/host/meson-gx-mmc.c >> +++ b/drivers/mmc/host/meson-gx-mmc.c >> @@ -276,7 +276,7 @@ static int meson_mmc_clk_init(struct meson_host *host) >> >> /* create the divider */ >> snprintf(clk_name, sizeof(clk_name), "%s#div", dev_name(host->dev)); >> - init.name = devm_kstrdup(host->dev, clk_name, GFP_KERNEL); >> + init.name = clk_name; >> init.ops = &clk_divider_ops; >> init.flags = CLK_SET_RATE_PARENT; >> clk_div_parents[0] = __clk_get_name(host->mux_clk); >
diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index 39904fb5..806554b1 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -276,7 +276,7 @@ static int meson_mmc_clk_init(struct meson_host *host) /* create the divider */ snprintf(clk_name, sizeof(clk_name), "%s#div", dev_name(host->dev)); - init.name = devm_kstrdup(host->dev, clk_name, GFP_KERNEL); + init.name = clk_name; init.ops = &clk_divider_ops; init.flags = CLK_SET_RATE_PARENT; clk_div_parents[0] = __clk_get_name(host->mux_clk);
MMC core does a deep copy of init.name, therefore it's fully ok to provide a local variable. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/mmc/host/meson-gx-mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)