Message ID | 134dd04e-3a27-2fef-8882-61dfc509eb7c@gmail.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show
Return-Path: <linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 23C0D6019C for <patchwork-linux-amlogic@patchwork.kernel.org>; Wed, 20 Dec 2017 19:13:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 15820283C9 for <patchwork-linux-amlogic@patchwork.kernel.org>; Wed, 20 Dec 2017 19:13:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0A3EA28A3E; Wed, 20 Dec 2017 19:13:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 897A8283C9 for <patchwork-linux-amlogic@patchwork.kernel.org>; Wed, 20 Dec 2017 19:13:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=boHf5YCPwJNt8noKnOaNIQWg41FFAR06tL8mVRTiI6E=; b=dKza+q0zh7ieVGqd8F/LdIUnw7 28hvta8uZ2M/uoKVqrmZfxhpGsFQ24zb/cgGcoSYf3jlPqQb7LfzJrHr5MlRuXmbx1YW680fX80VJ 1ICBUtWj1DUFZC4hFL+CXznzqoYednbT+KjXudnPwRUmx9izGzqqo4GVUL7vtaisFZIPfIb0qXCYS MBvmqBglsO/KTC1MebsR4LIeC+9KFfD/OPu4xiy2lOpA3rR0G/8EFMZwDcEqEkS+WdonZ4twL2JQm 0Z3RkDveTlbvKVaSsCK5T3NWrC8cmzq0u+9k/p8FxTLuSN3/oS3J58vIpEhxG/eK+kST5xFiML86i 5hDza3ag==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eRjo9-0006cu-J0; Wed, 20 Dec 2017 19:13:37 +0000 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eRjn2-00061R-8E for linux-amlogic@lists.infradead.org; Wed, 20 Dec 2017 19:13:34 +0000 Received: by mail-wm0-x241.google.com with SMTP id n138so11837048wmg.2 for <linux-amlogic@lists.infradead.org>; Wed, 20 Dec 2017 11:12:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=WmfRopZW3u9lznt1PPEs/9+yi3dRzcfkrrfdJoN5a8s=; b=LLatCKxgq27OVUtwIDYxNXtLuO4+0DoHt5Ehdk3s4TrfBgpvA9hHkEpVrylgdJ4qhZ aFBS3TVMnTUWhji5oQcIlGJptP/PkTmaH3+9x3UI/bVjlM1EqBng2uVYpnzQ9laBdP7E RivCRI3Cm4eIuT62vZ/lATtCEm1tfneCTpLu+QgU0g9iNj61f34DhQ4l2i+gLV4JrRbv BxbVXFmM8N9Q0u4Ks0Nxnsla5h0cPLf3cPW1bDcgaIUjFV7wHJ+Ir6ZDtemTnIfbBOX2 nAiUGmcfO3CZWdXVEnNurxyMcBsF10LiFyRBzpDeiLfVkyaAmgYzmBlij7gUsw6JRGiX dZsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=WmfRopZW3u9lznt1PPEs/9+yi3dRzcfkrrfdJoN5a8s=; b=Cm423sobhZZBh/Pbs6vpDn5O5DB5RmFf5fRXT1Gpsq/3rJH+gSfpsuOnanlUY2T/FO cdmeENjDxW2SLbxUPbrONSkHluwlphaeIO2DbED4jpgiUCMKQYg9AkVeRTcwZxmHayc5 5RQm5ZkyTowOq4FxgeAAUMjEwOFCMsohNQAhQ8iTXuSaQ9bumVJ08GgpIKNyJMyPe7i/ 4UXqA/5Dm9gReiXJpQnVoH/Q3GfVMICK/KsERXnbODqo6UQ6lLbEk/t6T8C2FnlV6xtS 1gIxJHBxMRqNAlTtuvtJy6VWvEp7ViBohXVQ+Ci/5zFjdaIRXmVqAApDa6vKp0Enmy/f 9vaQ== X-Gm-Message-State: AKGB3mIQR0f1zYvHG3uz3WLT3aRD1ZYb7h+FP4lyJTv2mQ35hK+ZVqAo Arv0IHBK+aH1p9R0lFgstfhBgg== X-Google-Smtp-Source: ACJfBotewI0f9P7mxullWzyMHZlRObvQP/zEKPqMHwuurujR7Lp0r6oR5LzG1bZVERsaCD6CwQTQgA== X-Received: by 10.80.172.226 with SMTP id x89mr7045772edc.43.1513797135785; Wed, 20 Dec 2017 11:12:15 -0800 (PST) Received: from ?IPv6:2003:ea:8bc0:e400:cdae:123d:74a:4b36? (p200300EA8BC0E400CDAE123D074A4B36.dip0.t-ipconnect.de. [2003:ea:8bc0:e400:cdae:123d:74a:4b36]) by smtp.googlemail.com with ESMTPSA id k42sm15461162edb.94.2017.12.20.11.12.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Dec 2017 11:12:15 -0800 (PST) Subject: [PATCH 2/2] soc: amlogic: meson-gx-pwrc-vpu: From: Heiner Kallweit <hkallweit1@gmail.com> To: Neil Armstrong <narmstrong@baylibre.com>, Kevin Hilman <khilman@baylibre.com>, "open list:ARM/Amlogic Meson..." <linux-amlogic@lists.infradead.org> References: <943d2b32-86ad-d1d5-b798-12c3ae54a0fe@gmail.com> Message-ID: <134dd04e-3a27-2fef-8882-61dfc509eb7c@gmail.com> Date: Wed, 20 Dec 2017 20:11:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <943d2b32-86ad-d1d5-b798-12c3ae54a0fe@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171220_111229_103660_15953D37 X-CRM114-Status: UNSURE ( 9.19 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <linux-amlogic.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-amlogic>, <mailto:linux-amlogic-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-amlogic/> List-Post: <mailto:linux-amlogic@lists.infradead.org> List-Help: <mailto:linux-amlogic-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-amlogic>, <mailto:linux-amlogic-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" <linux-amlogic-bounces@lists.infradead.org> Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c index 3adb2f2ec..6289965c4 100644 --- a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c +++ b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c @@ -225,7 +225,11 @@ static int meson_gx_pwrc_vpu_probe(struct platform_device *pdev) static void meson_gx_pwrc_vpu_shutdown(struct platform_device *pdev) { - meson_gx_pwrc_vpu_power_off(&vpu_hdmi_pd.genpd); + bool powered_off; + + powered_off = meson_gx_pwrc_vpu_get_power(&vpu_hdmi_pd); + if (!powered_off) + meson_gx_pwrc_vpu_power_off(&vpu_hdmi_pd.genpd); } static const struct of_device_id meson_gx_pwrc_vpu_match_table[] = {
When operating the system headless headless, the domain is never powered on, leaving the clocks disabled. The shutdown function then tries to disable the already disabled clocks, resulting in errors. Therefore call meson_gx_pwrc_vpu_power_off() only if domain is powered on. This patch fixes the described issue on my system (Odorid-C2). Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/soc/amlogic/meson-gx-pwrc-vpu.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)