From patchwork Tue Nov 29 07:44:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Gross X-Patchwork-Id: 9451151 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 26F286074E for ; Tue, 29 Nov 2016 07:46:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 192A927DA4 for ; Tue, 29 Nov 2016 07:46:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0DBFF27E3E; Tue, 29 Nov 2016 07:46:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B893627DA4 for ; Tue, 29 Nov 2016 07:46:03 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1cBd6z-0001WP-G2; Tue, 29 Nov 2016 07:45:57 +0000 Received: from mail-pg0-x22e.google.com ([2607:f8b0:400e:c05::22e]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1cBd64-0008B0-0N for linux-amlogic@lists.infradead.org; Tue, 29 Nov 2016 07:45:06 +0000 Received: by mail-pg0-x22e.google.com with SMTP id f188so66492168pgc.3 for ; Mon, 28 Nov 2016 23:44:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=aDjRvH81O1qki/hlAg1pkL7ZUcbrwjEqsXNRuawlYY8=; b=Zp0tJ39NTWb4DHwWJQxLq4QZmuCw1znq8jArm3KMGV8yQq9Dox4OHT1l3tgfjHCyZ6 XqVYmRd5alhuQYqA57Uqr051PXf83TvQEQ+UEdUrTX1Ad2TmZCGPsAxt47a6dN3eFVlu N9KhFjLkbJUsY2G6QgCCk9GoTOt1b0bn8JEsA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=aDjRvH81O1qki/hlAg1pkL7ZUcbrwjEqsXNRuawlYY8=; b=m02krK7xZ+p7zwgMNHLrSX2AB+gbEUpngA9Ar0t73WBu30auWb6z/6H1aPfBhrS3EJ l/c+Qs5vwgcRMtAczN09CTp0DxSAlw6jaHe4dY1/Hc4zpGWO3pp4ZoqHTsl178EQnC+g 3trAiO6AyvdDBkpTxCdDk8pZVU0SymD929M5eYfznHEA51e/JqMfR2O8rTdMbb7M1H1K DhdBldVASpmonhl2EvbFdQ85TDe4x0jMXS09FNwgsy9V5MbOjC+GroybvQoVWBtWwDWU +AHYDqlm0JFeHhvxmP5gRLHI50N4Q8Aw6oyV4R2N+R93ZodGYXaIiq9wqxdgdu26NLDs m6Yg== X-Gm-Message-State: AKaTC02dWrW8AvlsPbNvkCH0NIX9g+5ogqM3kjbXHyp0oc9Wouqqv3I/jRMS4+xyA2+z/18I X-Received: by 10.98.36.195 with SMTP id k64mr26351988pfk.126.1480405478171; Mon, 28 Nov 2016 23:44:38 -0800 (PST) Received: from localhost ([2602:306:3406:6500:11f8:cb28:d1cc:a9a5]) by smtp.gmail.com with ESMTPSA id n25sm92444050pfi.33.2016.11.28.23.44.37 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 28 Nov 2016 23:44:37 -0800 (PST) From: Andy Gross To: linux-kernel@vger.kernel.org Subject: [PATCH 2/2] firmware: qcom: scm: Fix interrupted SCM calls Date: Tue, 29 Nov 2016 01:44:23 -0600 Message-Id: <1480405463-23165-3-git-send-email-andy.gross@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1480405463-23165-1-git-send-email-andy.gross@linaro.org> References: <1480405463-23165-1-git-send-email-andy.gross@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161128_234500_340666_98C1A597 X-CRM114-Status: GOOD ( 14.66 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jesper.nilsson@axis.com, lorenzo.pieralisi@arm.com, heiko@sntech.de, linux-rockchip@lists.infradead.org, linux-arm-msm@vger.kernel.org, will.deacon@arm.com, linux@armlinux.org.uk, Bjorn Andersson , matthias.bgg@gmail.com, Srinivas Kandagatla , lars.persson@axis.com, p.zabel@pengutronix.de, niklas.cassel@axis.com, ck.hu@mediatek.com, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, Andy Gross , Kevin Hilman , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This patch adds a Qualcomm specific quirk to the arm_smccc_smc call. On Qualcomm ARM64 platforms, the SMC call can return before it has completed. If this occurs, the call can be restarted, but it requires using the returned session ID value from the interrupted SMC call. The quirk stores off the session ID from the interrupted call in the quirk structure so that it can be used by the caller. This patch folds in a fix given by Sricharan R: https://lkml.org/lkml/2016/9/28/272 Signed-off-by: Andy Gross Acked-by: Will Deacon --- arch/arm64/kernel/smccc-call.S | 9 ++++++++- drivers/firmware/qcom_scm-64.c | 11 +++++++++-- include/linux/arm-smccc.h | 11 ++++++++--- 3 files changed, 25 insertions(+), 6 deletions(-) diff --git a/arch/arm64/kernel/smccc-call.S b/arch/arm64/kernel/smccc-call.S index 7b0b3f6..8191fde 100644 --- a/arch/arm64/kernel/smccc-call.S +++ b/arch/arm64/kernel/smccc-call.S @@ -12,6 +12,7 @@ * */ #include +#include #include .macro SMCCC instr @@ -20,7 +21,13 @@ ldr x4, [sp] stp x0, x1, [x4, #ARM_SMCCC_RES_X0_OFFS] stp x2, x3, [x4, #ARM_SMCCC_RES_X2_OFFS] - ret + ldr x4, [sp, #8] + cbz x4, 1f /* no quirk structure */ + ldr x9, [x4, #ARM_SMCCC_QUIRK_ID_OFFS] + cmp x9, #ARM_SMCCC_QUIRK_QCOM_A6 + b.ne 1f + str x6, [x4, ARM_SMCCC_QUIRK_STATE_OFFS] +1: ret .cfi_endproc .endm diff --git a/drivers/firmware/qcom_scm-64.c b/drivers/firmware/qcom_scm-64.c index d164a9b..6e997a6 100644 --- a/drivers/firmware/qcom_scm-64.c +++ b/drivers/firmware/qcom_scm-64.c @@ -91,6 +91,7 @@ static int qcom_scm_call(struct device *dev, u32 svc_id, u32 cmd_id, dma_addr_t args_phys = 0; void *args_virt = NULL; size_t alloc_len; + struct arm_smccc_quirk quirk = {.id = ARM_SMCCC_QUIRK_QCOM_A6}; if (unlikely(arglen > N_REGISTER_ARGS)) { alloc_len = N_EXT_QCOM_SCM_ARGS * sizeof(u64); @@ -131,10 +132,16 @@ static int qcom_scm_call(struct device *dev, u32 svc_id, u32 cmd_id, qcom_smccc_convention, ARM_SMCCC_OWNER_SIP, fn_id); + quirk.state.a6 = 0; + do { arm_smccc_smc(cmd, desc->arginfo, desc->args[0], - desc->args[1], desc->args[2], x5, 0, 0, - res, NULL); + desc->args[1], desc->args[2], x5, + quirk.state.a6, 0, res, &quirk); + + if (res->a0 == QCOM_SCM_INTERRUPTED) + cmd = res->a0; + } while (res->a0 == QCOM_SCM_INTERRUPTED); mutex_unlock(&qcom_scm_lock); diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h index 74231b4c..0a239a0 100644 --- a/include/linux/arm-smccc.h +++ b/include/linux/arm-smccc.h @@ -14,9 +14,6 @@ #ifndef __LINUX_ARM_SMCCC_H #define __LINUX_ARM_SMCCC_H -#include -#include - /* * This file provides common defines for ARM SMC Calling Convention as * specified in @@ -60,6 +57,13 @@ #define ARM_SMCCC_OWNER_TRUSTED_OS 50 #define ARM_SMCCC_OWNER_TRUSTED_OS_END 63 +#define ARM_SMCCC_QUIRK_NONE 0 +#define ARM_SMCCC_QUIRK_QCOM_A6 1 /* Save/restore register a6 */ + +#ifndef __ASSEMBLY__ + +#include +#include /** * struct arm_smccc_res - Result from SMC/HVC call * @a0-a3 result values from registers 0 to 3 @@ -115,4 +119,5 @@ asmlinkage void arm_smccc_hvc(unsigned long a0, unsigned long a1, unsigned long a5, unsigned long a6, unsigned long a7, struct arm_smccc_res *res); +#endif /*__ASSEMBLY__*/ #endif /*__LINUX_ARM_SMCCC_H*/