| Message ID | 1495614042-2676-2-git-send-email-narmstrong@baylibre.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, 2017-05-24 at 10:20 +0200, Neil Armstrong wrote: > The AO I2S pins were incorrectly defined with the EE pin offset. Thx for catching this! Reviewed-by: Jerome Brunet <jbrunet@baylibre.com> > > Cc: Jerome Brunet <jbrunet@baylibre.com> > Fixes: 2899adf0422 ("pinctrl: meson: gxl: add i2s output pins") > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > --- > drivers/pinctrl/meson/pinctrl-meson-gxl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxl.c > b/drivers/pinctrl/meson/pinctrl-meson-gxl.c > index 719ff1b..9af8e6a 100644 > --- a/drivers/pinctrl/meson/pinctrl-meson-gxl.c > +++ b/drivers/pinctrl/meson/pinctrl-meson-gxl.c > @@ -276,8 +276,8 @@ > static const unsigned int pwm_ao_b_pins[] = { PIN(GPIOAO_9, 0) }; > static const unsigned int pwm_ao_b_6_pins[] = { PIN(GPIOAO_6, 0) }; > > -static const unsigned int i2s_out_ch23_ao_pins[] = { PIN(GPIOAO_8, EE_OFF) }; > -static const unsigned int i2s_out_ch45_ao_pins[] = { PIN(GPIOAO_9, EE_OFF) }; > +static const unsigned int i2s_out_ch23_ao_pins[] = { PIN(GPIOAO_8, 0) }; > +static const unsigned int i2s_out_ch45_ao_pins[] = { PIN(GPIOAO_9, 0) }; > > static const unsigned int spdif_out_ao_6_pins[] = { PIN(GPIOAO_6, > EE_OFF) }; > static const unsigned int spdif_out_ao_9_pins[] = { PIN(GPIOAO_9, > EE_OFF) };
On Wed, May 24, 2017 at 10:20 AM, Neil Armstrong <narmstrong@baylibre.com> wrote: > The AO I2S pins were incorrectly defined with the EE pin offset. > > Cc: Jerome Brunet <jbrunet@baylibre.com> > Fixes: 2899adf0422 ("pinctrl: meson: gxl: add i2s output pins") > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> Patch applied with Jerome's review tag. Yours, Linus Walleij
diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxl.c b/drivers/pinctrl/meson/pinctrl-meson-gxl.c index 719ff1b..9af8e6a 100644 --- a/drivers/pinctrl/meson/pinctrl-meson-gxl.c +++ b/drivers/pinctrl/meson/pinctrl-meson-gxl.c @@ -276,8 +276,8 @@ static const unsigned int pwm_ao_b_pins[] = { PIN(GPIOAO_9, 0) }; static const unsigned int pwm_ao_b_6_pins[] = { PIN(GPIOAO_6, 0) }; -static const unsigned int i2s_out_ch23_ao_pins[] = { PIN(GPIOAO_8, EE_OFF) }; -static const unsigned int i2s_out_ch45_ao_pins[] = { PIN(GPIOAO_9, EE_OFF) }; +static const unsigned int i2s_out_ch23_ao_pins[] = { PIN(GPIOAO_8, 0) }; +static const unsigned int i2s_out_ch45_ao_pins[] = { PIN(GPIOAO_9, 0) }; static const unsigned int spdif_out_ao_6_pins[] = { PIN(GPIOAO_6, EE_OFF) }; static const unsigned int spdif_out_ao_9_pins[] = { PIN(GPIOAO_9, EE_OFF) };
The AO I2S pins were incorrectly defined with the EE pin offset. Cc: Jerome Brunet <jbrunet@baylibre.com> Fixes: 2899adf0422 ("pinctrl: meson: gxl: add i2s output pins") Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- drivers/pinctrl/meson/pinctrl-meson-gxl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)