From patchwork Tue Dec 5 22:16:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 10093869 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BDC436056E for ; Tue, 5 Dec 2017 22:18:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AE298289BC for ; Tue, 5 Dec 2017 22:18:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A169929460; Tue, 5 Dec 2017 22:18:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 66417289BC for ; Tue, 5 Dec 2017 22:18:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:Subject:From:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VSC18OX9eJ8hwzofHT9IM5xfuGDSGwi2EWkJy7F83sM=; b=Sz+3ohsHLakXeV fVZ4LvcvrCb/G0FJPUCS9OHPhMeDGrerNfjAINfIDiwUHamkKBmytm8F9aHRNA4kU6pViTtia5nev eKX2ZGLmsOwWAQspINm5HOJsxIHYJp8Zw3hPxsldUKHmB+Rejv9nzC02VHf9b9KlljVnKxMyCyJrs kOtI1B6gU87hS5aMfiNKpdUSLOY8nfcwZ2qND9wf3xh8EpZ7l8Vhwdv9PVU6Ru4jawaoC0Vwmk9Tb XGtVri1jjtShOZNIlvicVx3JBNtVwVIlVfa2d/H/ipeSPWG2OWo9iPwckLvHCUppHNydKypcXqMBZ kIadW5WTy1KVSwV3xSiA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eMLXD-00071c-Dp; Tue, 05 Dec 2017 22:17:51 +0000 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eMLXB-0006zN-07; Tue, 05 Dec 2017 22:17:50 +0000 Received: by mail-wm0-x243.google.com with SMTP id 64so3945608wme.3; Tue, 05 Dec 2017 14:17:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=BERhXPrTN5avkGoL1jy7ht/H0wJLO4sLV0FT7ooelPc=; b=RC6czdMO+8iNMsYDBgxSA/wi/S6qRq1+Z0ZqzHACmN5PgzmllvzrAYgBRYNXsrXSlv dSCq4scXlH7kyha29EkKGUd8/bir31nqyDxkDsLN18tmkIuYWHcK6HwrjyvTWHMsbIDM xvSsEVxiKNLXQ5Dgn8NOzKGHm4nOGSpr4IM5JagtZFTLIeQlpjhoL5AWFTKSVih8BCU4 B7rAIM7qSjoKpHfVbdSNAqoH+09xNNbaA/EWfIHDERh/vkx+OyZwJZiMaozLziA+lkLn 6YM60owl7/PiWonf7znjBziZQJ8ChSYvOizctDd6riP3ROwhRI4VQq1bXs6xgIvprBeF UZSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=BERhXPrTN5avkGoL1jy7ht/H0wJLO4sLV0FT7ooelPc=; b=MfXCjjXekXnZxhkrUl8Mdu/LX/GQZcV/j2Uirfbv6RYmusU9hHJg6Z6kcOZi4Gl2Bt wJXlcNs9eOq1Df8C/h69YQ8sv4/WDT8q56XS0jyqtDOO/jj/2w9/k59UB5iPVaCIqLbs 7IE9+eyKQZB1HDT4O8eFt9UOgGCMZE8Mj3WkR2RbQ/ChDEi5ZALi+N2AxmBZ69vpjhoI xaBjCBepmE+8jKGuE3gsohRjwx6MClDPBZD/d6mjsBZ8Pkii6Ks+M5K/UD7vO1/V+4rg CY/W5Mti5+kRiJqb+RJg02bxdSPJc/tvceiiprJcFVsm+tH7ra2V7BPbLEMNmRdSmMLO FH4A== X-Gm-Message-State: AKGB3mKgw57W32lbEvSkZGuHha1s/XqxjHM9s9o4LAjkpchV+ATnnimN hFQJoA4neh9DTvjiX1jCcMY= X-Google-Smtp-Source: AGs4zMZmQU8L95Q7gbqM37JLoixwB9z3cYBXY/19HvKXi4osL+s/j4EdsfIvAnNIs9ZxRb+MpdOElQ== X-Received: by 10.28.158.206 with SMTP id h197mr6749388wme.23.1512512246147; Tue, 05 Dec 2017 14:17:26 -0800 (PST) Received: from ?IPv6:2003:ea:8bc0:e400:b595:9d9d:56de:88e3? (p200300EA8BC0E400B5959D9D56DE88E3.dip0.t-ipconnect.de. [2003:ea:8bc0:e400:b595:9d9d:56de:88e3]) by smtp.googlemail.com with ESMTPSA id r15sm1150871wrc.36.2017.12.05.14.17.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Dec 2017 14:17:25 -0800 (PST) From: Heiner Kallweit Subject: [PATCH 01/12] firmware: arm_scpi: remove two unneeded devm_kfree's in scpi_remove To: Sudeep Holla References: <99220c79-8b35-2978-11d1-6d101ccb6772@gmail.com> Message-ID: <14a7fdfe-a854-0fe7-bf4b-f7e62a001c2e@gmail.com> Date: Tue, 5 Dec 2017 23:16:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <99220c79-8b35-2978-11d1-6d101ccb6772@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171205_141749_237948_708DAC62 X-CRM114-Status: UNSURE ( 8.41 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:ARM/Amlogic Meson..." , "linux-arm-kernel@lists.infradead.org" , Kevin Hilman Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Both memory areas are free'd anyway when the device is destroyed, so we don't have to do it manually. Signed-off-by: Heiner Kallweit --- drivers/firmware/arm_scpi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c index 7da9f1b8..2a30d255 100644 --- a/drivers/firmware/arm_scpi.c +++ b/drivers/firmware/arm_scpi.c @@ -918,8 +918,6 @@ static int scpi_remove(struct platform_device *pdev) kfree(info->dvfs[i]->opps); kfree(info->dvfs[i]); } - devm_kfree(dev, info->channels); - devm_kfree(dev, info); return 0; }