| Message ID | 1505822748-23431-2-git-send-email-narmstrong@baylibre.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Tue, 2017-09-19 at 14:05 +0200, Neil Armstrong wrote: > The Tronsmart Vega S96 is a TV box derived from Amlogic q200 reference design. > > Cc: support@tronsmart.com > Signed-off-by: Oleg <balbes-150@yandex.ru> Does Oleg have a surname ? :) > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > --- > arch/arm64/boot/dts/amlogic/Makefile | 1 + > arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts | 39 > ++++++++++++++++++++++ > 2 files changed, 40 insertions(+) > create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts > > diff --git a/arch/arm64/boot/dts/amlogic/Makefile > b/arch/arm64/boot/dts/amlogic/Makefile > index 7a9f48c..a6c4a06 100644 > --- a/arch/arm64/boot/dts/amlogic/Makefile > +++ b/arch/arm64/boot/dts/amlogic/Makefile > @@ -19,6 +19,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q200.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q201.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-rbox-pro.dtb > +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-vega-s96.dtb > > always := $(dtb-y) > subdir-y := $(dts-dirs) > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts > b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts > new file mode 100644 > index 0000000..ba74240 > --- /dev/null > +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts > @@ -0,0 +1,39 @@ > +/* > + * Copyright (c) 2017 BayLibre, SAS. > + * Author: Neil Armstrong <narmstrong@baylibre.com> > + * Copyright (c) 2017 Oleg <balbes-150@yandex.ru> > + * > + * SPDX-License-Identifier: (GPL-2.0+ OR MIT) > + */ > + > +/dts-v1/; > + > +#include "meson-gxm.dtsi" > +#include "meson-gx-p23x-q20x.dtsi" > + > +/ { > + compatible = "tronsmart,vega-s96", "amlogic,s912", "amlogic,meson- > gxm"; > + model = "Tronsmart Vega S96"; > + > +}; > + > +ðmac { > + pinctrl-0 = <ð_pins>; > + pinctrl-names = "default"; > + > + /* Select external PHY by default */ > + phy-handle = <&external_phy>; > + > + amlogic,tx-delay-ns = <2>; > + > + /* External PHY is in RGMII */ > + phy-mode = "rgmii"; > +}; > + > +&external_mdio { > + external_phy: ethernet-phy@0 { > + compatible = "ethernet-phy-id001c.c916", "ethernet-phy- > ieee802.3-c22"; > + reg = <0>; > + max-speed = <1000>; I don't think this max-speed property is necessary > + }; > +};
Hi Neil, On Tue, Sep 19, 2017 at 2:05 PM, Neil Armstrong <narmstrong@baylibre.com> wrote: > The Tronsmart Vega S96 is a TV box derived from Amlogic q200 reference design. > > Cc: support@tronsmart.com > Signed-off-by: Oleg <balbes-150@yandex.ru> > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > --- > arch/arm64/boot/dts/amlogic/Makefile | 1 + > arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts | 39 ++++++++++++++++++++++ > 2 files changed, 40 insertions(+) > create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts > > diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile > index 7a9f48c..a6c4a06 100644 > --- a/arch/arm64/boot/dts/amlogic/Makefile > +++ b/arch/arm64/boot/dts/amlogic/Makefile > @@ -19,6 +19,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q200.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q201.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-rbox-pro.dtb > +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-vega-s96.dtb > > always := $(dtb-y) > subdir-y := $(dts-dirs) > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts > new file mode 100644 > index 0000000..ba74240 > --- /dev/null > +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts > @@ -0,0 +1,39 @@ > +/* > + * Copyright (c) 2017 BayLibre, SAS. > + * Author: Neil Armstrong <narmstrong@baylibre.com> > + * Copyright (c) 2017 Oleg <balbes-150@yandex.ru> > + * > + * SPDX-License-Identifier: (GPL-2.0+ OR MIT) > + */ > + > +/dts-v1/; > + > +#include "meson-gxm.dtsi" > +#include "meson-gx-p23x-q20x.dtsi" > + > +/ { > + compatible = "tronsmart,vega-s96", "amlogic,s912", "amlogic,meson-gxm"; > + model = "Tronsmart Vega S96"; > + > +}; > + > +ðmac { > + pinctrl-0 = <ð_pins>; > + pinctrl-names = "default"; > + > + /* Select external PHY by default */ > + phy-handle = <&external_phy>; > + > + amlogic,tx-delay-ns = <2>; > + > + /* External PHY is in RGMII */ > + phy-mode = "rgmii"; > +}; > + > +&external_mdio { > + external_phy: ethernet-phy@0 { > + compatible = "ethernet-phy-id001c.c916", "ethernet-phy-ieee802.3-c22"; some time ago I thought it was smart to add a compatible string with the PHY ID. this was until I figured out that it should only be done if the PHY reports an invalid ID: [0] that's why most .dts files that I've touched skip the "compatible" property and use a comment like "/* Realtek RTL8211F (0x001cc916) */" instead > + reg = <0>; > + max-speed = <1000>; > + }; > +}; > -- > 1.9.1 > > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic Regards, Martin [0] https://github.com/torvalds/linux/commit/7630ea4bda18df2ee1c64dfdca1724a9cc32f920
> Does Oleg have a surname ? :) Yes, there is Ivanov :) >> + reg = <0>; >> + max-speed = <1000>; > I don't think this max-speed property is necessary > >> + }; >> +}; I will try to test and write the result.
On 09/19/2017 08:12 PM, Oleg wrote: > > >> Does Oleg have a surname ? :) > Yes, there is Ivanov :) Ok, then can I replace the Signed-off-bys with "Signed-off-by: Oleg Ivanov <balbes-150@yandex.ru>" ? > > > >>> + reg = <0>; >>> + max-speed = <1000>; >> I don't think this max-speed property is necessary >> >>> + }; >>> +}; > > I will try to test and write the result. Great, thanks ! Neil
On 09/19/2017 07:51 PM, Martin Blumenstingl wrote: > Hi Neil, > > On Tue, Sep 19, 2017 at 2:05 PM, Neil Armstrong <narmstrong@baylibre.com> wrote: >> The Tronsmart Vega S96 is a TV box derived from Amlogic q200 reference design. >> >> Cc: support@tronsmart.com >> Signed-off-by: Oleg <balbes-150@yandex.ru> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> >> --- >> arch/arm64/boot/dts/amlogic/Makefile | 1 + >> arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts | 39 ++++++++++++++++++++++ >> 2 files changed, 40 insertions(+) >> create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts >> >> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile >> index 7a9f48c..a6c4a06 100644 >> --- a/arch/arm64/boot/dts/amlogic/Makefile >> +++ b/arch/arm64/boot/dts/amlogic/Makefile >> @@ -19,6 +19,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q200.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q201.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-rbox-pro.dtb >> +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-vega-s96.dtb >> >> always := $(dtb-y) >> subdir-y := $(dts-dirs) >> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts >> new file mode 100644 >> index 0000000..ba74240 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts >> @@ -0,0 +1,39 @@ >> +/* >> + * Copyright (c) 2017 BayLibre, SAS. >> + * Author: Neil Armstrong <narmstrong@baylibre.com> >> + * Copyright (c) 2017 Oleg <balbes-150@yandex.ru> >> + * >> + * SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> + */ >> + >> +/dts-v1/; >> + >> +#include "meson-gxm.dtsi" >> +#include "meson-gx-p23x-q20x.dtsi" >> + >> +/ { >> + compatible = "tronsmart,vega-s96", "amlogic,s912", "amlogic,meson-gxm"; >> + model = "Tronsmart Vega S96"; >> + >> +}; >> + >> +ðmac { >> + pinctrl-0 = <ð_pins>; >> + pinctrl-names = "default"; >> + >> + /* Select external PHY by default */ >> + phy-handle = <&external_phy>; >> + >> + amlogic,tx-delay-ns = <2>; >> + >> + /* External PHY is in RGMII */ >> + phy-mode = "rgmii"; >> +}; >> + >> +&external_mdio { >> + external_phy: ethernet-phy@0 { >> + compatible = "ethernet-phy-id001c.c916", "ethernet-phy-ieee802.3-c22"; > some time ago I thought it was smart to add a compatible string with the PHY ID. > this was until I figured out that it should only be done if the PHY > reports an invalid ID: [0] > that's why most .dts files that I've touched skip the "compatible" > property and use a comment like "/* Realtek RTL8211F (0x001cc916) */" > instead Done, thanks ! Neil > >> + reg = <0>; >> + max-speed = <1000>; >> + }; >> +}; >> -- >> 1.9.1 >> >> >> _______________________________________________ >> linux-amlogic mailing list >> linux-amlogic@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-amlogic > > > Regards, > Martin > > > [0] https://github.com/torvalds/linux/commit/7630ea4bda18df2ee1c64dfdca1724a9cc32f920 >
> Ok, then can I replace the Signed-off-bys with "Signed-off-by: Oleg Ivanov <balbes-150@yandex.ru>" ? > Yes, that's right. Thanks for the patch.
>>>> + reg = <0>; >>>> + max-speed = <1000>; >>> I don't think this max-speed property is necessary >>> >>>> + }; >>>> +}; >> I will try to test and write the result. > Great, thanks ! > > Neil I removed two strings and checked on Vega s96, the wired network works fine. +&external_mdio { + external_phy: ethernet-phy@0 { + /* Realtek RTL8211F (0x001cc916) */ + reg = <0>; + }; +};
diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile index 7a9f48c..a6c4a06 100644 --- a/arch/arm64/boot/dts/amlogic/Makefile +++ b/arch/arm64/boot/dts/amlogic/Makefile @@ -19,6 +19,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q200.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q201.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxm-rbox-pro.dtb +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-vega-s96.dtb always := $(dtb-y) subdir-y := $(dts-dirs) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts new file mode 100644 index 0000000..ba74240 --- /dev/null +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dts @@ -0,0 +1,39 @@ +/* + * Copyright (c) 2017 BayLibre, SAS. + * Author: Neil Armstrong <narmstrong@baylibre.com> + * Copyright (c) 2017 Oleg <balbes-150@yandex.ru> + * + * SPDX-License-Identifier: (GPL-2.0+ OR MIT) + */ + +/dts-v1/; + +#include "meson-gxm.dtsi" +#include "meson-gx-p23x-q20x.dtsi" + +/ { + compatible = "tronsmart,vega-s96", "amlogic,s912", "amlogic,meson-gxm"; + model = "Tronsmart Vega S96"; + +}; + +ðmac { + pinctrl-0 = <ð_pins>; + pinctrl-names = "default"; + + /* Select external PHY by default */ + phy-handle = <&external_phy>; + + amlogic,tx-delay-ns = <2>; + + /* External PHY is in RGMII */ + phy-mode = "rgmii"; +}; + +&external_mdio { + external_phy: ethernet-phy@0 { + compatible = "ethernet-phy-id001c.c916", "ethernet-phy-ieee802.3-c22"; + reg = <0>; + max-speed = <1000>; + }; +};