From patchwork Fri Nov 17 20:28:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 10063829 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 47FD86023A for ; Fri, 17 Nov 2017 20:37:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 39EFB2AC9A for ; Fri, 17 Nov 2017 20:37:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2EC602ADB8; Fri, 17 Nov 2017 20:37:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A82352AD93 for ; Fri, 17 Nov 2017 20:37:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=6JHVue9vpmSVHqvNGeTJPg6ppEF5BuwG8pcY4SZSjVk=; b=FW2G/kFAqzcHCbikWw9G2Ao/na PzXn2XqJqh29bRfHkD0W6WSiPK81r+udgftG9fUcVWC0GHwvN+7KktwTWdT2IXFP/bcUcUf4GPabd bFMQ4GpfC0k3R0jFZhWlIaK0RwOASyY5PGYRCtpUIjGoEHC1dcBLVQUiKzIqwizWLzW7Ubr80E9r5 znyA/ZHOd/SdOWugR7f5hq39CkjBIPThyLjbCsFEkNgRUI2vCDgKJ+sHRZHLrpWFYWCG3IWJwbdQN j1hxMGiol6/+VnZFl8vbI340JEV2aIX1lEe0P3IdGmfsaQipd1e7+4yH+OKfpGi1Dzp+W4npeukb6 M6H5LAnQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eFnOV-0006lx-6Z; Fri, 17 Nov 2017 20:37:47 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eFnNT-0005Mv-Vj; Fri, 17 Nov 2017 20:36:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=FvKvxrxr/Wcjxtr4PGEUJBAgXwPDdIv7VTMRo8kDcTA=; b=RLsJUuUmdIK6uggWgYa3NvHZI spSwHIbkDhwCGBce6KakFmEThSwcUE90/zIfoliNjyQRCwO9FWa2FJRatWVke+l6vrYfhlmvIrUcp zD2AI/WcQXSu80mhfIqQt0TXf6H6Re7SbcyUAAmfGEG9xIJoDbCWiJxNUKPLV3bWYvUPSx6yqOpP+ 7LsdaFJkV38aUGSF6XNudZahsAGTOrtGcu15OZFsQM3iVCko8/BtQs7KxuCDnWx6dpnnaP1SuG2L/ HYl1XYXo2CLGd7b22rFCS7TO0bf2qMustQ+u9Y3Sfgoclomo2bBeGXYqqlfToscbydlfNrEnYGIvj ix3sllp+w==; Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]) by casper.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eFnFy-0002xn-Un; Fri, 17 Nov 2017 20:29:04 +0000 Received: by mail-pf0-x243.google.com with SMTP id r62so2722609pfd.5; Fri, 17 Nov 2017 12:28:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FvKvxrxr/Wcjxtr4PGEUJBAgXwPDdIv7VTMRo8kDcTA=; b=F6uUMQraKk3H6UhTilspDG79H3/pqtcFQDUkuNZVSAMeg6rjP5eAFHa8xjpIYFWF1q 2ofAVKrnUASbEn08N8gERFznetZnWrJHkZpkczjpIxG/NZW7ZfZH3Q5mHca+8JoxPhjq krLadhyp+WNW34+VpdZFoBCk6ksfFuYzDe6G3lV9vo5Ot9noH9K4ZkvtmhBd607YvE5i IbyMSAhIhndUFw3VhtGteawo4k8wqHykAgCWjpzIZF4LVYrAzQzxc1xeNCEVbKDMgNFv T6GQBM5yCa3ZZKjd1wQyrhJoPA+enfo7q3OJ4s9cHb4uMNNU3GiV6ojeTcCEe7/He9gj IrPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FvKvxrxr/Wcjxtr4PGEUJBAgXwPDdIv7VTMRo8kDcTA=; b=beoFvF3wx4zWtvzoFYty6nd1b3uBihJuZJ5rv9T7iMvO+N7V0jR4hgP9wDZhjLDhXr 1zxYF/x3Ec1hwFMhv7QDmtYgUz1/7j9LXjYum1hcjc1bhwkY4nqgoSiB+vII57Z0faSs pFoUhu1uxWVV8NafjoEQUH9QS4bh3R+GTuUiVpsnlJEk7s1KDWEGI1JU5gJp278PiH6t UGpwH0/TA5+5upIJcDangW9938mm8hLH+N2S0Dhcc2iJY2x+0QO5U5rRk8TSFSS0ECfw E7vdoO5jQagG2NoQXH63Iv95cp3sastnmh98o1xo/BfsJ07pnBf08mqabDOde9rxJI0g NmBw== X-Gm-Message-State: AJaThX6/RAThvDyj4o4Htc9qoJSpo8v8BWUc9XBFbCOYpvAPUf9iR5hA vLlcl/vphWb5jZTxJVoT3x8= X-Google-Smtp-Source: AGs4zMaFu5iyXo6QYOIq72l6I56FyY9civzp3/uGCLAOsQu25LQxuHH8gydh0MPzcnu+eNtcGTWIsA== X-Received: by 10.99.108.7 with SMTP id h7mr6104924pgc.343.1510950516868; Fri, 17 Nov 2017 12:28:36 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id n72sm9382740pfg.109.2017.11.17.12.28.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Nov 2017 12:28:36 -0800 (PST) From: Arvind Yadav To: ulf.hansson@linaro.org, carlo@caione.org, khilman@baylibre.com, ben-linux@fluff.org, adrian.hunter@intel.com, vireshk@kernel.org, maxime.ripard@free-electrons.com, wens@csie.org Subject: [PATCH 1/6] mmc: meson-gx-mmc: Fix platform_get_irq's error checking Date: Sat, 18 Nov 2017 01:58:17 +0530 Message-Id: <1510950502-22565-2-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1510950502-22565-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1510950502-22565-1-git-send-email-arvind.yadav.cs@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171117_202859_208086_73F2BA33 X-CRM114-Status: GOOD ( 11.60 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav Reviewed-by: Kevin Hilman --- drivers/mmc/host/meson-gx-mmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index e0862d3..d6a0695 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -1208,9 +1208,9 @@ static int meson_mmc_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); - if (!irq) { + if (irq < 0) { dev_err(&pdev->dev, "failed to get interrupt resource.\n"); - ret = -EINVAL; + ret = irq; goto free_host; }