From patchwork Fri Nov 17 20:28:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 10063751 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6390B601D3 for ; Fri, 17 Nov 2017 20:30:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 556E62AD93 for ; Fri, 17 Nov 2017 20:30:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 49E342ADB8; Fri, 17 Nov 2017 20:30:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DE7D12AD93 for ; Fri, 17 Nov 2017 20:30:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Qeqb3ZTlo77d6ez99tIqIZf7vOq6TuaiMng4lKrH5Xs=; b=WlFM4AkJKkGmsHUW2D6MthvGnM UUcGYuBQRTENbTaZ3punmkVxa6pcRgwLmpe9JsnethC/ZlMeEEIVrbWSIwifVQB+FvIJFu50GtYGy dfCd9trHed/6ZXK2zHsVNEUPS0chhtChygGK61EEjzJnRDsNd9/XBWY6iOO6UQ+dxMUbrJLVTIBI7 biFxjqMMdWpp2u/w98HnSraaOPBNekXK3HyZYmPHOyVGIquF1XmdFc/8Kg4YP0jg190UoaMx767bg cUKFoQuvOByWY9i/497jcoOq1A10TYy3yJ6S14g4r/5UuHoGSQ3wXG1bjF2bJmle0uhHEoCSQ1Mo+ bIHYPBOg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eFnHg-0000Sn-9O; Fri, 17 Nov 2017 20:30:44 +0000 Received: from mail-pg0-x241.google.com ([2607:f8b0:400e:c05::241]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eFnGC-00060M-CX; Fri, 17 Nov 2017 20:29:31 +0000 Received: by mail-pg0-x241.google.com with SMTP id 4so2750761pge.1; Fri, 17 Nov 2017 12:28:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=IlQ4Hjr57iiMnlfa87WTqhAOZZeuYyXoUSlaXXwaHjo=; b=XNMSczI0ruGauw3kLW0hVrqtTtYrs+i0ngFMuUT/wY4CnrGuA4N8ZXnt6yr3dmgLYf vN+59459WgJWKQNVlnpH+fkFADMU3rQKjjmM5amHFFGETJUYShb2UOrllzdtLKtbR52h +2gIXi0ugD92FnqYhzzHkBg5oBBluYir7d6tQAw0rM/pGQ4elMIWGaxjZL2adiRDLQIh pb024i8TZv6SxRpeGYz4hQH6jYc4t2FUWQBRAYrngnRzn+H7e+kv26WnoPGrE+fhmhHL ywFLnZvaV1FCWKsiJs9HxBukOkADORHVFof6yM6CzVSjm9wzvYGHrFlT/edyhedctkx4 YbUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=IlQ4Hjr57iiMnlfa87WTqhAOZZeuYyXoUSlaXXwaHjo=; b=TOGPfRvuqjkLnOY8fQXRF8iQpCCtIHR/lqxJSJYa1FEQsqTvm4kvUzThZJdXvwM89W 1ZZyj6yLz11MMa15oxoretV/0cCgD9XUIu/Y8So26A1p3puxRSTKGDKyfOAlEDb8gqzl SQQhK/YzRmzqEKYbOv5fjyjekDx2hdv2qIxOwjtteCL/DplH4E4vB584Z74guhP25bcQ wQmIcpmKKdbuBtoSpcCC40YxPpmRKRZ68USyIA/DBZoEijR8d/WhNeYdgrhUmxUMcNqu Si/B4tnOtSYVW0SfShj6U4A2GOcWWAEfJ3dyV4JWQ4a0w4F8XICT9fygUn/2PLfkSN7c /bKw== X-Gm-Message-State: AJaThX5rXeHC911tq9d5gW+jzyVD13yTaSz93EWsiTcV0Cvj51ziNz/a lw1RbUsRyk/od8diMrZqDz8= X-Google-Smtp-Source: AGs4zMb32GAfYhNZJPz5+0s6rgZxf8+AQ2x2zKNleMjK3oiQXvbZpPgrtZtoUni4x7jB2NPpR5jlAw== X-Received: by 10.99.113.91 with SMTP id b27mr6186366pgn.351.1510950531867; Fri, 17 Nov 2017 12:28:51 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id n72sm9382740pfg.109.2017.11.17.12.28.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Nov 2017 12:28:51 -0800 (PST) From: Arvind Yadav To: ulf.hansson@linaro.org, carlo@caione.org, khilman@baylibre.com, ben-linux@fluff.org, adrian.hunter@intel.com, vireshk@kernel.org, maxime.ripard@free-electrons.com, wens@csie.org Subject: [PATCH 5/6] mmc: sh_mmcif: Handle return value of platform_get_irq Date: Sat, 18 Nov 2017 01:58:21 +0530 Message-Id: <1510950502-22565-6-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1510950502-22565-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1510950502-22565-1-git-send-email-arvind.yadav.cs@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171117_122912_860730_75A64350 X-CRM114-Status: UNSURE ( 8.82 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/mmc/host/sh_mmcif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c index 53fb18b..481f2c4 100644 --- a/drivers/mmc/host/sh_mmcif.c +++ b/drivers/mmc/host/sh_mmcif.c @@ -1405,7 +1405,7 @@ static int sh_mmcif_probe(struct platform_device *pdev) irq[0] = platform_get_irq(pdev, 0); irq[1] = platform_get_irq(pdev, 1); - if (irq[0] < 0) { + if (irq[0] < 0 || irq[1] < 0) { dev_err(dev, "Get irq error\n"); return -ENXIO; }