diff mbox

ARM64: dts: meson: enable passing MAC addr on u-boot environment

Message ID 1516122805-20227-1-git-send-email-jramirez@baylibre.com (mailing list archive)
State Superseded
Headers show

Commit Message

Jorge Ramirez-Ortiz Jan. 16, 2018, 5:13 p.m. UTC 
From: Jorge Ramirez-Ortiz <jramirez@baylibre.org>

With the adequate configuration settings, u-boot will loop through the
list of aliases looking for "ethernetX".

By adding an ethernet alias, u-boot can fixup the local-mac-address
property in the kernel's device tree using a value held in its
environment variable ethaddr.

Signed-off-by: Jorge Ramirez-Ortiz <jramirez@baylibre.org>
---
 arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts | 1 +
 1 file changed, 1 insertion(+)

Comments

Neil Armstrong Jan. 17, 2018, 8:38 a.m. UTC | #1 
Hi Jorge,

On 16/01/2018 18:13, Jorge Ramirez-Ortiz wrote:
> From: Jorge Ramirez-Ortiz <jramirez@baylibre.org>
> 
> With the adequate configuration settings, u-boot will loop through the
> list of aliases looking for "ethernetX".
> 
> By adding an ethernet alias, u-boot can fixup the local-mac-address
> property in the kernel's device tree using a value held in its
> environment variable ethaddr.
> 
> Signed-off-by: Jorge Ramirez-Ortiz <jramirez@baylibre.org>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts
> index 68d2c90..8ed2a98 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts
> @@ -18,6 +18,7 @@
>  
>  	aliases {
>  		serial0 = &uart_AO;
> +		ethernet = &ethmac;

Isn't it ethernet0 instead ?

>  	};
>  
>  	chosen {
> 

It would be great to have this on all boards with ethernet enabled.

Neil
Jorge Ramirez-Ortiz Jan. 17, 2018, 8:44 a.m. UTC | #2 
On 01/17/2018 09:38 AM, Neil Armstrong wrote:
> Hi Jorge,
>
> On 16/01/2018 18:13, Jorge Ramirez-Ortiz wrote:
>> From: Jorge Ramirez-Ortiz <jramirez@baylibre.org>
>>
>> With the adequate configuration settings, u-boot will loop through the
>> list of aliases looking for "ethernetX".
>>
>> By adding an ethernet alias, u-boot can fixup the local-mac-address
>> property in the kernel's device tree using a value held in its
>> environment variable ethaddr.
>>
>> Signed-off-by: Jorge Ramirez-Ortiz <jramirez@baylibre.org>
>> ---
>>   arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts
>> index 68d2c90..8ed2a98 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts
>> @@ -18,6 +18,7 @@
>>   
>>   	aliases {
>>   		serial0 = &uart_AO;
>> +		ethernet = &ethmac;
> Isn't it ethernet0 instead ?

uboot can take both (ethernet or ethernet%i)
I just double checked amlogics uboot and you are right it needs ethernet%i

so will fix


>
>>   	};
>>   
>>   	chosen {
>>
> It would be great to have this on all boards with ethernet enabled.

yes will post a new version shortly


>
> Neil
>
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts
index 68d2c90..8ed2a98 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts
@@ -18,6 +18,7 @@ 
 
 	aliases {
 		serial0 = &uart_AO;
+		ethernet = &ethmac;
 	};
 
 	chosen {