From patchwork Thu Mar 29 13:42:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neil Armstrong X-Patchwork-Id: 10315439 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B05AB6037E for ; Thu, 29 Mar 2018 13:42:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9891428D87 for ; Thu, 29 Mar 2018 13:42:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 96FE7287FA; Thu, 29 Mar 2018 13:42:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E083428FF9 for ; Thu, 29 Mar 2018 13:42:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=wRRPT5yJ7MDX7E1CLrBowpGEnMKIR9wSWx5dDwwCUi4=; b=ONgu3R5Xx9BM6Chi2Mx3RiWvJx MzvRrPH4zjJf5qIyD+xnIHKBy4NNbqFcS/LUMhFk7tV1bmE7C5Ey+XOsQXLFvti6FZtnHUe5kwjaz A65Cs0ZgIxW1ilhV5qkAVdkip8DZB4v/SlgHZhV0MsG+WraQAHJSF6ZhRBtkDhHlv5pCYEyd3TlFq 7l1iwSjIUzuoe2ZZW407Ck4rqW6CQafHL9//ySY00eLQVXcscFt0HvNMxhVJzNzW/9ig2H1e3qxrf dEZYJnfFdbicj1Dld4W4RsJp8pj9LOZgLK24TF8QV5Jr4IUlRSMqbMah6ALhCJr/A3FWMPZs/7KEo cuucjuwQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1f1XpK-0008MW-8I; Thu, 29 Mar 2018 13:42:50 +0000 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f1XpA-0008H4-Gy for linux-amlogic@lists.infradead.org; Thu, 29 Mar 2018 13:42:43 +0000 Received: by mail-wm0-x241.google.com with SMTP id a20so30347601wmd.1 for ; Thu, 29 Mar 2018 06:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=d8WIiRpQcDGuCPc1bp9AhYA/HoyMpudUOI+Ad1hcR2Q=; b=B0pw9VGNnyFR7Dd4lSpR7ncYQN9v5R/KvmWQXSQ7XE10yIN7nuY7ZMs/drJZrnqv8D n+mkoOshkC/CxXFGe5wVCkcNmfVNEEamKYErTaE7lxgHVFH9LmR3fCV2fgdyksQnBQip d4hV+9ft1+qsg8JzGU+eeLruw8K2HEvr2F8EesxoLesoHp2LvrfTYJLkB7rvsX2KbZjT PpjhmWbkK9Z8CUxZb8Q4zHn/iBtO9ogVp7OVKwKwOFfpXajerOUIlyyosx6bezxK7Rdb /+gMORsQAB3I1dhGYPwRV1sHjJU4GXchIs7bI0pB305D8NWeJOZkbrsl8NFopjWdfMjL ui4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=d8WIiRpQcDGuCPc1bp9AhYA/HoyMpudUOI+Ad1hcR2Q=; b=H4DFox82uYXbp/dWL5m9Io+ggWtqRCINYWHUDD7TqGEV6dnZ22ZnMDgtJfPXt+oXYl GG4A1rx2Aycn79B/ls03N9d3nM0ImqKTToo8dBqvjZBQx+7IuJyQ5jKJ3WUdMqhQG+GZ y+cUor94EwcbYKkuFqWP6ai7crjp9tM0PtcFt9DjgZg0PKBfXTB6UwF24OOdzF0tplF4 V2a/Dn0J1y9CQ9zCzflfQI6NpaLxJAnjmwVGWmXcfkxoAM6P03LpfjhLgIT5q7a/OpsD mkgtNqwT2/kxPb2udkp6q4pOOsSjspxs1CjzKkU5Q06/kkWXDOcZv/0JRe2oCKL96jNm f8Fg== X-Gm-Message-State: AElRT7FPu/uftYL3cmTHxkyUkxLrTpjQny4TomruWJc824doPBVekU+W CZLq6YMYgT1eUfwGWVOxDTkPIQ== X-Google-Smtp-Source: AIpwx49X8guWhUhSVv/QgYJ/1NGmGXiilBKa2syl0GaJpODsU8qj3kfoDw1TGvYhKRooXS7DoRlCDg== X-Received: by 10.28.137.147 with SMTP id l141mr5690179wmd.141.1522330948848; Thu, 29 Mar 2018 06:42:28 -0700 (PDT) Received: from bender.home ([2a01:cb1d:4ce:ea00:35c7:f264:355a:6031]) by smtp.gmail.com with ESMTPSA id w74sm1220769wmd.27.2018.03.29.06.42.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 29 Mar 2018 06:42:27 -0700 (PDT) From: Neil Armstrong To: u-boot@lists.denx.de, marex@denx.de, bmeng.cn@gmail.com Subject: [PATCH u-boot 2/3] usb: host: dwc3: Add support for multiple PHYs Date: Thu, 29 Mar 2018 15:42:19 +0200 Message-Id: <1522330940-25062-3-git-send-email-narmstrong@baylibre.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1522330940-25062-1-git-send-email-narmstrong@baylibre.com> References: <1522330940-25062-1-git-send-email-narmstrong@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180329_064240_587293_E822F7BB X-CRM114-Status: GOOD ( 17.62 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, sjg@chromium.org, hs@denx.de, Neil Armstrong MIME-Version: 1.0 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP DWC3 Ips can have more than 1 PHY for USB2 and 1 PHY for USB3, add support for a generic number of PHYs and adapt the code to handle a generic number of PHYs. Signed-off-by: Neil Armstrong --- drivers/usb/host/xhci-dwc3.c | 105 ++++++++++++++++++++++++------------------- 1 file changed, 58 insertions(+), 47 deletions(-) diff --git a/drivers/usb/host/xhci-dwc3.c b/drivers/usb/host/xhci-dwc3.c index 1022dd5..da29162 100644 --- a/drivers/usb/host/xhci-dwc3.c +++ b/drivers/usb/host/xhci-dwc3.c @@ -22,8 +22,8 @@ DECLARE_GLOBAL_DATA_PTR; struct xhci_dwc3_platdata { - struct phy usb_phy; - struct phy usb3_phy; + struct phy *usb_phys; + int num_phys; }; void dwc3_set_mode(struct dwc3 *dwc3_reg, u32 mode) @@ -113,45 +113,74 @@ void dwc3_set_fladj(struct dwc3 *dwc3_reg, u32 val) } #ifdef CONFIG_DM_USB -static int xhci_dwc3_setup_phy(struct udevice *dev, int index, struct phy *phy) +static int xhci_dwc3_setup_phy(struct udevice *dev, int count) { - int ret = 0; + struct xhci_dwc3_platdata *plat = dev_get_platdata(dev); + int i, ret; + + if (!count) + return 0; - ret = generic_phy_get_by_index(dev, index, phy); - if (ret) { - if (ret != -ENOENT) { - pr_err("Failed to get USB PHY for %s\n", dev->name); + plat->usb_phys = devm_kcalloc(dev, count, sizeof(struct phy), + GFP_KERNEL); + if (!plat->usb_phys) + return -ENOMEM; + + for (i = 0; i < count; i++) { + ret = generic_phy_get_by_index(dev, i, &plat->usb_phys[i]); + if (ret && ret != -ENOENT) { + pr_err("Failed to get USB PHY%d for %s\n", + i, dev->name); return ret; } - } else { - ret = generic_phy_init(phy); + + ++plat->num_phys; + } + + for (i = 0; i < plat->num_phys; i++) { + ret = generic_phy_init(&plat->usb_phys[i]); if (ret) { - pr_err("Can't init USB PHY for %s\n", dev->name); - return ret; + pr_err("Can't init USB PHY%d for %s\n", + i, dev->name); + goto phys_err; } - ret = generic_phy_power_on(phy); + } + + for (i = 0; i < plat->num_phys; i++) { + ret = generic_phy_power_on(&plat->usb_phys[i]); if (ret) { - pr_err("Can't power on USB PHY for %s\n", dev->name); - generic_phy_exit(phy); - return ret; + pr_err("Can't power USB PHY%d for %s\n", + i, dev->name); + goto phys_err; } } return 0; + +phys_err: + for (; i >= 0; i--) { + generic_phy_power_off(&plat->usb_phys[i]); + generic_phy_exit(&plat->usb_phys[i]); + } + + return ret; } -static int xhci_dwc3_shutdown_phy(struct phy *phy) +static int xhci_dwc3_shutdown_phy(struct udevice *dev) { - int ret = 0; + struct xhci_dwc3_platdata *plat = dev_get_platdata(dev); + int i, ret; - if (generic_phy_valid(phy)) { - ret = generic_phy_power_off(phy); - if (ret) - return ret; + for (i = 0; i < plat->num_phys; i++) { + if (!generic_phy_valid(&plat->usb_phys[i])) + continue; - ret = generic_phy_exit(phy); - if (ret) - return ret; + ret = generic_phy_power_off(&plat->usb_phys[i]); + ret |= generic_phy_exit(&plat->usb_phys[i]); + if (ret) { + pr_err("Can't shutdown USB PHY%d for %s\n", + i, dev->name); + } } return 0; @@ -159,7 +188,6 @@ static int xhci_dwc3_shutdown_phy(struct phy *phy) static int xhci_dwc3_probe(struct udevice *dev) { - struct xhci_dwc3_platdata *plat = dev_get_platdata(dev); struct xhci_hcor *hcor; struct xhci_hccr *hccr; struct dwc3 *dwc3_reg; @@ -170,18 +198,10 @@ static int xhci_dwc3_probe(struct udevice *dev) hcor = (struct xhci_hcor *)((uintptr_t)hccr + HC_LENGTH(xhci_readl(&(hccr)->cr_capbase))); - ret = xhci_dwc3_setup_phy(dev, 0, &plat->usb_phy); - if (ret) { - pr_err("Failed to setup USB PHY for %s\n", dev->name); - return ret; - } - - ret = xhci_dwc3_setup_phy(dev, 1, &plat->usb3_phy); - if (ret) { - pr_err("Failed to setup USB3 PHY for %s\n", dev->name); - xhci_dwc3_shutdown_phy(&plat->usb_phy); + ret = xhci_dwc3_setup_phy(dev, dev_count_phandle_with_args( + dev, "phys", "#phy-cells")); + if (ret) return ret; - } dwc3_reg = (struct dwc3 *)((char *)(hccr) + DWC3_REG_OFFSET); @@ -199,16 +219,7 @@ static int xhci_dwc3_probe(struct udevice *dev) static int xhci_dwc3_remove(struct udevice *dev) { - struct xhci_dwc3_platdata *plat = dev_get_platdata(dev); - int ret; - - ret = xhci_dwc3_shutdown_phy(&plat->usb_phy); - if (ret) - pr_err("Can't shutdown USB PHY for %s\n", dev->name); - - ret = xhci_dwc3_shutdown_phy(&plat->usb3_phy); - if (ret) - pr_err("Can't shutdown USB3 PHY for %s\n", dev->name); + xhci_dwc3_shutdown_phy(dev); return xhci_deregister(dev); }