Message ID | 1523957431-16612-1-git-send-email-narmstrong@baylibre.com (mailing list archive) |
---|---|
State | Not Applicable |
Headers | show
Return-Path: <linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9181360216 for <patchwork-linux-amlogic@patchwork.kernel.org>; Tue, 17 Apr 2018 09:30:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8573628A2E for <patchwork-linux-amlogic@patchwork.kernel.org>; Tue, 17 Apr 2018 09:30:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 78E3428A32; Tue, 17 Apr 2018 09:30:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 32CBB28A2E for <patchwork-linux-amlogic@patchwork.kernel.org>; Tue, 17 Apr 2018 09:30:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=kCLstx5m03ra5+pVlXcu9oGfFcGu7OXEdfkVnGVl0Vs=; b=T9m 0OIjEpOiDi7vgC8/W/M3IOe/GbZI32pdSX2kD3XwPnxbL/kkMmlO9v2WrleqzKXIErNGShZRhBW2N kkIOqoKShilJWI1jQlIVlPU5jLn7NVB3wHLoJSCH4kCPPccNkye2v0OBOlyM1+eRdY6lSOEq9LTBJ OI0DkBfJbaSqXpjMoPEy4u6jyidxyWvRpFpJ0ydXo8FWIp6nTpV0/TJeWmfPirXtlT+bmebh7xIL8 PNp9m5FnK3LhFF2p10103gpOIezJxtzvYj1JEx/E2ny0ZDu3Yudv/7ep7N2BSWx35TOuBnBe5WzY0 ubNxvKkJCyu4qyfmcXjwJp6l7OXaZcw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1f8Mwl-00063K-Uw; Tue, 17 Apr 2018 09:30:43 +0000 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f8Mwe-0005zu-VN for linux-amlogic@lists.infradead.org; Tue, 17 Apr 2018 09:30:42 +0000 Received: by mail-wr0-x242.google.com with SMTP id z73so33517673wrb.0 for <linux-amlogic@lists.infradead.org>; Tue, 17 Apr 2018 02:30:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=7pI70WFKZmrfApX5m0rEEZfS/ky9FW8EUNh5bZk7Za0=; b=UAA1+VeRFDr69pQ2Gku0dSqXWOCn3SJ+YVW9tHXAfupvuRHgMs8Uc96SbCaRo3xKeS jur3W9DppeX0ieDvXGgHyIA0qqplmUtwGShcN0IREgyq1Oh3R7DVvickrOlu3XzmIMUi edQnwxNLlsfSaqn5JkiN2XMN8CLODhfF8qeU+wIuk7zhY78NilJmzdy2sIyRts+EWfBx VJFV6dH3vFcpepaYBoHdzVAH49WyABZuwBBJ9P+e0IOyI4Pjs5zNoCNVL8pA7okwSN9q dmM088lpiJoKqpCymf+0Yn+IQWaSSWI6f3ge/ZRinSPi7Y+4EKUctV7L9Dn8QMdENomr 8rkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=7pI70WFKZmrfApX5m0rEEZfS/ky9FW8EUNh5bZk7Za0=; b=BQqpCSuadGvMmoHEQ4mteb90VBCtQXq7A+7UyOQki1AJIZe0LtyaEqIIlfJx21Dud6 UVs9UciSkdN6iOpOgCfsHiWJgpuzDuyZtkWY2VqrC9ueLok2flsbyQddyg7Xy69SaDJs AsyYb5xo3RoQaEMVr7qoYWyp4CnRnNMTyvbMj4UPSjdBOrQeRgKJTFV0bn4AhYrIjQ7/ rqGxr3LmvuNoh2qjv0trQHkBVHsiibwVKXMMAHyjoSoSDqA8APoous7YAuuW+cF+3VCO rpt87lJItcWcNJQ6BrerGjW7B0YWUYgJXvXTMykVeaYunVilJwsXKfpJj2wtBU/KllsH 8FwA== X-Gm-Message-State: ALQs6tBU6snkwQSCVUbx//WnYrLNw+cH0pG/Zm4jCNyNR4aTe/hXeyn8 DeAOw2XwI7bXPgzCf5PJey4GQw== X-Google-Smtp-Source: AIpwx4/4WbGQpzea2XC+2njqlWIUYI2oA1GgnN342bZr3Sv+kJ6Dii19Cv1LXCyT2V9WN8f9MOtoxQ== X-Received: by 10.28.134.138 with SMTP id i132mr393678wmd.101.1523957434195; Tue, 17 Apr 2018 02:30:34 -0700 (PDT) Received: from bender.baylibre.local ([90.63.244.31]) by smtp.gmail.com with ESMTPSA id r19sm12932082wrg.8.2018.04.17.02.30.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 17 Apr 2018 02:30:33 -0700 (PDT) From: Neil Armstrong <narmstrong@baylibre.com> To: trini@konsulko.com, u-boot@lists.denx.de Subject: [PATCH] clk: fix clk_get_bulk when phandle error Date: Tue, 17 Apr 2018 11:30:31 +0200 Message-Id: <1523957431-16612-1-git-send-email-narmstrong@baylibre.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180417_023037_079822_3879C913 X-CRM114-Status: GOOD ( 10.69 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <linux-amlogic.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-amlogic>, <mailto:linux-amlogic-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-amlogic/> List-Post: <mailto:linux-amlogic@lists.infradead.org> List-Help: <mailto:linux-amlogic-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-amlogic>, <mailto:linux-amlogic-request@lists.infradead.org?subject=subscribe> Cc: linux-amlogic@lists.infradead.org, Neil Armstrong <narmstrong@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" <linux-amlogic-bounces@lists.infradead.org> Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c index 6e99b3b..53f418b 100644 --- a/drivers/clk/clk-uclass.c +++ b/drivers/clk/clk-uclass.c @@ -111,8 +111,8 @@ int clk_get_bulk(struct udevice *dev, struct clk_bulk *bulk) bulk->count = 0; count = dev_count_phandle_with_args(dev, "clocks", "#clock-cells"); - if (!count) - return 0; + if (count < 1) + return count; bulk->clks = devm_kcalloc(dev, count, sizeof(struct clk), GFP_KERNEL); if (!bulk->clks)
This fixes the Coverity Defect CID 175347 when dev_count_phandle_with_args() returns a negative value. Fixes: a855be87da49 ("clk: Add get/enable/disable/release for a bulk of clocks") Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- drivers/clk/clk-uclass.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)