diff mbox series

arm64: dts: meson-axg-s400: Add chosen and memory nodes

Message ID 1536604395-31925-1-git-send-email-narmstrong@baylibre.com (mailing list archive)
State Accepted
Headers show
Series arm64: dts: meson-axg-s400: Add chosen and memory nodes | expand

Commit Message

Neil Armstrong Sept. 10, 2018, 6:33 p.m. UTC 
Add missing chosen and memory nodes.

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Martin Blumenstingl Sept. 10, 2018, 6:45 p.m. UTC | #1 
On Mon, Sep 10, 2018 at 8:33 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> Add missing chosen and memory nodes.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
out of curiosity:
- does the bootloader add the memory node (meaning that this is just a
cosmetic bit)?
- setting stdout-path is always a good idea, without it you can't use
earlycon (without parameters)

Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Neil Armstrong Sept. 11, 2018, 1:28 p.m. UTC | #2 
Hi Martin,

On 10/09/2018 20:45, Martin Blumenstingl wrote:
> On Mon, Sep 10, 2018 at 8:33 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> Add missing chosen and memory nodes.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> out of curiosity:
> - does the bootloader add the memory node (meaning that this is just a
> cosmetic bit)?

Yes, but it's always better to already have the node so it only change the memory,
otherwise it has to relocate and insert a node in the middle of the dtb.

> - setting stdout-path is always a good idea, without it you can't use
> earlycon (without parameters)
> 
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> 

Thanks,
Neil
Kevin Hilman Sept. 13, 2018, 4:58 a.m. UTC | #3 
Neil Armstrong <narmstrong@baylibre.com> writes:

> Add missing chosen and memory nodes.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

Applied to v4.20/dt64 with Martin's ack.

Thanks,

Kevin
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
index d399078..f0de884 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
@@ -60,6 +60,15 @@ 
 		serial1 = &uart_A;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	memory@0 {
+		device_type = "memory";
+		reg = <0x0 0x0 0x0 0x40000000>;
+	};
+
 	main_12v: regulator-main_12v {
 		compatible = "regulator-fixed";
 		regulator-name = "12V";