| Message ID | 20160828164725.19429-3-martin.blumenstingl@googlemail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Sun, Aug 28, 2016 at 06:47:25PM +0200, Martin Blumenstingl wrote: > uart_a_pins: uart_a { > mux { > groups = "uart_tx_a", You shouldn't use underscores in node names. Use hyphens instead, perhaps. https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1122967.html https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1145633.html
On Sun, Aug 28, 2016 at 9:13 PM, Rask Ingemann Lambertsen <ccc94453@vip.cybercity.dk> wrote: > On Sun, Aug 28, 2016 at 06:47:25PM +0200, Martin Blumenstingl wrote: >> uart_a_pins: uart_a { >> mux { >> groups = "uart_tx_a", > > You shouldn't use underscores in node names. Use hyphens instead, perhaps. > https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1122967.html > https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1145633.html The part which you found there is just the context of my patch, not an actual change. However, basically all of the GXBB .dts files are using underscores in the node names. Do "we" have to change this globally? Regarding my patch: I got a NACK from Neil Armstrong off-list: The SDIO IRQ pin is missing in my series. Regards, Martin
On Sun, Aug 28, 2016 at 6:47 PM, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > This can be passed to the sd_emmc_a controller to which the SDIO module > is connected (when available). > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Please merge this through the ARM SoC tree. Yours, Linus Walleij
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi index e2dae1a..6864523 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi @@ -355,6 +355,18 @@ }; }; + sdio_pins: sdio { + mux { + groups = "sdio_d0", + "sdio_d1", + "sdio_d2", + "sdio_d3", + "sdio_cmd", + "sdio_clk"; + function = "sdio"; + }; + }; + uart_a_pins: uart_a { mux { groups = "uart_tx_a",
This can be passed to the sd_emmc_a controller to which the SDIO module is connected (when available). Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)