From patchwork Mon Jun 12 19:44:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 9782697 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A9567603B5 for ; Mon, 12 Jun 2017 19:45:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9B2CD27F86 for ; Mon, 12 Jun 2017 19:45:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9026F2860D; Mon, 12 Jun 2017 19:45:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 14C5B284EE for ; Mon, 12 Jun 2017 19:45:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=if0kyroqvw+CslO+BGCGBaaLQciXpt3qB/Z2eyzHSp0=; b=Qs6VE/EeofdhyMY1RRhe4LHKfI Yg4Y2bItlG7elR7gWkwt4NlvoLi/VuVebiR+3zCyPjM/trY+775i2ZtiImMlvVWiGXKkdHFh87Wp8 jaZSZj+NYFFq1TqwELQnjUWbP0pTGLYK5wx8uMs3PzIclGSEn/2wkvzTENOXme/Nx7QM65jC6gqLO Ibsy4UxiXbgAEKr3DuSOmBuIPEN6R48bdIIHZ2RStbjrzj4Ze+hAd9NEoreYj39j04sWoD1OLpebe RiSMrEzM3zTcLspRpYKuvSSlbsILE/lRR+kuD7zj5ygUpx+X449hslu9jMGaLrendvC6fw5HVvoWG NylY+8dg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dKVGy-0004g2-C5; Mon, 12 Jun 2017 19:45:12 +0000 Received: from mail-wr0-x229.google.com ([2a00:1450:400c:c0c::229]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dKVGu-0003R8-IQ for linux-amlogic@lists.infradead.org; Mon, 12 Jun 2017 19:45:11 +0000 Received: by mail-wr0-x229.google.com with SMTP id g76so108157590wrd.1 for ; Mon, 12 Jun 2017 12:44:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/raVghqy5m49cnhpvUKyZvvW8DgCOuUQI2LyK2ci9xU=; b=OdqwuSu0EfvC3Yw4oXetSH1zOI8pEYTDIImj7JdDulU8a3IqL0tmDm856wmKthf9O7 uePlhQ1ttmm0hor+V2a4fX/DawTfzvxz/cdFfT2xPIEvM+54FdThnioGCvGyMFavn+Eo o8s2CS67WxazY7/5hwQNS+bWBiSfLvi65YVB9LAp6g0HaBgLw+7zLeYF7/MEmIcBbDVp pk5RrwTx471nk1sHmN3HmnjHwIl5i96eMOqMt2cGaaAeuHhW5EQJlkBAm06kRjYwyCXZ oIlpWkbGWQDS0sRnX1j684RHSwoQvSCJxXv2+iar62RJBWJnCahrQdZVPUwNxgA8EcpE zKmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/raVghqy5m49cnhpvUKyZvvW8DgCOuUQI2LyK2ci9xU=; b=aIveZ3SBOjyosqWgZrI1oBYNk2opskL8tkR5CXZbWNcQ/GJ3cDa5e5nDQu8N7RHz3s vtJbeEnyiq/CZ2aDp6XvHhvUCX9CgQaV6Xi0vwErf8CPIHfOuyJqwiInBgCEVUcAVoUr 04m7lxIbtGR78oZWv5Xz/ea0715WT6JF4cG97uame/oILOgHpsIwpIE+Y9lvRbfU7c+j 6En+rTwbAXpm62cTcllnJnpEYtgCe4R5qYzAlRWSJ32C7m/8idVkdp/Yd15u2/hGOqIo L46XaanzPgSi4KFs8yGgSBa4ZZJGNMXhbqbV8N8G6C55/pf61xduz9gZB3w07FnMZ8Bj JZew== X-Gm-Message-State: AKS2vOyVLnGIBoYsGggid0p278SYhqwb8A/9GQpqb7zrUBzFT1mg+xZB nXQdwXAuko4YrBtC X-Received: by 10.223.134.161 with SMTP id 30mr408231wrx.20.1497296689797; Mon, 12 Jun 2017 12:44:49 -0700 (PDT) Received: from localhost.localdomain (cag06-3-82-243-161-21.fbx.proxad.net. [82.243.161.21]) by smtp.googlemail.com with ESMTPSA id 70sm13250797wmu.28.2017.06.12.12.44.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Jun 2017 12:44:49 -0700 (PDT) From: Jerome Brunet To: Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org Subject: [PATCH v3 03/10] clk: rework calls to round and determine rate callbacks Date: Mon, 12 Jun 2017 21:44:31 +0200 Message-Id: <20170612194438.12298-4-jbrunet@baylibre.com> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170612194438.12298-1-jbrunet@baylibre.com> References: <20170612194438.12298-1-jbrunet@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170612_124508_823771_AD391BA2 X-CRM114-Status: GOOD ( 14.02 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , Kevin Hilman , Linus Walleij , Russell King , linux-amlogic@lists.infradead.org, Jerome Brunet MIME-Version: 1.0 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Rework the way the callbacks round_rate and determine_rate are called. The goal is to do this at a single point and make it easier to add conditions before calling them. This rework is done to ease the integration of "protected" clock functionality. Signed-off-by: Jerome Brunet --- drivers/clk/clk.c | 78 +++++++++++++++++++++++++++++++------------------------ 1 file changed, 44 insertions(+), 34 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index dceaf0ff23db..8cc4672414be 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -833,16 +833,34 @@ static int clk_disable_unused(void) } late_initcall_sync(clk_disable_unused); -static int clk_core_round_rate_nolock(struct clk_core *core, - struct clk_rate_request *req) +static int clk_core_determine_round(struct clk_core *core, + struct clk_rate_request *req) { - struct clk_core *parent; long rate; - lockdep_assert_held(&prepare_lock); + if (core->ops->determine_rate) { + return core->ops->determine_rate(core->hw, req); + } else if (core->ops->round_rate) { + rate = core->ops->round_rate(core->hw, req->rate, + &req->best_parent_rate); + if (rate < 0) + return rate; - if (!core) - return 0; + req->rate = rate; + } else { + return -EINVAL; + } + + return 0; +} + +static void clk_core_init_rate_req(struct clk_core *core, + struct clk_rate_request *req) +{ + struct clk_core *parent; + + if (WARN_ON(!core || !req)) + return; parent = core->parent; if (parent) { @@ -852,22 +870,24 @@ static int clk_core_round_rate_nolock(struct clk_core *core, req->best_parent_hw = NULL; req->best_parent_rate = 0; } +} - if (core->ops->determine_rate) { - return core->ops->determine_rate(core->hw, req); - } else if (core->ops->round_rate) { - rate = core->ops->round_rate(core->hw, req->rate, - &req->best_parent_rate); - if (rate < 0) - return rate; +static int clk_core_round_rate_nolock(struct clk_core *core, + struct clk_rate_request *req) +{ + lockdep_assert_held(&prepare_lock); - req->rate = rate; - } else if (core->flags & CLK_SET_RATE_PARENT) { - return clk_core_round_rate_nolock(parent, req); - } else { - req->rate = core->rate; - } + if (!core) + return 0; + + clk_core_init_rate_req(core, req); + + if (core->ops->determine_rate || core->ops->round_rate) + return clk_core_determine_round(core, req); + else if (core->flags & CLK_SET_RATE_PARENT) + return clk_core_round_rate_nolock(core->parent, req); + req->rate = core->rate; return 0; } @@ -1356,36 +1376,26 @@ static struct clk_core *clk_calc_new_rates(struct clk_core *core, clk_core_get_boundaries(core, &min_rate, &max_rate); /* find the closest rate and parent clk/rate */ - if (core->ops->determine_rate) { + if (core->ops->determine_rate || core->ops->round_rate) { struct clk_rate_request req; req.rate = rate; req.min_rate = min_rate; req.max_rate = max_rate; - if (parent) { - req.best_parent_hw = parent->hw; - req.best_parent_rate = parent->rate; - } else { - req.best_parent_hw = NULL; - req.best_parent_rate = 0; - } - ret = core->ops->determine_rate(core->hw, &req); + clk_core_init_rate_req(core, &req); + + ret = clk_core_determine_round(core, &req); if (ret < 0) return NULL; best_parent_rate = req.best_parent_rate; new_rate = req.rate; parent = req.best_parent_hw ? req.best_parent_hw->core : NULL; - } else if (core->ops->round_rate) { - ret = core->ops->round_rate(core->hw, rate, - &best_parent_rate); - if (ret < 0) - return NULL; - new_rate = ret; if (new_rate < min_rate || new_rate > max_rate) return NULL; + } else if (!parent || !(core->flags & CLK_SET_RATE_PARENT)) { /* pass-through clock without adjustable parent */ core->new_rate = core->rate;