From patchwork Mon Dec 18 09:44:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 10118655 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8D831603FA for ; Mon, 18 Dec 2017 09:47:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7CD2228DC5 for ; Mon, 18 Dec 2017 09:47:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 71C8D28E3C; Mon, 18 Dec 2017 09:47:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1D6BF28DC5 for ; Mon, 18 Dec 2017 09:47:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=AYqRtWw16zDqB7o9WHurEuR82iPJQoSo8GvnnLPxpsE=; b=WV/vldKKZJ2SwHPK1CqMphfacP LKtGsHoi7FTUt+t+dIWrxu/n6a5MVbfv0uyiZzHgLl0pgOadR1umP+XGtU4NiLdIgCSG8jP7d9+T4 WzgAAXQronAKFZz6qoBwT6XFUsRh1Z6dhLfKQqMa7TWoiuOxju0zs8pJEp3e0KvRgZggJTx/4SLFw J6r8+yj4/1hzT7hr66+tWueCU7ArCVZkaeRXzxXNXhmOvyexyOOrzrz5YMucBOmvknuMZKksqrvlj 0TSRSTxa/+YLx/sfdeTbC0omYRg0STRXpRfDV9XrzigNKPTVlLogcQEVydFBJUMpE8k/7RZXD3DDo j0eIYTKA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eQs0t-0007hj-NW; Mon, 18 Dec 2017 09:47:11 +0000 Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eQrz5-0004fl-8N for linux-amlogic@lists.infradead.org; Mon, 18 Dec 2017 09:45:35 +0000 Received: by mail-wr0-x244.google.com with SMTP id f8so2691895wre.4 for ; Mon, 18 Dec 2017 01:44:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GtweTir+f4z1Z60UugjOzgbytYOQ0oWOM6id0Zorle4=; b=lxdsCVMEffPtjoOttRVGck53LkylDmhwDfEidspO/9Tb24brdxUygbrHSodr6ISDvO 1i7CcWKb3F1AgTf4gIWFKrwKQ28kKXNMzREFuTNtqeMgJZfPFUkaH0PXMdGJMUrgbVIF eyGGHKjeL4KKZ2GtesFIN91QsYf44V5QUWRzSadF0HEX/YIrQSRM0U6SUg9GZI7MxIAB YkXx5cvegmfnIlLkcSXQLH/XIh8Y68iyg2zjZa1yoofDjJQXZLyiSh72zQrP52NzB8aD DKdVupQW3FPBy9C9n7k+UsttceTOy/bRH8ORo+fRTEsMUlcCp5mPjvXwMItNNse6SIYm ty+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GtweTir+f4z1Z60UugjOzgbytYOQ0oWOM6id0Zorle4=; b=NfRZcDsjm0aDjWh349RV0A62R5FsQHbkHS2WS7ZQrUsbV9IAT6V3BeWuE6U84BqPV3 Ex91JTqDfyBC9w2As2Q+B7UTDuO8J93XXrulkE9hyCUIQGA+zDnGBiS4DcbSB8sf7ZTy IcTd7NdjqDvbSKp/NcqVeYZn1CzD7c/VWqnLM1aFQWCHDm52ZfLKavX51MxTUHqiNq+4 sX66f9Vgpxl2ePZ1WFWGkZqqLy3j8e5xFrxXdocg1m48GFp4HP57jEYEmogaXahkEXJ1 lhgoj8go3C5MpVTv+8FwJee29cG9siL/mHNhc0ygg1srbXGYU7LF/1RD2vWuceL9kivR W1Iw== X-Gm-Message-State: AKGB3mJidBQjZ66KcGzoQcDuxZDzBKL/JpUxfoXrfGle+NScxDH2vMjK gc+aq5KzW8PZQ15e/zrWJS0DWA== X-Google-Smtp-Source: ACJfBosNbfwFUFJF/FuhqsFCxgIKq0EFAI2efm/K2gteWk3KBHSk/F+icZXFpHXvtviBYVgp/uQ0kg== X-Received: by 10.223.136.56 with SMTP id d53mr5776814wrd.36.1513590297277; Mon, 18 Dec 2017 01:44:57 -0800 (PST) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id p13sm12820783wrc.61.2017.12.18.01.44.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Dec 2017 01:44:56 -0800 (PST) From: Jerome Brunet To: Andrew Lunn , Florian Fainelli Subject: [PATCH net-next v3 5/7] net: phy: meson-gxl: leave CONFIG_A6 untouched Date: Mon, 18 Dec 2017 10:44:44 +0100 Message-Id: <20171218094446.31912-6-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20171218094446.31912-1-jbrunet@baylibre.com> References: <20171218094446.31912-1-jbrunet@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171218_014519_988572_62EEE203 X-CRM114-Status: UNSURE ( 8.87 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Hilman , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet MIME-Version: 1.0 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The PHY performs just as well when left in its default configuration and it makes senses because this poke gets reset just after init. According to the documentation, all registers in the Analog/DSP bank are reset when there is a mode switch from 10BT to 100BT. The bank is also reset on power down and soft reset, so we will never see the value which may have been set by the bootloader. In the end, we have used the default configuration so far and there is no reason to change now. Remove CONFIG_A6 poke to make this clear. Reviewed-by: Andrew Lunn Signed-off-by: Jerome Brunet --- drivers/net/phy/meson-gxl.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c index 0a34656a2086..ddc92424e8de 100644 --- a/drivers/net/phy/meson-gxl.c +++ b/drivers/net/phy/meson-gxl.c @@ -38,9 +38,6 @@ #define BANK_WOL 1 #define BANK_BIST 3 -/* Analog/DSP Registers */ -#define A6_CONFIG_REG 0x17 - /* WOL Registers */ #define LPI_STATUS 0xc #define LPI_STATUS_RSV12 BIT(12) @@ -126,12 +123,6 @@ static int meson_gxl_config_init(struct phy_device *phydev) { int ret; - /* Write CONFIG_A6*/ - ret = meson_gxl_write_reg(phydev, BANK_ANALOG_DSP, A6_CONFIG_REG, - 0x8e0d); - if (ret) - return ret; - /* Enable fractional PLL */ ret = meson_gxl_write_reg(phydev, BANK_BIST, FR_PLL_CONTROL, 0x5); if (ret)