Message ID | 20171228222128.15215-6-martin.blumenstingl@googlemail.com (mailing list archive) |
---|---|
State | Not Applicable |
Headers | show
Return-Path: <linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9473C60388 for <patchwork-linux-amlogic@patchwork.kernel.org>; Thu, 28 Dec 2017 22:22:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 871682D50B for <patchwork-linux-amlogic@patchwork.kernel.org>; Thu, 28 Dec 2017 22:22:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7C0A12D50D; Thu, 28 Dec 2017 22:22:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 839822D52C for <patchwork-linux-amlogic@patchwork.kernel.org>; Thu, 28 Dec 2017 22:22:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=hvhAV34Vi9JkgH/fuBobDsWNjQ1t9lgvNtCsGvDop40=; b=MjHXti8YWw7A7yNJEapm6qh667 IszWOCMJD3yAgw8QI1voEveUn00Al8+O7GEh06zLq+/yKQUuzsSwwxpoQcvxnSwZkV+SEDMChLXyO XIvRhN5E/ThO+bh6lH6D9AgDHBExRGvjyd/Zp1cENmS+uqUmSVn6sbGom6sNdKbHrKWkw6u0rCkEM rfLqxJH7ICbQ3kXCQoZ6ZJHRoX5eF+lKKeFGDdX8sojNMppJL/ZkmaoNaBHFvBuIPHyn/s0nFTeWp zOs2p8+d0FQXYAfqW1f09sWhIrZIrku1RYBKy6ytGU4GD/eWU3V9PgXwJtmPTcefRved8YiwKSqXk BOUVl1dg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eUgYw-0004Vk-8R; Thu, 28 Dec 2017 22:22:06 +0000 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eUgYn-0004RZ-0C for linux-amlogic@lists.infradead.org; Thu, 28 Dec 2017 22:21:59 +0000 Received: by mail-wm0-x242.google.com with SMTP id t8so45878741wmc.3 for <linux-amlogic@lists.infradead.org>; Thu, 28 Dec 2017 14:21:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=mJ41S+mIdQQeqUO4Hj0Zxz5zd9u9TxwYfFsBVJNeasc=; b=b8wDG0PF1jbSbQrEFoIIQ94QQvPXy7V+QlPddOBnTBonTARpLZGezuqi2zpnBL5CH7 7J5Z+2Orw/uWlwQ53dftPK64T547a0CR84rWF/xbZ8nX2aDCDjxQctO4dJpsyO95tux/ jfp7inq7JLYOJL7yVqZ1Ngta5/PIavomUwowljlsuVhoxNhOGuobqB+oA+MnoytZVeMA sG97MEjnNY6MSYGqe5qFxxecJDp+6HkAb3xSrdZkM4WsSqctdcVTUDt3kkH+DAUv8EWr cEe/akx2dIdX2kcD4n1qq0at3Sz1xmQwDTIGQIZy4oNHfNtt4aa130c22wrwZkdBkO9x ZgVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=mJ41S+mIdQQeqUO4Hj0Zxz5zd9u9TxwYfFsBVJNeasc=; b=hQk9VaOOJp5Ly8PktjP4T7vXD9bH56PLuIoTlmrOrwdTKB+iI7VGgB9r+fBvORWixx pABE5t84ZBYTWJMFjkYMSBMaYK6YbFS7zCGtIX5DgYr7zhjdQDCHp+6uqdSBwQqMubCI gNHys21piZif4xiwBMixQdiePgwjhfTs++fCFL0ShyhJ3Rf/HdlpMKOqa9RBZtyyulRW BjusdCKyEOQh5r/t7X+psWJsSLKTy0cjl6r+adNnMXEkhrO87rUeRvgUL+89gImR3LiF Zz4xxoqsPQcH9MtUY43bwFlGZQQJgGt8VwKL7lQGZVpMkax76mh1WdLsNN11NypZ0Plj CqFQ== X-Gm-Message-State: AKGB3mLTATaORcPcTm/Zo6Gux89KmR6aWp+eAfpU0MNyf+tJVkrYXHbz etshxrU5DW7XL1d8r3NGznE= X-Google-Smtp-Source: ACJfBouNo3axtC9CLpyOJi7LwrKZg8L5he9mghTiTt3sqbGCpM8QXMOWfUkU/8sgdyPfGtmG3RM/BQ== X-Received: by 10.28.155.1 with SMTP id d1mr30044601wme.68.1514499710557; Thu, 28 Dec 2017 14:21:50 -0800 (PST) Received: from blackbox.darklights.net (p5DD9B1AC.dip0.t-ipconnect.de. [93.217.177.172]) by smtp.googlemail.com with ESMTPSA id o16sm25843679wmi.29.2017.12.28.14.21.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Dec 2017 14:21:49 -0800 (PST) From: Martin Blumenstingl <martin.blumenstingl@googlemail.com> To: netdev@vger.kernel.org, ingrassia@epigenesys.com Subject: [RFT net-next v3 5/5] net: stmmac: dwmac-meson8b: propagate rate changes to the parent clock Date: Thu, 28 Dec 2017 23:21:28 +0100 Message-Id: <20171228222128.15215-6-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20171228222128.15215-1-martin.blumenstingl@googlemail.com> References: <20171228222128.15215-1-martin.blumenstingl@googlemail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171228_142157_088463_8393EFCF X-CRM114-Status: GOOD ( 10.62 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <linux-amlogic.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-amlogic>, <mailto:linux-amlogic-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-amlogic/> List-Post: <mailto:linux-amlogic@lists.infradead.org> List-Help: <mailto:linux-amlogic-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-amlogic>, <mailto:linux-amlogic-request@lists.infradead.org?subject=subscribe> Cc: linus.luessing@c0d3.blue, narmstrong@baylibre.com, Martin Blumenstingl <martin.blumenstingl@googlemail.com>, khilman@baylibre.com, alexandre.torgue@st.com, linux-amlogic@lists.infradead.org, peppe.cavallaro@st.com, jbrunet@baylibre.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" <linux-amlogic-bounces@lists.infradead.org> Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c index d06106417063..9c3cdfef414a 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c @@ -111,7 +111,7 @@ static int meson8b_init_rgmii_clk(struct meson8b_dwmac *dwmac) init.name = devm_kasprintf(dev, GFP_KERNEL, "%s#m250_sel", dev_name(dev)); init.ops = &clk_mux_ops; - init.flags = 0; + init.flags = CLK_SET_RATE_PARENT; init.parent_names = mux_parent_names; init.num_parents = MUX_CLK_NUM_PARENTS;
On Meson8b the only valid input clock is MPLL2. The bootloader configures that to run at 500002394Hz which cannot be divided evenly down to 25MHz using the m250_div and m25_div clocks. Currently the common clock framework chooses a m250_div of 2 - with the internal fixed "divide by 10" this results in a RGMII clock of 25000120Hz (120Hz above the requested 25MHz). Letting the common clock framework propagate the rate changes up to the parent of m250_mux allows us to get the best possible clock rate. With this patch the common clock framework calculates a rate of very-close-to-250MHz (249999701Hz to be exact) for the MPLL2 clock (which is the mux input). Dividing that by 1 (using m250_div) along with the internal fixed divide-by-10 gives us a RGMII clock of 24999970Hz (which is only 30Hz off the requested 25MHz, compared to 120Hz from u-boot and the vendor driver). SoCs from the Meson GX series are not affected by this change because the input clock is FCLK_DIV2 whose rate cannot be changed (which is fine since it's running at 1GHz, thus it's a multiple of 250MHz). Fixes: 566e8251625304 ("net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC") Suggested-by: Jerome Brunet <jbrunet@baylibre.com> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)