From patchwork Wed Jan 31 18:09:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 10194329 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 64BA360380 for ; Wed, 31 Jan 2018 18:10:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 31B1B28771 for ; Wed, 31 Jan 2018 18:10:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 25F80287A8; Wed, 31 Jan 2018 18:10:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8FAF128771 for ; Wed, 31 Jan 2018 18:10:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=DqB5gmDILVgiHKjnJXb1/dwtIPqJbhh03XbflKpumoo=; b=SnA5cKY6dzy5auFc8pC8qWSUxt qJoWtzk+X1f+rS4fHaT+j+eN4EZ03cLZ2LU1uuurt3KQXjmSgpRGBnHSDbiqm2L38TJVS4sOpw7bv MXR0ygENz45Ns5/gQGtdD45RIo9HSdvAZ6Ffp6zxL0oX/OEeACG3mCuAZHXUBvdrMBiPU7G23/bY1 ZtBc2Hr6ZZEoUFUtzTwlKyq/ZYTlwQVjmJaX+kJ2t0ufcm82UwtAxTnb9M4ehlNjQJgcTNZNWxelv 2TXTOFN6n0YSm3q3Du+5FOixb3CI0yWlE3d8agBWJ49sX6tyM4XOPvN5WPKGkkDht23w2Ro50WE0l DA71MHrA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1egwpv-0001mL-Ju; Wed, 31 Jan 2018 18:10:19 +0000 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1egwpj-0000Kh-OX for linux-amlogic@lists.infradead.org; Wed, 31 Jan 2018 18:10:11 +0000 Received: by mail-wr0-x242.google.com with SMTP id w50so16033628wrc.2 for ; Wed, 31 Jan 2018 10:09:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=XoCwyv3z7MI/oYAqi2dpM7HJlI5GXUwayYtCQqMMLwE=; b=YwFEPemcnVscz36PXu16HOhTSp57QalI1ewgSQ7mCWpSbG8qeNhK2FTHs/hHkLOqfF q9I1ZuSw+wlY/zKJvIIKm8NLnbRJ8akCSUBH1qQZ6P5q+syLergKiGgino8YAV1OOusl 1Uqax4hMw80nb/meahV/LG5ajINZqPTMPHhTd5n/1JjKOjUhJq2BONbP08QDvAIEVW7u 1iC6Jxrx7k+1J5l2nm2mmHd6Cqi9gAnRclWvFVBkgOOSUdNnrkl+uD50+c4fFlGkgoV0 IwG31l9Geqr8UivTgCZAuaEJ78CZUL+huMz/5S43KXB4+EbIvh8fOH12mwc0bU1Vu1kp 723g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=XoCwyv3z7MI/oYAqi2dpM7HJlI5GXUwayYtCQqMMLwE=; b=Xl8xEZWCtKc5zQ7IBKA086AonRTzjyNPTCFvMWbLwh6zi9bGl6n4LB76rllJbKIUbk D7thOhxouh1ZTfrlUlwoIa5BrXvEru17QY680uxeX3yJpWIlrJRqRvG0WGEc6ZutTWnP saZgHQVkBy/7Cp6k1De1pj3wlRgxHqi1UXIsdWIkPy7gU2l9lWT3o6hl3kUQEgtwkx1J oZpFcUsf2uEWMFl/ENF3GfmeJEeF7H/5bovpQUeAIaDZaM/NZydNGUf9Qeov3I2VnQ90 Sx68SfvA5Z8o4TJpATympwP8xmQTcblqoVWdabJIWeDb7AeokJ3VdTxoweD4vzKUrOob YtTg== X-Gm-Message-State: AKwxytdy1EuSw3tL855Q1kJx9z89iwUwtyAEqf57TtaMm4G+e9wW2V+3 xkIldveNctVB6ndDhVYtz+Pmsg== X-Google-Smtp-Source: AH8x227fhbAs0Yq8u4I4nUA3QTTaEU1ISOONVUn4EJPf/hf5y+awwDjhXtMCo621jx/P+o9nNzkHMQ== X-Received: by 10.223.173.119 with SMTP id p110mr16001416wrc.69.1517422193522; Wed, 31 Jan 2018 10:09:53 -0800 (PST) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id f8sm341977wmc.3.2018.01.31.10.09.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 31 Jan 2018 10:09:53 -0800 (PST) From: Jerome Brunet To: Neil Armstrong , Kevin Hilman Subject: [PATCH 04/19] clk: meson: remove obsolete comments Date: Wed, 31 Jan 2018 19:09:30 +0100 Message-Id: <20180131180945.18025-5-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180131180945.18025-1-jbrunet@baylibre.com> References: <20180131180945.18025-1-jbrunet@baylibre.com> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, Carlo Caione , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, Jerome Brunet MIME-Version: 1.0 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Over time things changes in CCF and issues have been fixed in meson controllers. Now, clk81 is decently modeled by read-only PLLs, a mux, a divider and a gate. We can remove the FIXME comments related to clk81. Also remove the comment about devm_clk_hw_register, as there is apparently nothing wrong with it. Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg.c | 5 ----- drivers/clk/meson/gxbb.c | 6 ------ drivers/clk/meson/meson8b.c | 1 - 3 files changed, 12 deletions(-) diff --git a/drivers/clk/meson/axg.c b/drivers/clk/meson/axg.c index 81565b025b70..f84927e76f88 100644 --- a/drivers/clk/meson/axg.c +++ b/drivers/clk/meson/axg.c @@ -411,11 +411,6 @@ static struct meson_clk_mpll axg_mpll3 = { }, }; -/* - * FIXME The legacy composite clocks (e.g. clk81) are both PLL post-dividers - * and should be modeled with their respective PLLs via the forthcoming - * coordinated clock rates feature - */ static u32 mux_table_clk81[] = { 0, 2, 3, 4, 5, 6, 7 }; static const char * const clk81_parent_names[] = { "xtal", "fclk_div7", "mpll1", "mpll2", "fclk_div4", diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c index e6adab49c0ba..6609024eee00 100644 --- a/drivers/clk/meson/gxbb.c +++ b/drivers/clk/meson/gxbb.c @@ -575,12 +575,6 @@ static struct meson_clk_mpll gxbb_mpll2 = { }, }; -/* - * FIXME The legacy composite clocks (e.g. clk81) are both PLL post-dividers - * and should be modeled with their respective PLLs via the forthcoming - * coordinated clock rates feature - */ - static u32 mux_table_clk81[] = { 0, 2, 3, 4, 5, 6, 7 }; static const char * const clk81_parent_names[] = { "xtal", "fclk_div7", "mpll1", "mpll2", "fclk_div4", diff --git a/drivers/clk/meson/meson8b.c b/drivers/clk/meson/meson8b.c index ffadad27375e..db017c29a84c 100644 --- a/drivers/clk/meson/meson8b.c +++ b/drivers/clk/meson/meson8b.c @@ -849,7 +849,6 @@ static int meson8b_clkc_probe(struct platform_device *pdev) if (!meson8b_hw_onecell_data.hws[i]) continue; - /* FIXME convert to devm_clk_register */ ret = devm_clk_hw_register(dev, meson8b_hw_onecell_data.hws[i]); if (ret) return ret;