From patchwork Fri Feb 9 19:27:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcus Folkesson X-Patchwork-Id: 10209923 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5A12E60236 for ; Fri, 9 Feb 2018 19:32:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 44E9629759 for ; Fri, 9 Feb 2018 19:32:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 395BE29767; Fri, 9 Feb 2018 19:32:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id EA77329759 for ; Fri, 9 Feb 2018 19:32:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=50NxnN6+RcEfPwZOMHhOxUBRcv0PDuBVZZvGxHM6A8k=; b=TURsoGkf+Dx8LdkCgNKoLfowQK v2Q5JW3ScycO3mmRknhaapAVkmkR8qijr0JPTdbIs+I4sblfptmkWmVsj43j6DVvXrNYrQIbBsKQv RqJTk453Yg98SrLvRwvk+krWlu0bNB550t080mvQz+BZythDoJEOiwxhuxQBA18lXKPshcoxX5rls jkrcQAoobCzfzsMmynXKE34bdDSVA7m6tX4HAE4zdlkqipvUrTHRoMZp7BLRbsBU/Ki65OZLam/9w H6A/2d1+feZlT++GVoJuDlolZQejOZIz1tSeM0zdHb3evRVWl5lEwjs4TpbOgb7xgAxE5LGQ50gcE ag3pbaXA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1ekEPR-0005n8-4u; Fri, 09 Feb 2018 19:32:33 +0000 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1ekELC-0001fG-MZ; Fri, 09 Feb 2018 19:28:12 +0000 Received: by mail-lf0-x244.google.com with SMTP id h78so5496601lfg.6; Fri, 09 Feb 2018 11:28:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=U/ONSxS76A29EZBL2M5WZ0m6Vm8viSs4mdA4Z6/tQ0U=; b=YR27H/V3uAPtHNGMcj5gEBueDznMoIZYipytmduycd6GZRkfHoNoFa4emXUwsTiBNj WixXqYhhVB2JhDTkcJ5ZddrE5bpR4RFHD65VtC6nk9QPuqy/CjkPNXxuhKzOOx6+dDRt 25M3tYHL+/Z52r5xZvbg2udZyl3xJJeesrjIEBWtgJAoHzdJTClEQPfwqgy+4Y4KuMZn OhVbT4RU8IkYJDbdRgj0Lew9NLnziFJ5wb3FuFxzs17AZ5PqjRmpYc7GOYTAEMoGCkwN 4mW6i+HHoQFnRYeArvtnVuqgd26cryPq80NfDBL/XRO6+rDQdmHMZPJ72jTiL0fxCZBT /TsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=U/ONSxS76A29EZBL2M5WZ0m6Vm8viSs4mdA4Z6/tQ0U=; b=e16b35fvkBcBlCB0XxjxBnq9J5kFjx/2cORyANXjFxyzK2LaMPpCy5dtYshSpMibjv yT2XQ8Uf2jKe3tedcsEG0IrYy3Y09a1a4ax65HhKz4W2WWSRCKfb0NpVUAor3V6jLc/J y1nsovip04ckPnvLuLs9oxfRDeqJSrPf842LpGBj6xnRD9njngsHm6C5MipPCekOmm8e OAXPhdwpGSzArpUkcso13K00abJnBI9VM6mWe23d1l1w6mNIXPsAc/XaXdo++muoiP5R Cw7lI3tybMo19UuIt6y2NNgapOs6EaCic7ny6ydiqxV6BaQVa5UkkBZMLW4okkAYXjHU R+iA== X-Gm-Message-State: APf1xPAISQEJN3S1+MxfzUfPx3bs/WLDFJzgMpqd8/oAfUrMpm7zJ3es OQzPImw0DtKABs8BgBp/TLYKbp1M X-Google-Smtp-Source: AH8x224ndgJEq3MsKQpkHQzuE4wwTkuy9tiVnluPhEg3hhwc3ScJy4Plu5rHAaRmkeYekwXQL7gSjw== X-Received: by 10.46.36.21 with SMTP id k21mr2595421ljk.14.1518204488449; Fri, 09 Feb 2018 11:28:08 -0800 (PST) Received: from localhost.localdomain (c-2ec27091-74736162.cust.telenor.se. [46.194.112.145]) by smtp.gmail.com with ESMTPSA id e21sm570315lfb.51.2018.02.09.11.28.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Feb 2018 11:28:07 -0800 (PST) From: Marcus Folkesson To: Wim Van Sebroeck , Guenter Roeck , Rob Herring , Mark Rutland , Carlo Caione , Kevin Hilman , Matthias Brugger , Barry Song , Maxime Ripard , Chen-Yu Tsai , Linus Walleij , Vladimir Zapolskiy , Sylvain Lemieux , Nicolas Ferre , Alexandre Belloni Subject: [PATCH 4/7] watchdog: pnx4008: make use of timeout-secs provided in devicetree Date: Fri, 9 Feb 2018 20:27:21 +0100 Message-Id: <20180209192724.1227-5-marcus.folkesson@gmail.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180209192724.1227-1-marcus.folkesson@gmail.com> References: <20180209192724.1227-1-marcus.folkesson@gmail.com> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Marcus Folkesson , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP watchdog_init_timeout() will allways pick timeout_param since it defaults to a valid timeout. Following best practice described in Documentation/watchdog/watchdog-kernel-api.txt to make use of the parameter logic. Signed-off-by: Marcus Folkesson Reviewed-by: Guenter Roeck Reviewed-by: Guenter Roeck --- drivers/watchdog/pnx4008_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/pnx4008_wdt.c b/drivers/watchdog/pnx4008_wdt.c index 0529aed158a4..8e261799c84e 100644 --- a/drivers/watchdog/pnx4008_wdt.c +++ b/drivers/watchdog/pnx4008_wdt.c @@ -78,7 +78,7 @@ #define WDOG_COUNTER_RATE 13000000 /*the counter clock is 13 MHz fixed */ static bool nowayout = WATCHDOG_NOWAYOUT; -static unsigned int heartbeat = DEFAULT_HEARTBEAT; +static unsigned int heartbeat; static DEFINE_SPINLOCK(io_lock); static void __iomem *wdt_base;