From patchwork Sat Feb 10 09:19:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcus Folkesson X-Patchwork-Id: 10210429 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A070F60247 for ; Sat, 10 Feb 2018 09:21:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A52AB286B1 for ; Sat, 10 Feb 2018 09:21:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 994322968C; Sat, 10 Feb 2018 09:21:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2D1EC286B1 for ; Sat, 10 Feb 2018 09:21:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=cLPHyo+pLYNXnXpOeSpJmOWOtePxIhRcbeIAlbbeW2c=; b=D0qhVWtSN7dIjTd4wcSRliPC9O XEflFlttL/JuMy4nm7fpt3hY0teBFUI74luAMUtqJBt2973e7oYdtxnT5aiLNJkTq9nSfFLjrIfoS dRuLIzA6N4vu6Bq33WDjmIyRgGcTZ0vkLwCtbzflB68OGaOosGVARFHcubDvD/RZ3UfQJxIUeJCQE BqcDY6P/uaaLEXbHxSLUvAI+ajDZUuHDZtynR4iGNz+C/DqELa6PggPHr2xqsQxLI1g7jed9eJlsg k2yMeg9VaVFriH8yGXs4sgcRxsknCDrpEzMR7k2MHeArcdQ2rB1fTeUT9bhEaq3/mxnlJ/IGsEOSV Q3zogGCw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1ekRLf-00088S-0T; Sat, 10 Feb 2018 09:21:31 +0000 Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1ekRJx-00057H-Gj; Sat, 10 Feb 2018 09:19:48 +0000 Received: by mail-lf0-x243.google.com with SMTP id k19so14400410lfj.1; Sat, 10 Feb 2018 01:19:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=H2Wg9nRuNX02l7bkxEYKY/cnVmAhcd/Ie5xGJ5iD9OM=; b=eK4VSauhUWn0kkRZvta7w/rr8gIWtodVrUSz7prHhaZGRkxRjSvApQq68vzlQfP299 KG3IpRhJ4ph8JBbD+bqHyl8sR9Jg1MTobg8yS63IXILu8ajadSg80eE9HZj4fmQuSDvJ Q/YyXH0B3dZ48w4yHLqTtDe/pDQjrBWtwgJsxrTcQ4PkQs+4Z0AGrHwt7WIW756RhcCa rxzCTc/KUkX34u0jdnlSMBtuYCx7ffajNhxfR5j2UeBuRQThghn8RTmKf65QcVB1E7vs WJuSXw7Dfx/esmFKPyuajeIl/HwFVJhMd/HErzmhuRWHp+OdrnTLoDz7xyVVUv2gVEsy UrTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=H2Wg9nRuNX02l7bkxEYKY/cnVmAhcd/Ie5xGJ5iD9OM=; b=gAESpZliDxlSsLZcjm8f4y08le5Sp5lc6RMZv8tTZXgcOqGoWNIJC/I59oHhU+m4rI XDyQRbUfLTJ4Ek75G0xJ5dCQDb2SjhLUW0mKBQxbwR9UwsBCQsqCRJ+V80CIEmKhLJ9+ btnqH/VCG4avqRlTv2X90mNpMOmnpn+j1huiq+CDUf730UgKU59+Q+b9SGO2NO8Fxl7Q /buU3ijavOHdyayJPJX7jSQIsoVBlJj4x8NvxA8drmCKjvBwTK8FiKoZy5RsyTd1HjLj gWg1WZytF3sv/qD9ysbtiHlFrsfELlRMTDLstLvRyFj4iU51jqfdMeKcPTjQwvj7+LT9 d7bA== X-Gm-Message-State: APf1xPD9924MpflR4m9uOhY9RC6eKz/U0DcvOE7JzQkQg3ORBcuC2fuv UtAvqe79nRGZt38gaw3p49A= X-Google-Smtp-Source: AH8x227EIK+ifd/sanIW/ekQnrfqpfVO19O///9m2TSq9rz1Y42Wmw0UjZXJfbWSuF3ZqSnaEpe9QA== X-Received: by 10.46.44.21 with SMTP id s21mr3986426ljs.117.1518254375287; Sat, 10 Feb 2018 01:19:35 -0800 (PST) Received: from localhost.localdomain ([46.194.112.145]) by smtp.gmail.com with ESMTPSA id s9sm794551lfe.48.2018.02.10.01.19.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Feb 2018 01:19:34 -0800 (PST) From: Marcus Folkesson To: Wim Van Sebroeck , Guenter Roeck , Rob Herring , Mark Rutland , Carlo Caione , Kevin Hilman , Matthias Brugger , Barry Song , Maxime Ripard , Chen-Yu Tsai , Linus Walleij , Vladimir Zapolskiy , Sylvain Lemieux , Nicolas Ferre , Alexandre Belloni Subject: [PATCH v2 4/7] watchdog: pnx4008: make use of timeout-secs provided in devicetree Date: Sat, 10 Feb 2018 10:19:08 +0100 Message-Id: <20180210091911.3644-4-marcus.folkesson@gmail.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180210091911.3644-1-marcus.folkesson@gmail.com> References: <20180210091911.3644-1-marcus.folkesson@gmail.com> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Marcus Folkesson , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP watchdog_init_timeout() will allways pick timeout_param since it defaults to a valid timeout. Following best practice described in Documentation/watchdog/watchdog-kernel-api.txt to make use of the parameter logic. Signed-off-by: Marcus Folkesson Reviewed-by: Guenter Roeck --- drivers/watchdog/pnx4008_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/pnx4008_wdt.c b/drivers/watchdog/pnx4008_wdt.c index 0529aed158a4..8e261799c84e 100644 --- a/drivers/watchdog/pnx4008_wdt.c +++ b/drivers/watchdog/pnx4008_wdt.c @@ -78,7 +78,7 @@ #define WDOG_COUNTER_RATE 13000000 /*the counter clock is 13 MHz fixed */ static bool nowayout = WATCHDOG_NOWAYOUT; -static unsigned int heartbeat = DEFAULT_HEARTBEAT; +static unsigned int heartbeat; static DEFINE_SPINLOCK(io_lock); static void __iomem *wdt_base;