From patchwork Mon Feb 12 22:39:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 10214751 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7F95260236 for ; Mon, 12 Feb 2018 22:40:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 74DB628C92 for ; Mon, 12 Feb 2018 22:40:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 68C9328CAC; Mon, 12 Feb 2018 22:40:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C4B1A28C92 for ; Mon, 12 Feb 2018 22:40:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=casper.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:In-Reply-To:Message-Id:Date:Subject:To: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MQD4kIAU/gwggNDzkxZvnrqRx5k04KMbxhGYWsfUQM4=; b=RrXHzyE+QCm4LonD3dySTxyrpw /b1lhxCvKDTjnAIYJcNzE0zRVrsmx7Zn7ym5tVoJ8HrvMGaSffXG7bF5SZzLASmzbgLDD42grKhvo 7Zm4B6EqUBYbUdAiHSsU2qv8WhNu7Vqw+cUCBafkFPk96+YSqmiupOuxczLDKanYPml6GgfUk+/hs 9kncjRxN04W3Z2p5KUwFRPfxR2KkGUZVlmO+4jIlgDXTqAqiNh6G9UQ+cOcaJPNTj9P+W7aDU1wVK yG6MIg2wFm/Kb5Mg5Qy7CjIfl2ehGwd9UwGog87dDdrYpwK9lgSG3XguhPZ4kvVX2UpxhjwCK8G8H owbmTHrA==; Received: from [198.137.202.133] (helo=bombadil.infradead.org) by casper.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1elMlb-00013Y-9K; Mon, 12 Feb 2018 22:40:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:In-Reply-To:Message-Id:Date:Subject:To: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MQD4kIAU/gwggNDzkxZvnrqRx5k04KMbxhGYWsfUQM4=; b=lBd+91O6Mw4zin4bW/O0LKOqrc BkcxLFAtJquQ32f6xTark+yD9X/fCH+bZs/yVDQVrxb+poDdxBAjDlW0GlNnkvjG8Wzkfv2QofAmr elSLAGDjPACEtqexYxhtMmkruQq5q45CmPTV7h78s2vRMxBhDymXfDrt/nkK2+3PFEpf4xrVVDus2 zfKgFyqFMuZ5u5ydwYvExQknXZ58M+Sn81tSxHMa+l2LnDHWuCfGJE9QKj5sziK3hzkrQpGxwqfTA VyH8CHL1ONPSt26tF5X9nmCGElsumkFGsdQZbKsy7hRT9aCZm61+0leg3vfm7S6hv8m/rVDCmT1L8 iX0lXzMg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1elMlY-0000gm-AD; Mon, 12 Feb 2018 22:40:04 +0000 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1elMlS-0000PI-DV for linux-amlogic@lists.infradead.org; Mon, 12 Feb 2018 22:40:01 +0000 Received: by mail-wm0-x244.google.com with SMTP id a84so1118153wmi.5 for ; Mon, 12 Feb 2018 14:39:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hy5jqdM7jRbFJXe+gfgt4kspi+nxKgPl6pL1nyAoB6c=; b=c/lUhgIKKvIIcpnsNwFALyUR+iys9ej0fE59yZdhWfLbb+Bx9sinpY/oWjS4o7Ai4G SvvL0s8otiV8XF2DhdbEbfa9p0ox6cIXbkUxIq+EOknEmf7aNpqilFMJdon7x0OouzrN zxWPdOj/j2r9qR2e6vEY4e8oiKK+k9PxJOGv6v920lsKCw2yJpawp8PPAZfiJ81MNHw3 KonkWP4S+s1iffK3+J787eGA2gM2BGQiS0fMYvXDSdclahqNHavocz0WfcyBDeeca1+R yeO8hGU/uNGukdE6VWuLU5iVfeJfxM8unZT8oSp0tYXXVi6YCICVbFdLMm4pncruLZzE Rlog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hy5jqdM7jRbFJXe+gfgt4kspi+nxKgPl6pL1nyAoB6c=; b=IC/aTN1q0AB6d0iZx0uc2102BS9IijMwyRmiBXwTPEwJvjBTQdBffZpe9J91wctOBt Ftquo8yINvFz7RcCILlGB/GGOndorr1/vC77AHB1ANfrmGOvaE2CLRVjUsKlqO1NYo48 K7X6RIZQqD/1u6AyXvEOGYa322FqSeYy8iN2Dt1QkJHS+HNN59yGyWl5VzcnlhOqWfGZ JJZOT8FWjyN8ltGPSDJ+2n77jQr9ltKfmX0Ik3OUw/IU7iqHH/NGCInE9OdV09mt6f7U YXzuWMVou7mwyZ8JJ1tbtJ2uBdv8rbWRCvvdQNjubzlESspcWGNffRu+855Qh2/aF3ZC V0sA== X-Gm-Message-State: APf1xPBdDYdK0odH+1zkbrVtXKLWz3vA14W8mXS2ymO4BRGOrlKPQmrB HNt2Kn9DEyYfhfjEKpE1UGY= X-Google-Smtp-Source: AH8x22545mm20f3NlEAE6zB62sGA40SjVTmfPWNngf6xN+auYm4JkIFSKSmbsWo1bJ3t9jjxRqAcNA== X-Received: by 10.28.191.148 with SMTP id o20mr65085wmi.63.1518475186924; Mon, 12 Feb 2018 14:39:46 -0800 (PST) Received: from blackbox.darklights.net (p5DE38597.dip0.t-ipconnect.de. [93.227.133.151]) by smtp.googlemail.com with ESMTPSA id 11sm8125088wmp.36.2018.02.12.14.39.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Feb 2018 14:39:46 -0800 (PST) From: Martin Blumenstingl To: kishon@ti.com, linux-amlogic@lists.infradead.org Subject: [PATCH v2 3/5] phy: amlogic: phy-meson-gxl-usb2: default to host mode Date: Mon, 12 Feb 2018 23:39:26 +0100 Message-Id: <20180212223928.22993-4-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180212223928.22993-1-martin.blumenstingl@googlemail.com> References: <20180212223928.22993-1-martin.blumenstingl@googlemail.com> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, narmstrong@baylibre.com, Martin Blumenstingl , khilman@baylibre.com, yixun.lan@amlogic.com, robh+dt@kernel.org, carlo@caione.org, jbrunet@baylibre.com MIME-Version: 1.0 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The USB2 PHY can switch between PHY_MODE_USB_HOST and PHY_MODE_USB_DEVICE. However, it cannot do it on it's own since it requires re-routing of the corresponding USB pins from dwc3 (which is used for host-mode) to dwc2 (which is used for device-mode). Thus we don't need to auto-detect the mode based on the USB controller, which simplifies the driver code. Signed-off-by: Martin Blumenstingl Tested-by: Yixun Lan --- drivers/phy/amlogic/Kconfig | 1 - drivers/phy/amlogic/phy-meson-gxl-usb2.c | 15 ++------------- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/phy/amlogic/Kconfig b/drivers/phy/amlogic/Kconfig index 2f690d24203a..23fe1cda2f70 100644 --- a/drivers/phy/amlogic/Kconfig +++ b/drivers/phy/amlogic/Kconfig @@ -18,7 +18,6 @@ config PHY_MESON_GXL_USB2 default ARCH_MESON depends on OF && (ARCH_MESON || COMPILE_TEST) depends on USB_SUPPORT - select USB_COMMON select GENERIC_PHY select REGMAP_MMIO help diff --git a/drivers/phy/amlogic/phy-meson-gxl-usb2.c b/drivers/phy/amlogic/phy-meson-gxl-usb2.c index 303b2b46af3c..ee3c2c0c8572 100644 --- a/drivers/phy/amlogic/phy-meson-gxl-usb2.c +++ b/drivers/phy/amlogic/phy-meson-gxl-usb2.c @@ -20,7 +20,6 @@ #include #include #include -#include /* bits [31:27] are read-only */ #define U2P_R0 0x0 @@ -253,18 +252,8 @@ static int phy_meson_gxl_usb2_probe(struct platform_device *pdev) if (IS_ERR(base)) return PTR_ERR(base); - switch (of_usb_get_dr_mode_by_phy(dev->of_node, -1)) { - case USB_DR_MODE_PERIPHERAL: - priv->mode = PHY_MODE_USB_DEVICE; - break; - case USB_DR_MODE_OTG: - priv->mode = PHY_MODE_USB_OTG; - break; - case USB_DR_MODE_HOST: - default: - priv->mode = PHY_MODE_USB_HOST; - break; - } + /* start in host mode */ + priv->mode = PHY_MODE_USB_HOST; priv->regmap = devm_regmap_init_mmio(dev, base, &phy_meson_gxl_usb2_regmap_conf);