| Message ID | 20180418193951.17922-7-martin.blumenstingl@googlemail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Wed, Apr 18, 2018 at 09:39:51PM +0200, Martin Blumenstingl wrote: > This clarifies the license of the code. While here also add an include > guard to the header file. > > Fixes: 07dbff0ddbd86c ("usb: core: add a wrapper for the USB PHYs on the HCD") > Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com> > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > drivers/usb/core/phy.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/usb/core/phy.h b/drivers/usb/core/phy.h > index bbc969383074..88a3c037e9df 100644 > --- a/drivers/usb/core/phy.h > +++ b/drivers/usb/core/phy.h > @@ -1,3 +1,13 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ Do you _really_ mean GPLv2 or anything later? I have to ask... thanks, greg k-h
Hi Greg, On Sun, Apr 22, 2018 at 3:01 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Wed, Apr 18, 2018 at 09:39:51PM +0200, Martin Blumenstingl wrote: >> This clarifies the license of the code. While here also add an include >> guard to the header file. >> >> Fixes: 07dbff0ddbd86c ("usb: core: add a wrapper for the USB PHYs on the HCD") >> Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com> >> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> >> --- >> drivers/usb/core/phy.h | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/drivers/usb/core/phy.h b/drivers/usb/core/phy.h >> index bbc969383074..88a3c037e9df 100644 >> --- a/drivers/usb/core/phy.h >> +++ b/drivers/usb/core/phy.h >> @@ -1,3 +1,13 @@ >> +/* SPDX-License-Identifier: GPL-2.0+ */ > > Do you _really_ mean GPLv2 or anything later? drivers/usb/core/hcd.c uses the same license identifier that code is much more "valuable" than my few lines which manage a list of PHYs - so I'm fine with "GPLv2 or anything later" > I have to ask... if you see any problems with this (for example that phy.h couldn't be used from some special module with another license, ...) then please let me know Regards Martin
On Sun, Apr 22, 2018 at 09:41:56PM +0200, Martin Blumenstingl wrote: > Hi Greg, > > On Sun, Apr 22, 2018 at 3:01 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > > On Wed, Apr 18, 2018 at 09:39:51PM +0200, Martin Blumenstingl wrote: > >> This clarifies the license of the code. While here also add an include > >> guard to the header file. > >> > >> Fixes: 07dbff0ddbd86c ("usb: core: add a wrapper for the USB PHYs on the HCD") > >> Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com> > >> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > >> --- > >> drivers/usb/core/phy.h | 12 ++++++++++++ > >> 1 file changed, 12 insertions(+) > >> > >> diff --git a/drivers/usb/core/phy.h b/drivers/usb/core/phy.h > >> index bbc969383074..88a3c037e9df 100644 > >> --- a/drivers/usb/core/phy.h > >> +++ b/drivers/usb/core/phy.h > >> @@ -1,3 +1,13 @@ > >> +/* SPDX-License-Identifier: GPL-2.0+ */ > > > > Do you _really_ mean GPLv2 or anything later? > drivers/usb/core/hcd.c uses the same license identifier > that code is much more "valuable" than my few lines which manage a > list of PHYs - so I'm fine with "GPLv2 or anything later" > > > I have to ask... > if you see any problems with this (for example that phy.h couldn't be > used from some special module with another license, ...) then please > let me know Nope, that's fine, thanks for the quick response, I'll go apply this now. greg k-h
diff --git a/drivers/usb/core/phy.h b/drivers/usb/core/phy.h index bbc969383074..88a3c037e9df 100644 --- a/drivers/usb/core/phy.h +++ b/drivers/usb/core/phy.h @@ -1,3 +1,13 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* + * USB roothub wrapper + * + * Copyright (C) 2018 Martin Blumenstingl <martin.blumenstingl@googlemail.com> + */ + +#ifndef __USB_CORE_PHY_H_ +#define __USB_CORE_PHY_H_ + struct device; struct usb_phy_roothub; @@ -13,3 +23,5 @@ int usb_phy_roothub_suspend(struct device *controller_dev, struct usb_phy_roothub *phy_roothub); int usb_phy_roothub_resume(struct device *controller_dev, struct usb_phy_roothub *phy_roothub); + +#endif /* __USB_CORE_PHY_H_ */
This clarifies the license of the code. While here also add an include guard to the header file. Fixes: 07dbff0ddbd86c ("usb: core: add a wrapper for the USB PHYs on the HCD") Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- drivers/usb/core/phy.h | 12 ++++++++++++ 1 file changed, 12 insertions(+)